Fix - Display @Hidden mentions in LHN #59551

FitseTLT · 2025-04-02T16:40:51Z

Details

Fixed Issues

$ #57345
PROPOSAL: #57345 (comment)

Tests

Go to a workspace chat
Mention the email @[email protected]
Go to Troubleshoot > clear cache
Re-open the chat (Note: after clearing cache or signing in U have to open the chat so that the messages in the report will be loaded for this pr to work correctly)
Verify that the LHN of the workspace chat in (1) shows @Hidden while the previous mention in (2) has now changed to @Hidden

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-04-02T16:40:56Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2025-04-02T16:41:59Z

@eh2077 I am still seeing inconsistency between the LHN and last action after I press do nothing on the hidden mention. 😭

2025-04-02.19-38-41.mp4

eh2077 · 2025-04-03T14:24:08Z

@FitseTLT I can't reproduce the issue any more. I tried both new account and old account but they don't show hidden user mentions. Are you still able to reproduce the issue?

Screen.Recording.2025-04-03.at.10.22.06.PM.mov

FitseTLT · 2025-04-03T14:25:51Z

U have to clear cache or re-sign in 👍

eh2077 · 2025-04-03T14:32:00Z

I tried both ways but not working

FitseTLT · 2025-04-03T14:43:10Z

😕

2025-04-03.17-35-24.mp4

eh2077 · 2025-04-03T15:32:19Z

@FitseTLT Thanks! I tried typing random email mentions and they don't work. But email with unexisting prefix works!

Back to the issue, I think we shouldn't show whisper message on LHN right? If so, then I'd suggest formatting the html msg from the last visible action, like

lastMessageTextFromReport = Parser.htmlToText(getReportActionHtml(lastReportAction));

FitseTLT · 2025-04-04T22:18:03Z

With this approach the whisper message will not be on LHN but the report lastMessageText is the whisper message if it is the last action so it will be considered as a regression.

eh2077 · 2025-04-05T00:29:37Z

@FitseTLT I think we shouldn't display whisper message in LHN, so it won't be a problem?

FitseTLT · 2025-04-07T12:08:29Z

@eh2077 But the problem is, before clearing cache when the unexisting mention was displayed in the report screen the LHN shows the whisper so only after clearing cache does our code hide it. Don't u think this is unexpected behavior?

2025-04-07.15-04-36.mp4

eh2077 · 2025-04-07T12:17:37Z

@FitseTLT I think we shouldn't show whisper message in LHN, so that should be a bug. If you're not sure, then we can ask the team to confirm this.

FitseTLT · 2025-04-07T12:20:26Z

@FitseTLT I think we shouldn't show whisper message in LHN, so that should be a bug. If you're not sure, then we can ask the team to confirm this.

@eh2077 If we don't show whispers then we should be consistent, that's my logic in the above comment.

eh2077 · 2025-04-07T12:30:42Z

@FitseTLT Sorry, I'm confused. My point is that the whisper message shouldn't be shown in LHN. It doesn't matter whether clearing the cache or not. As long as the whisper message is shown in LHN, then it should be a bug. Do you agree?

eh2077 · 2025-04-07T13:20:53Z

After clearing cache, the unexisting account hasn't been loaded into allPersonalDetails, so method hasHiddenDisplayNames return false. Can you fix it?

For other cases, if the whisper msg still shows in LHN, maybe we can handle by

if (lastOriginalReportAction && isWhisperAction(lastOriginalReportAction)) {
      // format msg from last visible action instead of report.lastMessageText
}

eh2077 · 2025-04-14T00:35:56Z

@FitseTLT Friendly bump

FitseTLT · 2025-04-14T18:41:55Z

After clearing cache, the unexisting account hasn't been loaded into allPersonalDetails, so method hasHiddenDisplayNames return false. Can you fix it?

From my debugging this problem is not related with allPersonalDetails but after clearing cache the proper last report action isn't loaded until you open the report.

@FitseTLT Sorry, I'm confused. My point is that the whisper message shouldn't be shown in LHN. It doesn't matter whether clearing the cache or not. As long as the whisper message is shown in LHN, then it should be a bug. Do you agree?

I'm not sure about this. BTW whisper action is not included as lastVisibleReportActions but the lastMessageText includes it if it is a bug it is a BE one and there is no reliable FE solution because last report action is not always ready for instance before we open the report just after sign in.

eh2077 · 2025-04-15T15:45:28Z

After clearing cache, the unexisting account hasn't been loaded into allPersonalDetails, so method hasHiddenDisplayNames return false. Can you fix it?

From my debugging this problem is not related with allPersonalDetails but after clearing cache the proper last report action isn't loaded until you open the report.

Ok, I agree with you. After clearing cache and the report is not opened yet, the value of lastReportAction is undefined. Maybe we should handle the issue about whisper message separately, wdyt?

eh2077 · 2025-04-22T14:22:51Z

@FitseTLT Friendly bump

eh2077 · 2025-04-25T12:42:45Z

@FitseTLT Friendly bump

FitseTLT · 2025-04-25T22:04:56Z

After clearing cache, the unexisting account hasn't been loaded into allPersonalDetails, so method hasHiddenDisplayNames return false. Can you fix it?

From my debugging this problem is not related with allPersonalDetails but after clearing cache the proper last report action isn't loaded until you open the report.

Ok, I agree with you. After clearing cache and the report is not opened yet, the value of lastReportAction is undefined. Maybe we should handle the issue about whisper message separately, wdyt?

Sorry @eh2077 for the slow response I was OOO. I am not following you here if we should handle it separately what are you suggesting as the next steps on this pr?

eh2077 · 2025-04-28T11:05:33Z

@FitseTLT Yes, let's make sure this #57345 (comment) issue gets fixed. I think the issue about whisper message should be handled separately.

FitseTLT · 2025-04-28T14:21:21Z

OK U can proceed @eh2077

eh2077 · 2025-04-29T12:33:36Z

@FitseTLT There're conflicts need to be resolved

FitseTLT · 2025-04-29T22:03:05Z

resolved

eh2077 · 2025-04-30T12:07:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eh2077 · 2025-04-30T13:48:37Z

[ ] I verified there are no new alerts related to the canBeMissing param for useOnyx

I'd like to skip this item of the checklist in this PR because there's an ongoing PR #60531 to handle all exiting alerts.

eh2077

LGTM

blimpich

LGTM. By the way, I think the whisper message is suppose to be in the LHN, or at least I don't see why it wouldn't be? Just my two cents.

src/libs/OptionsListUtils.ts

MelvinBot · 2025-05-01T16:32:54Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

thienlnam · 2025-05-01T17:00:39Z

It seems like this is causing the failing test

FAIL tests/unit/SidebarUtilsTest.ts (6.643 s)
  ● SidebarUtils › getOptionsData › returns @Hidden as an alternate text if the last action mentioned account has no name

    expect(received).toBe(expected) // Object.is equality

    Expected: "f50: @Hidden"
    Received: "f50: @[email protected]"

      637 |
      638 |             // Then the alternate text should show @Hidden.
    > 639 |             expect(result?.alternateText).toBe(`f50: @Hidden`);
          |                                           ^
      640 |         });
      641 |
      642 |         describe('Alternative text', () => {

      at Object.toBe (tests/unit/SidebarUtilsTest.ts:639:43)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)

FitseTLT · 2025-05-01T17:03:14Z

It seems like this is causing the failing test

FAIL tests/unit/SidebarUtilsTest.ts (6.643 s)
  ● SidebarUtils › getOptionsData › returns @Hidden as an alternate text if the last action mentioned account has no name

    expect(received).toBe(expected) // Object.is equality

    Expected: "f50: @Hidden"
    Received: "f50: @[email protected]"

      637 |
      638 |             // Then the alternate text should show @Hidden.
    > 639 |             expect(result?.alternateText).toBe(`f50: @Hidden`);
          |                                           ^
      640 |         });
      641 |
      642 |         describe('Alternative text', () => {

      at Object.toBe (tests/unit/SidebarUtilsTest.ts:639:43)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)

Checking

OSBotify · 2025-05-01T17:04:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

blimpich · 2025-05-01T17:28:49Z

Update: Handled flaky test here. All good now 👍

github-actions · 2025-05-01T20:06:40Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.39-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-06T01:04:33Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.39-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

display @hidden mentions in LHN

1c720bf

FitseTLT requested a review from a team as a code owner April 2, 2025 16:40

melvin-bot bot requested review from eh2077 and removed request for a team April 2, 2025 16:40

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

7fc6f80

FitseTLT added 2 commits April 7, 2025 14:41

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

3cee2b7

take the last message from the last report action html

0a4285f

Christinadobrzyn mentioned this pull request Apr 7, 2025

[Due for payment 2025-05-13] [$250] Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions #57345

Closed

8 tasks

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

0f452e2

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

62ce17e

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

6bc0c7c

eh2077 approved these changes Apr 30, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich April 30, 2025 13:49

blimpich assigned FitseTLT Apr 30, 2025

blimpich approved these changes Apr 30, 2025

View reviewed changes

blimpich requested changes Apr 30, 2025

View reviewed changes

src/libs/OptionsListUtils.ts Show resolved Hide resolved

FitseTLT added 3 commits May 1, 2025 15:45

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

c2538b8

Merge branch 'main' into fix-show-@hidden-mentions-in-LHN

3191948

added test

cb4d35a

blimpich approved these changes May 1, 2025

View reviewed changes

blimpich merged commit 57148af into Expensify:main May 1, 2025
18 checks passed

github-actions bot mentioned this pull request May 1, 2025

[Due for payment 2025-05-13] Investigate workflow job failing on main: test / test (job 2) #61255

Closed

github-actions bot mentioned this pull request May 1, 2025

Deploy Checklist: New Expensify 2025-05-01 #61263

Closed

61 tasks

Fix - Display @Hidden mentions in LHN #59551

Fix - Display @Hidden mentions in LHN #59551

Uh oh!

Conversation

FitseTLT commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

eh2077 commented Apr 3, 2025

Uh oh!

FitseTLT commented Apr 3, 2025

Uh oh!

eh2077 commented Apr 3, 2025

Uh oh!

FitseTLT commented Apr 3, 2025

Uh oh!

eh2077 commented Apr 3, 2025

Uh oh!

FitseTLT commented Apr 4, 2025

Uh oh!

eh2077 commented Apr 5, 2025

Uh oh!

FitseTLT commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Apr 7, 2025

Uh oh!

FitseTLT commented Apr 7, 2025

Uh oh!

eh2077 commented Apr 7, 2025

Uh oh!

eh2077 commented Apr 7, 2025

Uh oh!

eh2077 commented Apr 14, 2025

Uh oh!

FitseTLT commented Apr 14, 2025

Uh oh!

eh2077 commented Apr 15, 2025

Uh oh!

eh2077 commented Apr 22, 2025

Uh oh!

eh2077 commented Apr 25, 2025

Uh oh!

FitseTLT commented Apr 25, 2025

Uh oh!

eh2077 commented Apr 28, 2025

Uh oh!

FitseTLT commented Apr 28, 2025

Uh oh!

eh2077 commented Apr 29, 2025

Uh oh!

FitseTLT commented Apr 29, 2025

Uh oh!

eh2077 commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Apr 30, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MelvinBot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

FitseTLT commented Apr 2, 2025 •

edited

Loading

FitseTLT commented Apr 7, 2025 •

edited

Loading

eh2077 commented Apr 30, 2025 •

edited

Loading

MelvinBot commented May 1, 2025 •

edited

Loading