-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-05-13] [$250] Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions #57345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @Christinadobrzyn ( |
I'm not able to reproduce this, I'm getting the tooltip with the [email protected] email. Asking QA for more information on how to troubleshoot |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Screen.Recording.2025-02-26.at.8.28.18.AM.mov@Christinadobrzyn I can reproduce it in DM chat |
According to slack
@Christinadobrzyn If we want to fix this issue, please assign me as C+. Thank you! |
I feel like this is an ongoing issue where hidden replaces a customer name. @eh2077 I'll assign you but I also feel like this might need a bigger discussion because we've had lots of issues to resolve this hidden name but I feel like it's not finding the root. You probably know more about this but I'm just concerned we're chasing our tails with these hidden GHs. Do you think it's worth bringing this up to the wider team? |
@Christinadobrzyn Yes, I agree. I'm not sure if our team has updated something, like privacy policy, which has an impact to this. |
Okay, thanks, I'll bring this up to the team for discussion |
@Christinadobrzyn will you tag me in the post plz? I don't understand why we show |
@mallenexpensify I only found a recent similar issue #51186 |
K- asking the team for their thoughts here - https://expensify.slack.com/archives/C05LX9D6E07/p1741017120711489 |
nothing from the team yet, I'll give it another day and nudge |
nothing from the team - I'll need to figure out another location to discuss this. I'll reach out to @mallenexpensify to see if we can discuss on a call. |
@Christinadobrzyn @eh2077 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@Christinadobrzyn have you reviewed the test cases to see if anythign's there? |
@Christinadobrzyn, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Nothing that shows the root of this. There appears to be only one related test case, which is crazy because I feel like this happens a lot. I created a SO for Puneet to answer based on our Slack convo |
Okay I think this answer is accurate on when "Hidden" shows -
Based on this and reviewing the steps in the OP - I think this is expected since the 'Hidden' user is not known. @eh2077 can you give your thoughts? I think we can close this |
working on PR - #59551 |
This issue has not been updated in over 15 days. @blimpich, @FitseTLT, @Christinadobrzyn, @eh2077 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Looks like this is actively being worked on (link) still. Progress is being made. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-13. 🎊 For reference, here are some details about the assignees on this issue:
|
@eh2077 @Christinadobrzyn @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@eh2077 do we need a regression test? |
Payment summary - #57345 (comment) @eh2077 can you let us know about a regression test so we can pay this out? |
@Christinadobrzyn Thanks for the reminder! I think we will need a regression test. I'll update it by tmr, thank you. |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalPrecondition:NA Test:
Do we agree 👍 or 👎 |
Thanks @eh2077! Regression test here - #57345 (comment) Payment summary here - #57345 (comment) @eh2077 will you please make sure to request payment in ND? TY! |
Yeah, requested payment in NewDot, thanks |
$250 approved for @eh2077 |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.4-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2661796
Issue reported by: Applause Internal Team
Device used: Win 11
App Component: Chat Report View
Action Performed:
Expected Result:
Verify that the user detail is displayed inside the tooltip when users mentions @[email protected]
Actual Result:
When mentioning someone using their full email address (e.g., @[email protected]) who is not in the suggestion list, the user detail tooltip is hidden
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6752978_1740429916506.C3073340.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @ChristinadobrzynThe text was updated successfully, but these errors were encountered: