Skip to content

[Due for payment 2025-05-13] [$250] Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions #57345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
IuliiaHerets opened this issue Feb 24, 2025 · 71 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.4-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2661796
Issue reported by: Applause Internal Team
Device used: Win 11
App Component: Chat Report View

Action Performed:

  1. Open the link https://staging.new.expensify.com/
  2. Login with any account
  3. Go to any chat
  4. Mention any user by typing @ in the composer and selecting anyone from the list
  5. Hover the cursor on the mentioned user
  6. Verify that the user detail displayed inside the tooltip
  7. Now mention someone not in the mention suggestion by typing their full email like @[email protected]
  8. Hover the cursor on the mentioned user
  9. Verify that the user detail displayed inside the tooltip

Expected Result:

Verify that the user detail is displayed inside the tooltip when users mentions @[email protected]

Actual Result:

When mentioning someone using their full email address (e.g., @[email protected]) who is not in the suggestion list, the user detail tooltip is hidden

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6752978_1740429916506.C3073340.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021902849458546567108
  • Upwork Job ID: 1902849458546567108
  • Last Price Increase: 2025-03-27
  • Automatic offers:
    • FitseTLT | Contributor | 106749898
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @Christinadobrzyn
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Christinadobrzyn
Copy link
Contributor

I'm not able to reproduce this, I'm getting the tooltip with the [email protected] email. Asking QA for more information on how to troubleshoot

Image

@Christinadobrzyn Christinadobrzyn added the Needs Reproduction Reproducible steps needed label Feb 25, 2025
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@eh2077
Copy link
Contributor

eh2077 commented Feb 26, 2025

Screen.Recording.2025-02-26.at.8.28.18.AM.mov

@Christinadobrzyn I can reproduce it in DM chat

@eh2077
Copy link
Contributor

eh2077 commented Feb 26, 2025

According to slack

Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions needs reproduction. The first C+ to post on the GH issue with reliable reproduction steps and video or screenshots confirming reproduction will be assigned as C+.
Please add a ✅ to the message if you have posted reliable steps on the issue.

@Christinadobrzyn If we want to fix this issue, please assign me as C+. Thank you!

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Feb 26, 2025

I feel like this is an ongoing issue where hidden replaces a customer name. @eh2077 I'll assign you but I also feel like this might need a bigger discussion because we've had lots of issues to resolve this hidden name but I feel like it's not finding the root. You probably know more about this but I'm just concerned we're chasing our tails with these hidden GHs.

Do you think it's worth bringing this up to the wider team?

@eh2077
Copy link
Contributor

eh2077 commented Feb 27, 2025

Do you think it's worth bringing this up to the wider team?

@Christinadobrzyn Yes, I agree. I'm not sure if our team has updated something, like privacy policy, which has an impact to this.

@Christinadobrzyn
Copy link
Contributor

Okay, thanks, I'll bring this up to the team for discussion

@mallenexpensify
Copy link
Contributor

@Christinadobrzyn will you tag me in the post plz? I don't understand why we show hidden, reckon there's a discussion about somewhere that I missed. @eh2077 , do you know why?

@eh2077
Copy link
Contributor

eh2077 commented Mar 3, 2025

@mallenexpensify I only found a recent similar issue #51186

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Mar 3, 2025

K- asking the team for their thoughts here - https://expensify.slack.com/archives/C05LX9D6E07/p1741017120711489

@Christinadobrzyn
Copy link
Contributor

nothing from the team yet, I'll give it another day and nudge

@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2025
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Mar 7, 2025

nothing from the team - I'll need to figure out another location to discuss this.

I'll reach out to @mallenexpensify to see if we can discuss on a call.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 7, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

@Christinadobrzyn @eh2077 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mallenexpensify
Copy link
Contributor

@Christinadobrzyn have you reviewed the test cases to see if anythign's there?
https://expensify.testrail.io/index.php?/new_search/results&queries[]=hidden&category[]=2

Copy link

melvin-bot bot commented Mar 11, 2025

@Christinadobrzyn, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Mar 11, 2025

have you reviewed the test cases to see if anythign's there?

Nothing that shows the root of this. There appears to be only one related test case, which is crazy because I feel like this happens a lot.

I created a SO for Puneet to answer based on our Slack convo

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2025
@mallenexpensify mallenexpensify moved this from MEDIUM to LOW in [#whatsnext] #quality Mar 13, 2025
@Christinadobrzyn
Copy link
Contributor

Okay I think this answer is accurate on when "Hidden" shows -

I believe they have to be established as "known" in order to have the email be shown, which is being a workspace member or having DMs between the two accounts.

Based on this and reviewing the steps in the OP - I think this is expected since the 'Hidden' user is not known. @eh2077 can you give your thoughts? I think we can close this

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2025
@Christinadobrzyn
Copy link
Contributor

working on PR - #59551

2 similar comments
@Christinadobrzyn
Copy link
Contributor

working on PR - #59551

@Christinadobrzyn
Copy link
Contributor

working on PR - #59551

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 28, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

This issue has not been updated in over 15 days. @blimpich, @FitseTLT, @Christinadobrzyn, @eh2077 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blimpich
Copy link
Contributor

Looks like this is actively being worked on (link) still. Progress is being made.

@blimpich blimpich added Weekly KSv2 and removed Monthly KSv2 labels Apr 28, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 6, 2025
@melvin-bot melvin-bot bot changed the title [$250] Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions [Due for payment 2025-05-13] [$250] Web - Mentions -Tooltips Not Displayed for Non-Suggestion User Mentions May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 6, 2025

@eh2077 @Christinadobrzyn @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 12, 2025
@Christinadobrzyn
Copy link
Contributor

@eh2077 do we need a regression test?

@Christinadobrzyn
Copy link
Contributor

Payment summary - #57345 (comment)

@eh2077 can you let us know about a regression test so we can pay this out?

@eh2077
Copy link
Contributor

eh2077 commented May 14, 2025

@Christinadobrzyn Thanks for the reminder! I think we will need a regression test. I'll update it by tmr, thank you.

@eh2077
Copy link
Contributor

eh2077 commented May 15, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other: missing corner use case.

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other: Reported on GH

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: I can't find a PR that directly causes this issue.

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue: https://github.com/Expensify/Expensify/issues/501400

Regression Test Proposal

Precondition:

NA

Test:

  1. Go to the Your space chat
  2. Mention the email @[email protected]
  3. Verify that both chat and LHN message are shown as @Hidden

Do we agree 👍 or 👎

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 15, 2025

Thanks @eh2077!

Regression test here - #57345 (comment)

Payment summary here - #57345 (comment)

@eh2077 will you please make sure to request payment in ND? TY!

@eh2077
Copy link
Contributor

eh2077 commented May 16, 2025

Yeah, requested payment in NewDot, thanks

@JmillsExpensify
Copy link

$250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

10 participants