[Due for payment 2025-05-13] Investigate workflow job failing on main: test / test (job 2)

[github-actions]

🚨 Failure Summary 🚨:

• 📋 Job Name: test / test (job 2)
• 🔧 Failure in Workflow: Process new code merged to main
• 🔗 Triggered by PR: PR Link
• 👤 PR Author: @FitseTLT
• 🤝 Merged by: @blimpich
• 🐛 Error Message:
  failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 2).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

1. Why the PR caused the job to fail?
2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

[blimpich]

Probably a flake: https://expensify.slack.com/archives/C03V9A4TB/p1746119273412529?thread_ts=1746118626.579799&cid=C03V9A4TB

Strange though that it would flake on a brand new test. That would be a strange coincidence. Looks like contributor is looking into it here: #59551 (comment)

[FitseTLT]

@blimpich the cause is createRandomReportAction setting a random pending Action here so it will fail if it is set to DELETE

App/tests/utils/collections/reportActions.ts

Line 72 in 8afaf50

pendingAction: rand(Object.values(CONST.RED_BRICK_ROAD_PENDING_ACTION)),

I have suggested previously that we should avoid this random functions but no one took action 😭
I have raised the pr

[blimpich]

Sounds good! Just merged your PR, thank you @FitseTLT for speedy action! 🙏🙂

[blimpich]

Closing this as this was handled.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• NO QA - fix - Investigate workflow job failing on main: test / test (job 2) #61257

If no regressions arise, payment will be issued on 2025-05-13. 🎊