fix: autoGrow prop on mobile is handled by native platform #59078

Nodonisko · 2025-03-25T15:51:31Z

Explanation of Change

This PR is based on work from @hannojg in #50238 and it's partially removing complicated autoGrow using layout events from Text to update dimension of TextInput. This is not necessary on native platforms because they can auto grow by default.

Sadly on Android there is bug in RN that is causing component to be jumpy if I remove this autoGrow features that are adding some width buffer to Android component. For that reason I moved most of measuring logic into new component that is used only for Android + Web platforms so even more code is now reused across web and native.

Fixed Issues

$ #19961

Tests

Sign in to any account
Go to any DM
Tap + in the compose box > Create Expense > Manual
Enter the amount
Verify that no jumpy behavior when entering the digits

Offline tests

QA Steps

Sign in to any account
Go to any DM
Tap + in the compose box > Create Expense > Manual
Enter the amount
Verify that no jumpy behavior when entering the digits

PR Author Checklist

Screenshots/Videos

Android: Native

adndroid-text-input.webm

Android: mWeb Chrome

android-web.webm

iOS: Native

ios-text-input.mp4

iOS: mWeb Safari

ios-safari.mp4

MacOS: Chrome / Safari

web-chrome.mov

MacOS: Desktop

mac-desktop.mov

melvin-bot · 2025-03-25T15:51:36Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-03-25T15:51:36Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-03-25T15:51:44Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

hoangzinh · 2025-03-25T15:57:16Z

Hi @Nodonisko just wanna confirm if this PR will fix this issue #19961, wont it?

Nodonisko · 2025-03-25T16:08:39Z

I have read the CLA Document and I hereby sign the CLA

hannojg · 2025-03-25T16:09:31Z

Yes @Nodonisko is from margelo and took the task over from me 😊

hoangzinh · 2025-03-25T16:19:04Z

@aimane-chnaif, because you're already assigned as C+ in this issue #19961, do you want to review this issue or me?

Nodonisko · 2025-03-25T16:55:01Z

After some testing it looks that iOS is really fixed but now Android seems to glitch in very similar way. I will continue my investigation.

mountiny · 2025-03-25T21:02:31Z

@hoangzinh seems like Aimane is ooo so please take it over

github-actions · 2025-03-25T21:03:46Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-03-25T21:04:23Z

Ahoj Daniel 👋 welcome to the team 🙇

Great job! let us know when the android part is ready too but I think @hoangzinh could already test and review the ios fix

github-actions · 2025-03-25T21:48:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59078-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59078-hybrid/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

hoangzinh · 2025-03-26T14:22:57Z

@Nodonisko can you help to merge the latest main into this branch?

hoangzinh · 2025-03-26T14:28:16Z

@Nodonisko regarding testing steps, please follow this guidlines

In our case, it should be something like this:

Sign in to any account
Go to any DM
Tap + in the compose box > Create Expense > Manual
Enter the amount
Verify that no jumpy behavior when entering the digits

Nodonisko · 2025-03-26T18:21:26Z

@hoangzinh Sorry I will update testing guide, but probably hold on with testing for now because I discovered issue on Android that needs to be fixed first #19961 (comment)

Nodonisko · 2025-04-16T08:50:08Z

@hoangzinh So I found simple hotfix in the end. 168e73f

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-16.at.10.46.50.mp4

hoangzinh · 2025-04-16T14:47:12Z

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

@@ -80,6 +81,10 @@ function BaseTextInput(
    }: BaseTextInputProps,
    ref: ForwardedRef<BaseTextInputRef>,
 ) {
+    // For iOS, we don't need to measure the text input because it already has auto grow behavior
+    // See TextInputMeasurement.ios.tsx for more details
+    const isExternalAutoGrowMeasurement = Platform.OS !== 'ios' && autoGrow;


Suggested change

const isExternalAutoGrowMeasurement = Platform.OS !== 'ios' && autoGrow;

const isExternalAutoGrowMeasurement = getPlatform() !== CONST.PLATFORM.IOS && autoGrow;

hoangzinh · 2025-04-16T15:57:33Z

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

@@ -360,8 +369,8 @@ function BaseTextInput(
                                placeholderTextColor={placeholderTextColor ?? theme.placeholderText}
                                underlineColorAndroid="transparent"
                                style={[
-                                    styles.flex1,
-                                    styles.w100,
+                                    !autoGrow && styles.flex1,


Can you explain why do we need to that this condition?

Yea sure, so previous solution (still present for Android) measured size of Text component and set same width to TextInput so width was specified with some absolute value.

Now on iOS we must not have any width specified or native auto grow won't work. So we don't want to apply anything that will set width manually like flex1 or width100

Thank you @Nodonisko

mountiny · 2025-04-16T16:23:24Z

I would not worry about issues that are only in dev with the hardware keyboard for this pr but lets fix it without a workaround so maybe the new masked input in a next pr?

hoangzinh · 2025-04-16T22:35:32Z

@mountiny should @Nodonisko revert this workaround, or is it okay for now?

mountiny · 2025-04-17T17:22:31Z

Sorry if I was not clear. We can use it for now, but we should not drop the ball and still try to pursue more complex but better fix (and removing the workaround then)

hoangzinh · 2025-04-18T14:42:05Z

I see, I will try to complete review checklist tomorrow

hoangzinh · 2025-04-19T05:42:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-19.at.13.13.00.android.mov

Android: mWeb Chrome

Screen.Recording.2025-04-19.at.13.15.28.chrome.android.mov

iOS: Native

Screen.Recording.2025-04-19.at.15.15.03.mov

iOS: mWeb Safari

Screen.Recording.2025-04-19.at.13.16.24.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-19.at.13.00.16.web.mov

MacOS: Desktop

Screen.Recording.2025-04-19.at.13.06.30.desktop.mov

mountiny

Looks great, thanks for your patience and congrats @Nodonisko for one of your first prs!

OSBotify · 2025-04-19T15:12:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-21T23:40:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.31-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-23T18:17:08Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.31-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

aldo-expensify · 2025-04-24T06:58:56Z

This PR seems to be causing this deploy blocker: #60765

shubham1206agra · 2025-05-05T05:08:46Z

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

@@ -273,6 +279,10 @@ function BaseTextInput(

    // Height fix is needed only for Text single line inputs
    const shouldApplyHeight = !isMultiline && !isMarkdownEnabled;
+
+    // Fix iOS cursor jumping when entering first character using HW keyboard https://github.com/Expensify/App/pull/59078#issuecomment-2802834037
+    const selection = inputProps.selection?.end === 0 && inputProps.selection?.start === 0 ? undefined : inputProps.selection;


This change caused a bug. Details in #60640

Nodonisko requested a review from a team as a code owner March 25, 2025 15:51

melvin-bot bot requested review from hoangzinh and removed request for a team March 25, 2025 15:51

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 25, 2025

@Nodonisko has signed the CLA in Expensify/App#59078

8f8cbd8

hannojg mentioned this pull request Mar 25, 2025

[HOLD on #48160] fix: autoGrow prop on mobile is handled by native platform #50238

Closed

50 tasks

Nodonisko mentioned this pull request Mar 25, 2025

[$250] Request money component is jumpy when entering the digits #19961

Open

6 tasks

mountiny assigned Nodonisko Mar 25, 2025

Nodonisko marked this pull request as draft March 26, 2025 12:06

Nodonisko force-pushed the fix/19961-input-numbers-flickers branch 7 times, most recently from b21efa7 to 834c1d6 Compare April 10, 2025 17:48

fix: iOS cursor flicker on first character

168e73f

Nodonisko force-pushed the fix/19961-input-numbers-flickers branch from 5e51ece to 168e73f Compare April 16, 2025 08:50

fix: apply correct full width styles to input

c346b65

hoangzinh reviewed Apr 16, 2025

View reviewed changes

fix platform check

2effe74

hoangzinh approved these changes Apr 19, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 19, 2025 08:17

mountiny approved these changes Apr 19, 2025

View reviewed changes

mountiny merged commit de57d65 into Expensify:main Apr 19, 2025
17 of 19 checks passed

github-actions bot mentioned this pull request Apr 21, 2025

Deploy Checklist: New Expensify 2025-04-21 #60596

Closed

31 tasks

This was referenced Apr 22, 2025

[Due for payment 2025-05-05] [Due for payment 2025-04-30] Status - Cursor is unable to reach before the first digit in Time using backspace button #60640

Closed

Revert "fix: autoGrow prop on mobile is handled by native platform" #60663

Closed

Nodonisko mentioned this pull request Apr 22, 2025

[CP Staging] fix: cursor is unable to reach before the first digit in Time using b… #60669

Merged

48 tasks

linhvovan29546 mentioned this pull request Apr 23, 2025

[$250] Android- BNP- Cursor in amount input field has different thickness before & after adding digit #60646

Closed

8 tasks

linhvovan29546 mentioned this pull request Apr 24, 2025

fix: android tax overlap suffix #60693

Merged

51 tasks

This was referenced Apr 24, 2025

Test Revert "fix: autoGrow prop on mobile is handled by native platform" #60788

Closed

iOS Hybrid-Invite member-Invitation message is cut off on the confirmation screen #60765

Closed

Nodonisko mentioned this pull request Apr 24, 2025

fix: autogrow heigh for TextInput #60842

Merged

48 tasks

shubham1206agra reviewed May 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: autoGrow prop on mobile is handled by native platform #59078

fix: autoGrow prop on mobile is handled by native platform #59078

Nodonisko commented Mar 25, 2025 •

edited

Loading

melvin-bot bot commented Mar 25, 2025

melvin-bot bot commented Mar 25, 2025

github-actions bot commented Mar 25, 2025 •

edited

Loading

hoangzinh commented Mar 25, 2025

Nodonisko commented Mar 25, 2025

hannojg commented Mar 25, 2025

hoangzinh commented Mar 25, 2025

Nodonisko commented Mar 25, 2025

mountiny commented Mar 25, 2025

github-actions bot commented Mar 25, 2025

mountiny commented Mar 25, 2025

github-actions bot commented Mar 25, 2025

hoangzinh commented Mar 26, 2025

hoangzinh commented Mar 26, 2025

Nodonisko commented Mar 26, 2025

Nodonisko commented Apr 16, 2025 •

edited

Loading

hoangzinh Apr 16, 2025

hoangzinh Apr 16, 2025

Nodonisko Apr 17, 2025 •

edited

Loading

hoangzinh Apr 17, 2025

mountiny commented Apr 16, 2025 •

edited

Loading

hoangzinh commented Apr 16, 2025

mountiny commented Apr 17, 2025

hoangzinh commented Apr 18, 2025

hoangzinh commented Apr 19, 2025 •

edited

Loading

mountiny left a comment

OSBotify commented Apr 19, 2025

github-actions bot commented Apr 21, 2025

github-actions bot commented Apr 23, 2025

aldo-expensify commented Apr 24, 2025

shubham1206agra May 5, 2025

	const isExternalAutoGrowMeasurement = Platform.OS !== 'ios' && autoGrow;
	const isExternalAutoGrowMeasurement = getPlatform() !== CONST.PLATFORM.IOS && autoGrow;

fix: autoGrow prop on mobile is handled by native platform #59078

fix: autoGrow prop on mobile is handled by native platform #59078

Conversation

Nodonisko commented Mar 25, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 25, 2025

melvin-bot bot commented Mar 25, 2025

github-actions bot commented Mar 25, 2025 • edited Loading

hoangzinh commented Mar 25, 2025

Nodonisko commented Mar 25, 2025

hannojg commented Mar 25, 2025

hoangzinh commented Mar 25, 2025

Nodonisko commented Mar 25, 2025

mountiny commented Mar 25, 2025

github-actions bot commented Mar 25, 2025

mountiny commented Mar 25, 2025

github-actions bot commented Mar 25, 2025

hoangzinh commented Mar 26, 2025

hoangzinh commented Mar 26, 2025

Nodonisko commented Mar 26, 2025

Nodonisko commented Apr 16, 2025 • edited Loading

hoangzinh Apr 16, 2025

Choose a reason for hiding this comment

hoangzinh Apr 16, 2025

Choose a reason for hiding this comment

Nodonisko Apr 17, 2025 • edited Loading

Choose a reason for hiding this comment

hoangzinh Apr 17, 2025

Choose a reason for hiding this comment

mountiny commented Apr 16, 2025 • edited Loading

hoangzinh commented Apr 16, 2025

mountiny commented Apr 17, 2025

hoangzinh commented Apr 18, 2025

hoangzinh commented Apr 19, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 19, 2025

github-actions bot commented Apr 21, 2025

github-actions bot commented Apr 23, 2025

aldo-expensify commented Apr 24, 2025

shubham1206agra May 5, 2025

Choose a reason for hiding this comment

Nodonisko commented Mar 25, 2025 •

edited

Loading

github-actions bot commented Mar 25, 2025 •

edited

Loading

Nodonisko commented Apr 16, 2025 •

edited

Loading

Nodonisko Apr 17, 2025 •

edited

Loading

mountiny commented Apr 16, 2025 •

edited

Loading

hoangzinh commented Apr 19, 2025 •

edited

Loading