[$250] Request money component is jumpy when entering the digits

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a DM
2. Tap + in the compose box > Request money
3. Enter the amount

Expected Result:

No jumpy behavior when entering the digits

Actual Result:

Request money component is jumpy

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-01.at.16.05.20.mov

Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C9YU7BX5M/p1685628667713269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0115f73500419bbdad
• Upwork Job ID: 1665685007250124800
• Last Price Increase: 2024-08-21

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hannojg]

Hey, I was bringing up that issue originally. It seems that not every device is able to reproduce the issue. However, I tested it with 5 different phones in our office, among it high end phones like the newest iPhones and the issue is reproducible on all of them 🤔 (so the issue is on android and iOS).
The thing is, its hard to see while using that there is a jumpiness, but I think you can definitely feel that its not smooth. That's why I did a screen recording and when you step through the recording frame by frame you will see states where the input is not adjusting its size fast enough (see attached video).

(In addition I'd like to work on that issue once QA can confirm its reproducible).

[hannojg]

Also on Web it's not jumping, but you can see, if you look very closely, that the number shows with one frame delay.

This is due to the fact that we first put the text inside a Text view, measure it, and then change the size of the input.

I think it makes sense to rework the autoGrow functionality, so it isn't delayed by a frame (and on mobile doesn't jump).

trim.7B871403-74B5-417A-834A-C5C089118E2D.MOV

[mountiny]

@hannojg Let us know what the next steps on this one would be

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0115f73500419bbdad

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[mountiny]

Not overdue

[hannojg]

We could put this on hold for #16696 until we settled on a decision there.

However, in the meantime, I am already experimenting with some solutions for a better implementation of the autoGrow behaviour. Will share more information once I find a good working solution 😊

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: autoGrow prop on mobile is handled by native platform #59078

If no regressions arise, payment will be issued on 2025-04-30. 🎊

For reference, here are some details about the assignees on this issue:

• @Nodonisko does not require payment (Contractor)
• @hoangzinh requires payment through NewDot Manual Requests
• @hannojg does not require payment (Contractor)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

@hoangzinh @zanyrenney @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Nodonisko is from an agency-contributor and not due payment
• Reviewer: @hoangzinh owed $250 via NewDot
• Contributor: @hannojg is from an agency-contributor and not due payment
• ROLE: @aimane-chnaif paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1665685007250124800/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[zanyrenney]

@aimane-chnaif i sent you a manual offer - here: https://www.upwork.com/nx/wm/offer/107121981

[hoangzinh]

@mountiny, we're still awaiting the upstream fix with RN (step 3 here). Thus, will we hold off payment here or go ahead here?

[zanyrenney]

bump @mountiny which should we do? Shall i go ahead with the payments or not yet?

[mountiny]

Lets hold off for now and make this monthly! @Nodonisko how is the upstream fix looking?

[Nodonisko]

@mountiny Currently focusing on freezing during search but I will get to this right after that is resolved