Skip to content

fix: android tax overlap suffix #60693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2025
Merged

fix: android tax overlap suffix #60693

merged 7 commits into from
May 19, 2025

Conversation

linhvovan29546
Copy link
Contributor

@linhvovan29546 linhvovan29546 commented Apr 23, 2025 •
edited
Loading

Explanation of Change

On Android native, the autoGrow feature enables the Input to automatically expand based on the entered text by allocating extra space to the right of the input. However, this functionality only worked correctly when a prefix (a symbol displayed on the left side of the input) was present. When a suffix (a symbol displayed on the right side) was used instead, the autoGrow behavior failed, causing layout issues.

In this PR, we've updated the Input component to support autoGrow in cases where a suffix is present. This ensures that the Input expand correctly whether a prefix or suffix

Fixed Issues

$ #59607
PROPOSAL: #59607 (comment)

Tests

  1. Launch the app.
  2. Navigate to Workspace Settings > More Features > Enable Taxes.
  3. Tap on Taxes.
  4. Tap the Value input field.
  5. Enter a random digit.
  6. Verify that:

  • The entered digit does not overlap with the percentage symbol.

  • The tax value is not cut off while typing.

  • Verify that no errors appear in the JS console

Offline tests

Same as test above

QA Steps

Same as test above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
after.mov
Android: mWeb Chrome
Screen.Recording.2025-04-23.at.10.18.00.mov
iOS: Native
Screen.Recording.2025-04-23.at.10.10.52.mov
iOS: mWeb Safari
Screen.Recording.2025-04-23.at.10.16.42.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-23.at.10.19.11.mov
MacOS: Desktop
Screen.Recording.2025-04-23.at.10.21.37.mov

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 23, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@linhvovan29546 linhvovan29546 marked this pull request as ready for review April 23, 2025 04:23
@linhvovan29546 linhvovan29546 requested review from a team as code owners April 23, 2025 04:23
@melvin-bot melvin-bot bot requested review from hungvu193 and removed request for a team April 23, 2025 04:23
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 23, 2025

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@linhvovan29546
Copy link
Contributor Author

Hi @Expensify/design team! This PR updates the Input component on Android Native and also changes the textAlign property from 'left' to 'right' across all platforms. Could you please help review this update? For more context, feel free to check the Explanation of Change above and the OP

autoGrow

Before After
before.mov
after.mov

textAlign

Before After
Screen.Recording.2025-04-23.at.11.19.42.mov
Screen.Recording.2025-04-23.at.11.20.28.mov

@dubielzyk-expensify
Copy link
Contributor

The after doesn't have the weird left side cutoff issue, but it feels a bit delayed in how it enters the digit. Is there a way to smoothen that out a bit?

@linhvovan29546
Copy link
Contributor Author

Hmm, this only changes the UI, and I didn’t notice delay before or after. I recorded the screen in debug mode, so that might be the reason.

@linhvovan29546 linhvovan29546 changed the title Fix/59607 android tax overlap suffix fix: android tax overlap suffix Apr 23, 2025
@shawnborton
Copy link
Contributor

Hmm yeah, something about the after feels a lot less smooth than the before?

@hungvu193
Copy link
Contributor

The fact that he ran the app on an emulator so you can see it's a bit laggy than before. The changes in this PR only affect the UI. I suggest that we should trigger a build.

@linhvovan29546 linhvovan29546 changed the title fix: android tax overlap suffix [HOLD #60842] fix: android tax overlap suffix Apr 25, 2025
@linhvovan29546 linhvovan29546 changed the title [HOLD #60842] fix: android tax overlap suffix fix: android tax overlap suffix May 13, 2025
@hungvu193
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android.mov
Android: mWeb Chrome
mChrome.mov
iOS: HybridApp
IOS.mov
iOS: mWeb Safari
mSafari.mov
MacOS: Chrome / Safari
Chrome.mov
MacOS: Desktop
Desk.mov

@melvin-bot melvin-bot bot requested a review from dangrous May 13, 2025 06:25
aldo-expensify
aldo-expensify approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving to @dangrous for a final review

@linhvovan29546
Copy link
Contributor Author

linhvovan29546 commented May 16, 2025 •
edited
Loading

@hungvu193 The PR Author Checklist failed after I merged main. Do you know what might have caused this?
Resolved

@hungvu193
Copy link
Contributor

Pinged @danieldoglas via Slack

dangrous
dangrous approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dangrous dangrous merged commit d70a5ec into Expensify:main May 19, 2025
16 of 17 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label May 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (1/3)

⚠️ Some tests did not pass successfully, so some results are omitted from final report: Open search router TTI, Linking, Money request

Significant Changes To Duration

Name Duration
App start time contentAppeared_To_screenTTI 1218.617 ms → 936.255 ms (-282.362 ms, -23.2%) 🟢
App start time TTI 1887.513 ms → 1593.255 ms (-294.258 ms, -15.6%) 🟢
Chat opening Chat TTI 791.501 ms → 892.804 ms (+101.304 ms, +12.8%) 🔴
Show details
Name Duration
App start time contentAppeared_To_screenTTI Baseline
Mean: 1218.617 ms
Stdev: 60.192 ms (4.9%)
Runs: 1047.5586299998686 1065.3711870000698 1097.2448060000315 1098.5354380002245 1121.785742000211 1124.918827000074 1128.6752599999309 1133.6407900000922 1172.521222999785 1172.648273000028 1174.1204019999132 1174.7259370000102 1177.0016490002163 1180.7690389999188 1183.468663000036 1186.8723439997993 1199.6335109998472 1200.0458650002256 1205.5550190000795 1209.5712359999306 1209.9974279999733 1211.4095490002073 1212.5577110000886 1212.5838199998252 1228.0685390001163 1230.394512000028 1231.908476000186 1241.2533100000583 1243.154908000026 1244.7650580001064 1244.8961849999614 1246.5245869997889 1252.0056460001506 1252.3454959997907 1255.3748639998958 1255.98307200009 1256.305747000035 1261.2334839999676 1261.514101000037 1263.137461999897 1263.4138020002283 1265.7884249999188 1266.896972999908 1267.3848819998093 1268.0541269998066 1270.9950290000997 1271.7317630001344 1274.0678869998083 1274.6730519998819 1275.1341200000606 1278.7971390001476 1281.3252679998986 1289.4212020002306 1291.553125999868 1314.6318649998866

Current
Mean: 936.255 ms
Stdev: 273.299 ms (29.2%)
Runs: 512.0851750001311 521.3306479998864 527.9561580000445 529.5895179999061 544.1485779997893 579.7597790001892 582.1635179999284 584.6936730002053 586.2165580000728 600.0688680000603 603.9011220000684 604.8937070001848 619.0309009999037 622.4651660001837 626.2692610002123 628.6285060001537 635.1920280000195 637.8975760000758 648.0209389999509 656.9750120001845 667.4387900000438 692.8249769997783 695.865633000154 713.0997460000217 1024.2437829999253 1066.4245939999819 1073.5977810001932 1082.2283490002155 1083.5812940001488 1089.918382000178 1093.401697000023 1096.790076999925 1099.0421959999949 1114.9870179998688 1120.4505630000494 1122.5250809998251 1122.8504360001534 1132.393190999981 1139.8272910001688 1143.5109520000406 1150.5317620001733 1151.4241309999488 1153.087181000039 1153.2669770000502 1157.4531560000032 1159.197040999774 1162.4587790002115 1170.7347450000234 1176.8861910002306 1182.1907410002314 1210.808691999875 1211.3554170001298 1212.4452789998613 1213.270554000046 1219.15793999983 1238.5147649999708 1241.2390239997767 1243.2852909998037 1254.566637000069 1287.1577070001513
App start time TTI Baseline
Mean: 1887.513 ms
Stdev: 85.926 ms (4.6%)
Runs: 1676.3711870000698 1676.5586299998686 1693.6752599999309 1698.785742000211 1715.5354380002245 1741.1204019999132 1748.6407900000922 1750.918827000074 1817.521222999785 1826.648273000028 1839.0016490002163 1842.7690389999188 1848.468663000036 1856.6335109998472 1862.7259370000102 1868.4095490002073 1874.9974279999733 1881.5712359999306 1886.8723439997993 1888.394512000028 1892.0685390001163 1895.908476000186 1898.154908000026 1898.3848819998093 1904.98307200009 1905.2533100000583 1909.7884249999188 1912.7650580001064 1915.5550190000795 1916.5577110000886 1918.3454959997907 1918.8961849999614 1919.7317630001344 1922.4138020002283 1927.5245869997889 1929.305747000035 1931.1341200000606 1932.514101000037 1936.4212020002306 1938.7971390001476 1940.0541269998066 1942.0056460001506 1944.3252679998986 1945.9950290000997 1953.137461999897 1963.2334839999676 1963.6730519998819 1967.553125999868 1971.896972999908 1976.0458650002256 1987.3748639998958 1991.0678869998083 2028.5838199998252 2030.6318649998866

Current
Mean: 1593.255 ms
Stdev: 282.766 ms (17.7%)
Runs: 1054.1485779997893 1134.0851750001311 1160.3306479998864 1163.2165580000728 1182.9561580000445 1214.0309009999037 1224.1920280000195 1232.6936730002053 1253.2692610002123 1261.589517999906 1272.0209389999509 1274.4387900000438 1274.6285060001537 1278.0688680000603 1283.1635179999284 1287.7597790001892 1297.0997460000217 1301.8937070001848 1322.8975760000758 1334.9750120001845 1342.9011220000684 1361.4651660001837 1377.865633000154 1379.8249769997783 1590.2437829999253 1604.2283490002155 1631.5977810001932 1694.5109520000406 1705.9870179998688 1728.4531560000032 1759.8504360001534 1783.790076999925 1805.4241309999488 1806.918382000178 1808.1907410002314 1811.4245939999819 1813.5250809998251 1814.401697000023 1826.4452789998613 1826.5812940001488 1828.8861910002306 1833.270554000046 1836.0421959999949 1839.15793999983 1839.2669770000502 1842.2852909998037 1842.8272910001688 1844.4505630000494 1844.808691999875 1847.393190999981 1848.087181000039 1853.3554170001298 1870.2390239997767 1886.4587790002115 1891.5317620001733 1893.197040999774 1893.566637000069 1917.7347450000234 1923.1577070001513 1938.5147649999708
Chat opening Chat TTI Baseline
Mean: 791.501 ms
Stdev: 65.178 ms (8.2%)
Runs: 680.4639889998361 683.3829349996522 687.6298830006272 687.6344809997827 693.4486079998314 693.6284590000287 700.3958329996094 700.5900880005211 703.5716960001737 716.1055100001395 724.7505700001493 739.3656820002943 741.1863200003281 741.4396160002798 744.0145669998601 746.7766930004582 748.9323330000043 751.1162930000573 761.3419999992475 762.8073320006952 764.9638269999996 766.7870689993724 766.9228520002216 781.0645759999752 786.4823409998789 793.6788739999756 799.2545979991555 807.582112999633 810.7624930003658 820.3958339998499 822.2595620006323 832.1035569999367 838.1102710003033 840.2539069997147 842.7178139993921 844.8035479998216 845.0175780002028 848.4841719996184 854.469034999609 854.7484539998695 855.1717940000817 855.8044840004295 856.0031739994884 857.7806409997866 859.3068850003183 861.59790099971 872.034668000415 872.790974999778 873.6540529998019 882.6775320004672 885.4670820003375 896.3007819997147

Current
Mean: 892.804 ms
Stdev: 195.353 ms (21.9%)
Runs: 567.380737000145 681.8046880001202 682.453288000077 688.0857750000432 689.0991620002314 689.8736580004916 689.9825440002605 691.4984539998695 695.8975419998169 737.0136719997972 737.9147140001878 747.0245770001784 748.2484539998695 756.063558999449 757.1976330000907 757.6395260002464 758.0906980000436 763.8926189998165 766.1589770000428 771.728394000791 778.5703130001202 779.9131680000573 789.8158780001104 789.8301599994302 790.7395020006225 797.1657309997827 806.3158370004967 812.1593429995701 816.3255209997296 823.0175379998982 823.7265229998156 835.7666019992903 835.9462080001831 838.1637369999662 839.8657639995217 846.8105060001835 849.9453940000385 850.6191010000184 859.3387449998409 862.658853999339 867.9401860004291 870.5688889995217 872.4762369999662 1055.8454589992762 1062.8269859999418 1103.7061769999564 1143.3902589995414 1159.812336999923 1175.4226080002263 1177.4062090003863 1187.5268559996039 1207.5028489995748 1212.6652029994875 1214.401002000086 1220.162924000062 1226.3865569997579 1230.043782999739 1243.656413000077 1254.5925700003281 1278.1909999996424

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (2/3)

Meaningless Changes To Duration (1/2)

Show entries
Name Duration
App start time nativeLaunch 27.167 ms → 35.583 ms (+8.417 ms, +31.0%) 🟡
App start time nativeLaunchEnd_To_appCreationStart 83.322 ms → 67.667 ms (-15.655 ms, -18.8%) 🟢
App start time runJsBundle 342.683 ms → 320.983 ms (-21.700 ms, -6.3%)
App start time appCreationEnd_To_contentAppeared 474.589 ms → 487.550 ms (+12.961 ms, +2.7%)
App start time appCreation 73.600 ms → 64.789 ms (-8.811 ms, -12.0%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, -0.8%)
App start time (CPU) 153.695 % → 149.435 % (-4.261 %, -2.8%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 365.894 MB → 355.908 MB (-9.987 MB, -2.7%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.600 % → 28.395 % (+0.795 %, +2.9%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 384.059 ms → 385.547 ms (+1.488 ms, ±0.0%)
Report typing (CPU) 98.334 % → 100.127 % (+1.793 %, +1.8%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 443.712 MB → 443.389 MB (-0.323 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 22.138 % → 21.865 % (-0.273 %, -1.2%)
Chat opening (CPU) 163.493 % → 162.523 % (-0.970 %, -0.6%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 380.005 MB → 382.216 MB (+2.210 MB, +0.6%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 32.556 % → 32.802 % (+0.246 %, +0.8%)
Show details
Name Duration
App start time nativeLaunch Baseline
Mean: 27.167 ms
Stdev: 4.095 ms (15.1%)
Runs: 21 21 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 25 25 25 25 25 26 26 26 26 26 26 26 27 27 28 28 28 28 28 28 29 29 29 29 30 30 30 31 31 31 31 32 32 32 33 34 34 34 35 35 38

Current
Mean: 35.583 ms
Stdev: 4.627 ms (13.0%)
Runs: 27 28 29 29 30 30 30 30 31 31 31 31 31 32 32 32 32 32 32 33 33 33 34 34 34 34 34 34 35 35 35 35 36 36 36 37 37 37 37 37 38 38 38 39 39 39 39 39 40 40 41 41 42 42 42 43 43 43 44 49
App start time nativeLaunchEnd_To_appCreationStart Baseline
Mean: 83.322 ms
Stdev: 11.725 ms (14.1%)
Runs: 60 66 66 66 69 70 71 71 71 72 72 73 73 75 75 75 76 76 76 76 77 77 78 79 79 79 80 80 81 81 83 83 83 85 85 85 85 86 87 88 88 88 89 90 90 93 94 94 96 98 98 99 99 100 100 101 103 106 120

Current
Mean: 67.667 ms
Stdev: 10.540 ms (15.6%)
Runs: 51 52 52 53 54 55 55 56 57 57 58 58 58 58 59 59 59 60 60 60 61 62 62 63 63 63 64 65 65 67 68 68 68 69 69 69 70 71 72 72 72 74 74 74 74 75 75 76 77 77 78 79 80 83 84 85 88 90 90 93
App start time runJsBundle Baseline
Mean: 342.683 ms
Stdev: 23.896 ms (7.0%)
Runs: 293 293 294 294 296 296 300 300 304 304 306 306 307 307 309 309 312 312 313 313 321 321 322 322 322 322 323 323 324 324 329 329 329 329 331 331 331 331 332 332 334 334 335 335 336 336 337 337 341 341 341 341 342 342 344 344 345 345 345 345 346 346 347 347 349 349 349 349 352 352 352 352 353 353 354 354 355 355 355 355 356 356 356 356 357 357 359 359 360 360 360 360 361 361 363 363 366 366 366 366 366 366 367 367 367 367 367 367 369 369 372 372 377 377 377 377 389 389 396 396

Current
Mean: 320.983 ms
Stdev: 24.182 ms (7.5%)
Runs: 261 261 272 272 279 279 282 282 284 284 294 294 296 296 296 296 296 296 297 297 299 299 301 301 302 302 303 303 303 303 304 304 308 308 308 308 309 309 310 310 310 310 313 313 313 313 314 314 314 314 316 316 317 317 317 317 319 319 319 319 320 320 320 320 320 320 321 321 321 321 325 325 326 326 326 326 326 326 328 328 333 333 333 333 337 337 337 337 340 340 340 340 341 341 341 341 343 343 346 346 350 350 350 350 351 351 352 352 354 354 357 357 357 357 361 361 365 365 382 382
App start time appCreationEnd_To_contentAppeared Baseline
Mean: 474.589 ms
Stdev: 30.748 ms (6.5%)
Runs: 403 404 412 415 427 427 429 441 443 445 446 446 453 459 459 460 465 465 467 467 471 472 474 474 475 476 476 477 478 479 480 482 483 484 485 485 485 488 488 490 493 493 494 496 497 499 503 504 508 513 518 521 521 524 528 530

Current
Mean: 487.550 ms
Stdev: 56.405 ms (11.6%)
Runs: 361 374 407 410 411 411 411 413 421 426 426 432 435 439 439 445 446 451 459 459 459 461 463 464 469 469 471 475 477 479 484 486 500 508 511 513 514 519 519 523 523 523 526 527 530 535 538 542 543 546 550 553 559 560 567 574 577 579 580 581
App start time appCreation Baseline
Mean: 73.600 ms
Stdev: 8.722 ms (11.9%)
Runs: 58 58 61 62 62 64 65 65 65 65 66 66 66 67 67 67 68 68 68 68 68 69 70 70 71 71 71 71 71 72 72 72 72 73 74 74 75 75 76 76 77 77 78 78 79 79 80 81 81 82 84 84 85 87 88 88 90 90 94 95

Current
Mean: 64.789 ms
Stdev: 8.175 ms (12.6%)
Runs: 52 52 52 53 53 53 54 56 56 57 57 57 57 58 58 58 59 60 60 61 61 61 62 62 63 63 63 64 64 65 65 67 67 67 67 68 68 69 69 69 70 70 70 71 71 71 71 72 74 74 74 74 75 78 79 86 86
App start time regularAppStart Baseline
Mean: 0.021 ms
Stdev: 0.002 ms (8.8%)
Runs: 0.017456000205129385 0.017700000200420618 0.0179449999704957 0.018106999807059765 0.018798999954015017 0.01904299994930625 0.019246000330895185 0.019368000328540802 0.019531000405550003 0.0195720000192523 0.019613000098615885 0.019733999855816364 0.01977499993517995 0.019816000014543533 0.01985599985346198 0.019897000398486853 0.020223000086843967 0.020263999700546265 0.020427000243216753 0.020508000161498785 0.020548000000417233 0.020671000238507986 0.020711000077426434 0.020711000077426434 0.020711999852210283 0.020791999995708466 0.020792999770492315 0.020874000154435635 0.020914999768137932 0.02119999984279275 0.02128099976107478 0.021403000224381685 0.021443999838083982 0.021687999833375216 0.021809999831020832 0.021932000294327736 0.021972999908030033 0.022013999987393618 0.022216000128537416 0.02254300005733967 0.022582999896258116 0.022582999896258116 0.022867999970912933 0.022867999970912933 0.02327399980276823 0.023314999882131815 0.023397000040858984 0.0235190000385046 0.02372199995443225 0.023723000194877386 0.02388500003144145 0.023966999724507332 0.02404800010845065 0.024170000106096268 0.02469900017604232 0.025471999775618315

Current
Mean: 0.021 ms
Stdev: 0.002 ms (9.6%)
Runs: 0.01733399974182248 0.017577999737113714 0.017862999811768532 0.01822900027036667 0.018269999884068966 0.018635999877005816 0.018920000176876783 0.018920999951660633 0.019084000028669834 0.019286999944597483 0.019328000023961067 0.019612000323832035 0.019612999632954597 0.01977499993517995 0.020060000009834766 0.02010100008919835 0.020223000086843967 0.020223000086843967 0.020262999925762415 0.020344999618828297 0.020344999618828297 0.020345999859273434 0.020427000243216753 0.0204670000821352 0.020508000161498785 0.02054900024086237 0.020589000079780817 0.020589000079780817 0.0206300001591444 0.020955000072717667 0.020955999847501516 0.0209969999268651 0.02111799968406558 0.02124100038781762 0.021321000065654516 0.021606999915093184 0.02164700021967292 0.02164700021967292 0.021850000135600567 0.022013000212609768 0.022013999987393618 0.0220940001308918 0.022298000287264585 0.022338999900966883 0.022500999737530947 0.02254199981689453 0.02307100035250187 0.023275000043213367 0.023560000117868185 0.023804000113159418 0.023804000113159418 0.024210999719798565 0.025024999864399433 0.025349999777972698 0.02612300030887127 0.026529999915510416
App start time (CPU) Baseline
Mean: 153.695 %
Stdev: 8.493 % (5.5%)
Runs: 137.7776107980345 139.1973226728845 139.2795964394607 141.70444178691977 142.2924901185771 142.58534723381928 143.27844383110718 143.41050313597015 143.95266272189343 143.98985277083298 145.82459705536618 145.858045904027 146.01741979948451 146.1064481823496 146.772862770148 147.22821024617423 148.28134440289833 148.33735262729874 148.8020166004418 149.23728165242898 149.31042543244516 149.4086242911262 149.8903384793796 151.08789603418867 151.37137971690032 151.394422310757 151.47939415287067 151.87314355996043 151.9254415381176 152.64023595900923 152.64446883831778 152.68401623634057 153.02240099220123 154.13311270279684 154.18471005027754 155.08390482629835 155.31383385769658 155.58175468227296 156.86235762838507 156.9680965296724 157.4817826314474 158.27129885317322 159.46763787055156 159.96315749772708 160.23089768365648 160.3868638245401 161.05001641759188 161.20252229723437 161.3482833835072 165.06117353128545 165.16734884349194 165.25960154139787 165.69923075416673 165.7999287690617 166.21390703398654 166.2717354136349 167.28373965216076 168.70425815036603 168.91924974561672 171.1500739083543

Current
Mean: 149.435 %
Stdev: 7.741 % (5.2%)
Runs: 134.59843172255518 137.77377501153606 139.19760123157104 139.3524734203924 140.28189009977473 140.29047647391988 140.43882473942594 140.70728317344046 140.94727635361343 142.01308085314272 142.52507292893372 142.75670196918202 143.07948479161206 143.15080630870105 143.62434521338628 143.81479836801407 143.9390101728955 144.36027588302244 144.7492539571434 145.01611648284955 145.0848263632098 145.1666347931409 145.40758423668458 145.73085955299038 146.60002894243456 147.00085306148142 147.50083290477562 147.8150365934797 148.31392146061233 148.69396713661433 149.1614991614991 149.18677496492163 149.21954484605092 149.2717846471178 149.59042418084834 150.02377833910253 151.05102717031147 152.41046831955924 152.9035599737036 153.19886232698568 153.5085642118558 153.61278111779114 153.80062191329793 154.01813633520948 154.3133389972844 155.4558273654858 156.90145230700452 156.93030112832625 157.05343170131903 157.31683168316835 160.48939351947647 160.73306772908364 161.75415949512342 162.89291529598202 164.5095182626907 165.47791919364488 165.79431262803044 166.6964889260011
App start time (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
App start time (RAM) Baseline
Mean: 365.894 MB
Stdev: 5.367 MB (1.5%)
Runs: 355.2005208333333 355.4505208333333 355.5703125 356.94140625 357.0091145833333 357.5234375 358.43359375 358.9283854166667 359.4166666666667 359.4752604166667 359.68359375 362.0130208333333 362.0846354166667 362.107421875 362.18359375 362.23046875 363.0595703125 363.1471354166667 363.3720703125 363.408203125 364.6650390625 365.1943359375 365.3020833333333 365.6145833333333 365.626953125 366.2682291666667 366.2955729166667 366.33984375 366.3684895833333 366.4892578125 366.7486979166667 366.8072916666667 366.8372395833333 367.0377604166667 367.37109375 367.9052734375 368.087890625 368.17578125 368.2705078125 368.3776041666667 368.38671875 368.6484375 368.6692708333333 368.91796875 369.0419921875 369.1953125 370.357421875 370.77734375 370.96484375 371.1041666666667 371.3583984375 372.65625 373.3515625 373.9443359375 374.5559895833333 374.935546875 375.6614583333333 378.3268229166667

Current
Mean: 355.908 MB
Stdev: 8.620 MB (2.4%)
Runs: 337.173828125 339.205078125 339.25390625 342.80859375 343.138671875 343.33203125 345.1588541666667 345.1875 345.6484375 345.88671875 345.890625 346.22265625 348.80859375 348.8854166666667 349.046875 349.8619791666667 349.955078125 350.56640625 351.02734375 352.1640625 352.7825520833333 353.87109375 353.880859375 354.8450520833333 355.5078125 355.888671875 356.21484375 356.2864583333333 356.3841145833333 356.576171875 356.66015625 357.3072916666667 357.375 357.59375 357.67578125 358.0299479166667 358.0963541666667 358.6106770833333 358.6940104166667 358.8697916666667 358.9583333333333 359.3671875 360.4557291666667 360.5403645833333 361.265625 362.17578125 363.5325520833333 363.8203125 364.421875 364.4283854166667 364.7591145833333 366.5052083333333 366.6796875 366.7412109375 367.271484375 368.4661458333333 368.5611979166667 369.689453125 369.93359375 376.5052083333333
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 27.600 %
Stdev: 1.862 % (6.7%)
Runs: 23.4 24 24.6 25 25.2 25.3 25.3 25.4 25.4 25.4 25.8 25.9 26 26.6 26.7 26.7 26.7 26.7 26.8 27.1 27.1 27.1 27.1 27.2 27.2 27.2 27.2 27.3 27.4 27.4 27.5 27.6 27.6 27.8 27.9 28 28.1 28.4 28.5 28.5 28.6 28.8 28.9 28.9 28.9 29 29 29.4 29.8 29.9 30 30.2 30.4 30.5 30.9 31.9 32

Current
Mean: 28.395 %
Stdev: 2.923 % (10.3%)
Runs: 22.8 23.7 24 24 24.6 25.2 25.3 25.3 25.4 25.4 25.4 25.9 25.9 26 26 26 26.6 26.6 26.7 26.7 27 27.2 27.3 27.3 27.4 27.4 27.4 27.8 27.9 27.9 28 28 28.1 28.4 28.7 28.9 29 29.1 29.3 29.3 29.3 29.4 29.6 30 30 30.1 30.6 30.9 31.1 31.3 32 32 32.3 32.4 32.5 32.9 33 33.3 36 36.1

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (3/3)

Meaningless Changes To Duration (2/2)

Show entries
Name Duration
App start time nativeLaunch 27.167 ms → 35.583 ms (+8.417 ms, +31.0%) 🟡
App start time nativeLaunchEnd_To_appCreationStart 83.322 ms → 67.667 ms (-15.655 ms, -18.8%) 🟢
App start time runJsBundle 342.683 ms → 320.983 ms (-21.700 ms, -6.3%)
App start time appCreationEnd_To_contentAppeared 474.589 ms → 487.550 ms (+12.961 ms, +2.7%)
App start time appCreation 73.600 ms → 64.789 ms (-8.811 ms, -12.0%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, -0.8%)
App start time (CPU) 153.695 % → 149.435 % (-4.261 %, -2.8%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 365.894 MB → 355.908 MB (-9.987 MB, -2.7%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.600 % → 28.395 % (+0.795 %, +2.9%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 384.059 ms → 385.547 ms (+1.488 ms, ±0.0%)
Report typing (CPU) 98.334 % → 100.127 % (+1.793 %, +1.8%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 443.712 MB → 443.389 MB (-0.323 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 22.138 % → 21.865 % (-0.273 %, -1.2%)
Chat opening (CPU) 163.493 % → 162.523 % (-0.970 %, -0.6%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 380.005 MB → 382.216 MB (+2.210 MB, +0.6%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 32.556 % → 32.802 % (+0.246 %, +0.8%)
Show details
Name Duration
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Report typing Message sent Baseline
Mean: 384.059 ms
Stdev: 54.716 ms (14.2%)
Runs: 289.62870300002396 294.6109619997442 299.09948800038546 300.484659999609 302.1000570002943 304.16743999999017 306.6958820000291 309.5660810000263 309.6490890001878 311.8607169999741 312.2583010001108 313.0229900004342 317.6949060000479 318.5303549999371 320.5328780002892 321.57857300015166 323.48331800010055 329.55131000000983 329.78869599988684 332.78576700016856 336.94462099997327 352.1332600004971 396.9280190002173 401.4490559999831 403.5297849997878 403.77058999985456 403.86352599970996 405.63216200005263 406.78344700019807 409.55733199976385 409.6819260008633 411.70817099977285 411.8449299996719 412.48661299981177 413.8861489999108 414.2277830000967 416.7953690001741 418.27319399965927 418.5397950001061 420.31835900014266 421.7636719997972 421.7906910004094 423.3942470001057 423.681315000169 426.45833399984986 426.8964029997587 427.0363360000774 429.275391000323 430.05025199986994 430.8465170003474 434.0332029997371 438.7204590002075 439.0634359996766 440.7277429997921 441.4931640001014 446.60652699973434 447.365559999831 454.23860699962825 454.5932620000094 470.0489500002004

Current
Mean: 385.547 ms
Stdev: 56.614 ms (14.7%)
Runs: 301.127563000191 301.2851159996353 304.47212699986994 305.38175400020555 306.4594320002943 308.384766000323 308.5300289997831 308.847779000178 311.2653000000864 313.21578000020236 315.51322500035167 318.4380300003104 320.9681400000118 322.2107750000432 324.42366500012577 328.94917799998075 329.19226099923253 329.3364260001108 331.4224450001493 332.6261390000582 332.6854249993339 332.7016599997878 334.89900799980387 354.60542799998075 391.7557780002244 392.71260600024834 400.9525549998507 401.62011800007895 402.23421300016344 406.90035000024363 408.43672699993476 410.8835050002672 411.94193500000983 414.159831000492 414.75992800015956 417.31856300029904 417.35347500024363 418.27522799931467 423.1472169999033 424.0522460001521 429.8555509997532 430.8099360000342 431.72379599977285 432.77221700083464 433.26224800013006 435.7050379998982 437.422038000077 438.4411220001057 439.73120199982077 440.6431479998864 445.15844799997285 446.3199869999662 447.2129319999367 450.0314529999159 450.6808270001784 451.8339439993724 452.73815900087357 458.52738499920815 467.5148520004004 478.9734709998593
Report typing (CPU) Baseline
Mean: 98.334 %
Stdev: 5.959 % (6.1%)
Runs: 85.40479572699576 86.03125239225368 90.42511803272124 90.47814387802833 91.22758027225099 91.6635121044276 91.90779518095567 92.13328120872438 93.11973527915555 93.18928231735076 93.49709422382799 93.80120397858344 93.80844675902401 93.84388880109624 93.91204294428182 94.27373253682514 94.52335904688427 95.01067903889609 95.01222787498443 95.31537262772386 95.46412851556208 95.6835479272364 96.64165483702828 96.86708851338356 96.89144795428203 97.04141850953988 97.72625566721945 97.8313408254087 98.04316091265387 98.42752389931897 98.46616032878254 98.65226577613163 98.84639804989816 99.05671448338983 99.15310186953602 99.17698776092702 99.56588801154729 99.58650487884589 99.59631998348098 99.82875954566269 99.87346585568818 100.12220385779209 100.99773175977579 101.45569727367081 101.58431691263345 101.97207163219994 102.08060603654363 105.9218406938298 106.1579037633112 106.55733740002493 107.63823951832369 108.11145829404028 108.14270640581417 109.34924764939693 110.58700806607375 111.43471606489123 111.91508436454347

Current
Mean: 100.127 %
Stdev: 8.256 % (8.2%)
Runs: 85.46781804912096 86.5122717928627 86.66785570914101 88.6361796186398 89.93163107726797 90.39694643559918 90.68698906642908 91.19634422748095 91.39047382454312 92.33698387844746 92.40269997529407 92.52781433013931 92.82179122028725 93.09296051194431 93.57335841249186 93.89538023328356 93.93477321346127 94.58187557738742 95.48836759733616 95.99476883752179 95.99555059270166 96.25322233568671 96.40555466752129 96.88181828622297 97.50201814220601 97.53786464559734 98.61716387598318 98.72373586599957 99.2471227419243 99.33666907992057 100.11627675716487 100.16863244627928 100.5524867671026 100.70959139533772 100.71337490814439 100.85160175999589 101.72485790197003 102.39671016211356 102.60178594435715 102.71584435610227 102.9996899876841 104.90152201714916 105.60120015190184 107.2694985724405 107.44777445241144 107.59059378488557 108.2689892038666 108.66054515819766 109.44046156818362 109.66613096289117 110.49642816467458 110.95919720755214 111.05004709169879 114.88161465298803 115.36564811822318 116.59848445314378 117.00487849354967 118.54779876788598
Report typing (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Report typing (RAM) Baseline
Mean: 443.712 MB
Stdev: 7.637 MB (1.7%)
Runs: 426.5933388157895 427.4088541666667 428.04405381944446 429.0106907894737 429.42310855263156 430.18270596590907 434.1064453125 434.6428865131579 435.0433799342105 435.6748046875 436.1328125 436.2423828125 437.084765625 438.2884457236842 438.78173828125 438.9537417763158 440.275390625 440.5123046875 440.6193359375 440.81924715909093 441.0435855263158 442.9829358552632 443.5894325657895 443.7591796875 443.9380208333333 444.29385653409093 444.357421875 444.744140625 444.89897017045456 445.19460227272725 445.717578125 445.8474786931818 446.36141304347825 446.427734375 446.433203125 446.65767045454544 447.2611019736842 447.31373355263156 447.5861328125 447.74441964285717 448.3384765625 448.443359375 449.3916015625 449.6552220394737 449.9765625 450.36026278409093 451.03426846590907 451.08664772727275 451.3346354166667 451.61860795454544 452.1578125 452.24857954545456 452.3460582386364 452.36186079545456 452.704296875 452.75337357954544 456.20703125 459.2917668269231

Current
Mean: 443.389 MB
Stdev: 8.462 MB (1.9%)
Runs: 426.28989955357144 427.63939144736844 427.9224609375 429.3643092105263 429.56321022727275 430.02006392045456 431.9833984375 432.8363486842105 434.6319633152174 436.0822265625 436.0826480263158 436.1529017857143 437.0333806818182 437.2593005952381 437.35609375 437.4609375 437.904296875 439.2767578125 439.583984375 439.64144736842104 440.85044642857144 440.88856907894734 441.02468039772725 441.47585227272725 441.8146306818182 442.1128700657895 442.2739955357143 442.7875 443.3939453125 443.6125 443.6168323863636 444.1646484375 444.9535361842105 445.38032670454544 448.1599609375 448.3958984375 448.7578125 449.28926809210526 449.824609375 450.25532670454544 450.4156605113636 450.484765625 451.0447443181818 451.045703125 451.1713169642857 451.20578835227275 451.3580078125 451.93661221590907 452.00639204545456 452.71856398809524 453.4124644886364 454.63939144736844 455.8984375 455.92598684210526 456.7501953125 462.64577414772725
Report typing (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Report typing (CPU/UI) Baseline
Mean: 22.138 %
Stdev: 0.845 % (3.8%)
Runs: 20.2 20.5 20.7 20.7 20.7 21 21.1 21.1 21.2 21.3 21.4 21.5 21.6 21.7 21.7 21.7 21.8 21.8 21.9 21.9 21.9 22 22 22 22.1 22.1 22.1 22.1 22.1 22.1 22.2 22.2 22.2 22.3 22.3 22.4 22.5 22.5 22.6 22.6 22.7 22.7 22.7 22.8 22.8 23 23.1 23.3 23.4 23.4 23.5 23.5 23.6 23.6 23.7

Current
Mean: 21.865 %
Stdev: 0.982 % (4.5%)
Runs: 19.7 20.1 20.2 20.4 20.4 20.4 20.5 20.7 20.8 20.9 20.9 20.9 21.1 21.1 21.2 21.3 21.4 21.5 21.5 21.6 21.6 21.6 21.8 21.8 21.8 21.9 22 22 22 22 22.1 22.1 22.1 22.1 22.1 22.2 22.3 22.3 22.4 22.4 22.4 22.5 22.6 22.7 22.7 22.8 22.8 22.8 22.8 22.8 23.1 23.3 23.8 24 24.3
Chat opening (CPU) Baseline
Mean: 163.493 %
Stdev: 5.501 % (3.4%)
Runs: 153.0878822381739 153.23605682099335 154.09591976340076 154.24162056897376 155.27594831810745 156.30449885054472 156.818083355202 157.510219171616 157.72896629674378 158.1961669296877 158.5968008043366 158.61982749494828 158.64448927932867 159.15847005724444 159.2641511145185 159.3423486026713 159.52394759625446 159.65984482472672 159.6904099811183 160.7216077833774 160.9551857549999 160.99940314439831 161.19235532803347 161.37835790315933 161.44425842020394 161.75059491473684 162.20738305292377 162.3090496801725 163.61156403692098 163.7025286446757 163.7761438264766 163.8440333085388 164.05573952917607 164.11622121209965 164.18400900039566 164.7819588228765 164.9765397588391 165.00800711139354 165.26669890300127 165.40049276635455 165.5161364809486 165.92580210751044 166.21279113899237 166.6494023904383 166.67742679180068 167.15979330811464 168.07628403723663 168.73824086564375 168.74626843473723 169.8938721181195 170.3241594718847 170.65933897052815 170.69093769222104 171.13744501172434 171.71133302344734 171.75609189565023 171.83000991673995 172.81582679571278 174.69829923973683 175.673194834574

Current
Mean: 162.523 %
Stdev: 5.553 % (3.4%)
Runs: 149.9783858896392 151.32046890841286 152.1553808160572 153.52042007580306 154.43984759872492 155.0884068469505 155.4477186015877 156.98616443317647 157.0084809925738 157.30773692699017 157.35249192113156 157.6659326753702 158.11618250935044 158.26443621206542 158.34770719036266 158.59761845990505 158.91650579790846 158.9196625073632 159.40915687640668 159.72057837281835 159.86689753848825 160.7636099704179 160.8465770271102 161.03723792759098 161.1650039369244 161.41358462075206 161.71044677564043 161.87679320441796 161.89939793760445 162.17746110288357 162.65016339832695 162.74507105851873 163.25938945371746 163.43605714215522 164.0494038898153 164.06845034946807 164.50384498555638 164.572201205312 164.5833945146316 164.8522274538211 165.19623690358281 165.76946277818377 166.1868698431655 166.20601368828568 166.54339821902144 166.9376946088206 167.55456921140782 167.73950604603402 167.93931345848458 168.7039967565712 168.9102468136145 169.85082758306714 170.67559292343026 170.9236484033823 171.17529880478082 171.20973206963328 171.37911943195013 171.78164455372965 174.10909730026253
Chat opening (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Chat opening (RAM) Baseline
Mean: 380.005 MB
Stdev: 6.095 MB (1.6%)
Runs: 369.5234375 370.46484375 371.4359375 371.51796875 371.84296875 372.14140625 372.22421875 372.310546875 373.85390625 374.5283203125 374.8890625 375.123046875 375.724609375 375.765625 375.8583984375 375.9515625 376.19765625 376.95390625 377.10078125 377.51015625 377.515625 377.76015625 377.99296875 378.034375 378.11875 378.4677734375 378.51796875 378.66640625 378.9440104166667 378.9947916666667 379.1529947916667 379.275390625 379.55546875 379.63671875 379.66796875 380.0146484375 380.6265625 381.45 381.541015625 382.1390625 382.88203125 382.925 383.0234375 383.16796875 384.16796875 384.48671875 384.923828125 385.4228515625 385.990625 387.03828125 387.68046875 388.0963541666667 388.1223958333333 388.203125 392.86640625 393.7421875 394.56640625 396.0026041666667

Current
Mean: 382.216 MB
Stdev: 7.576 MB (2.0%)
Runs: 366.9248046875 368.66875 369.34765625 370.1943359375 372.47265625 372.62890625 373.24765625 373.3619791666667 374.0576171875 374.353515625 374.909375 375.63515625 375.6640625 375.93359375 376.1671875 376.85703125 377.07890625 377.5546875 378.09765625 378.16484375 378.2115885416667 378.859375 379.04296875 379.553125 379.63671875 379.658203125 379.971875 380.34375 380.9248046875 381.0514322916667 381.46875 381.845703125 382.8899739583333 383.7565104166667 383.8404947916667 384.01796875 384.296875 384.818359375 384.85 384.87265625 385.75390625 385.83671875 386.0390625 386.61328125 386.67890625 387.3157552083333 387.78359375 388.123046875 389.32890625 390.4680989583333 391.8247767857143 392.4799107142857 393.0325520833333 393.04129464285717 393.234375 393.333984375 395.146484375 396.3671875 396.81863839285717 398.48125
Chat opening (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Chat opening (CPU/UI) Baseline
Mean: 32.556 %
Stdev: 2.011 % (6.2%)
Runs: 28.2 28.3 29 29.1 29.6 30 30.3 30.3 30.6 30.6 30.7 30.8 31 31.2 31.2 31.2 31.3 31.4 31.6 31.8 31.8 31.8 31.9 32 32.2 32.3 32.4 32.4 32.4 32.5 32.5 32.7 32.7 32.9 32.9 33 33.3 33.3 33.5 33.5 33.6 33.6 33.8 33.8 33.8 33.9 33.9 33.9 34.3 34.4 34.5 34.7 34.8 35.4 35.4 35.5 36.6 37.1 37.6

Current
Mean: 32.802 %
Stdev: 1.989 % (6.1%)
Runs: 28.2 28.9 29 29.8 29.9 30.3 30.4 30.4 31.1 31.1 31.2 31.2 31.2 31.4 31.4 31.7 31.7 31.7 31.8 31.9 31.9 32 32.1 32.3 32.3 32.4 32.5 32.6 32.7 32.8 33 33.1 33.1 33.2 33.2 33.3 33.4 33.4 33.5 33.5 33.8 34.2 34.2 34.2 34.3 34.4 34.6 34.8 34.8 34.9 35 35.1 35.3 35.3 35.9 35.9 37.3 37.9

@github-actions GitHub Actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@github-actions github-actions bot mentioned this pull request May 20, 2025
Open
88 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.47-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@linhvovan29546 linhvovan29546 deleted the fix/59607-android-tax-overlap-suffix branch May 21, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangrous dangrous dangrous approved these changes

@hungvu193 hungvu193 hungvu193 approved these changes

@aldo-expensify aldo-expensify aldo-expensify approved these changes

Assignees
No one assigned
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@linhvovan29546 @dubielzyk-expensify @shawnborton @hungvu193 @OSBotify @dangrous @aldo-expensify