Skip to content

[CP Staging] Revert "fix: always render the skeleton when fetching report actions" #58821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

[CP Staging] Revert "fix: always render the skeleton when fetching report actions" #58821

merged 1 commit into from
Mar 20, 2025

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Mar 20, 2025

@iwiznia iwiznia requested a review from mountiny March 20, 2025 17:15
@iwiznia iwiznia self-assigned this Mar 20, 2025
@iwiznia iwiznia requested a review from a team as a code owner March 20, 2025 17:15
@melvin-bot melvin-bot bot removed the request for review from a team March 20, 2025 17:15
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 20, 2025

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "fix: always render the skeleton when fetching report actions" [CP Staging] Revert "fix: always render the skeleton when fetching report actions" Mar 20, 2025
mountiny
mountiny approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 4055a51 into main Mar 20, 2025
14 of 17 checks passed
@mountiny mountiny deleted the revert-58654-fix/single-expense-reports-opening branch March 20, 2025 17:16
@melvin-bot melvin-bot bot added the Emergency label Mar 20, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 20, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Mar 20, 2025
@mountiny @OSBotify
Merge pull request #58821 from Expensify/revert-58654-fix/single-expe…
aedf35d 
…nse-reports-opening

[CP Staging] Revert "fix: always render the skeleton when fetching report actions"

(cherry picked from commit 4055a51)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 20, 2025
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Closed
72 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.16-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@marcochavezf marcochavezf mentioned this pull request Mar 20, 2025
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

Assignees

@iwiznia iwiznia

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @mountiny @OSBotify