fix: always render the skeleton when fetching report actions #58654

adhorodyski · 2025-03-18T16:04:39Z

Explanation of Change

This PR fixes rendering single expense reports by forcing the UI to stay on the skeleton for as long as the API command takes.

Fixed Issues

$ #58388
PROPOSAL: #58388 (comment)

Tests

The below guide shows how to reproducibly open up single expense reports. If you know other paths to do so, you can try them as well. The goal is to only render the final UI based on the API response (transaction missing locally), without an intermediary step of rendering offline-available data (that lacks the MoneyRequestView on the header).

Log into the EApp on 2 separate accounts (X and Y)
Create a chat between X and Y and open it on both machines (just to make sure it's there for everyone)
With X, go to the Reports screen, then Expense Reports
With Y, create a new expense for X
X should receive this expense in the Expense Reports view, navigate to it
You should see the loading skeleton for as long as it's needed (waiting for the API response), then the single expense report view. The UI should not jump in any jarring way.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…e mode

melvin-bot · 2025-03-18T16:09:32Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

adhorodyski · 2025-03-18T16:17:39Z

src/pages/home/report/ReportActionsView.tsx

@@ -347,7 +347,7 @@ function ReportActionsView({
        };
    }, [isTheFirstReportActionIsLinked]);

-    if (isLoadingInitialReportActions && visibleReportActions.length === 0 && !isOffline) {


This change effectively removes the more eager rendering pattern that showed us offline-available content immediately.

mountiny · 2025-03-18T21:03:12Z

@adhorodyski can you please make sure to fill out the PR body thoroughly? In this case its not clear what has to be tested and what the C+ should test for

adhorodyski · 2025-03-19T09:58:04Z

Updated the reproduction steps, with these we were able to see the before/after 100% of the time. Let me know if I can be of any more help.

ZhenjaHorbach · 2025-03-19T11:40:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2025-03-19T12:05:48Z

Changes work good
LGTM !

mountiny

Thanks! let's not CP this in the end as regression testing is actually quite far so do not want to cause any issues in production

OSBotify · 2025-03-19T12:15:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-20T15:37:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-03-21T11:05:30Z

@adhorodyski Found issue #58842

ZhenjaHorbach · 2025-03-21T11:10:54Z

@izarutskaya
This PR was reverted 😅
Could you retest an issue ?

github-actions · 2025-03-21T22:21:53Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.16-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: always render the skeleton when fetching report actions in onlin…

bd66068

…e mode

adhorodyski mentioned this pull request Mar 18, 2025

[Due for payment 2025-03-28] [$250] One expense report view is incorrectly rendered with delay #58388

Closed

8 tasks

adhorodyski marked this pull request as ready for review March 18, 2025 16:09

adhorodyski requested a review from a team as a code owner March 18, 2025 16:09

melvin-bot bot requested review from thesahindia and removed request for a team March 18, 2025 16:09

adhorodyski commented Mar 18, 2025

View reviewed changes

mountiny assigned adhorodyski Mar 19, 2025

mountiny requested review from ZhenjaHorbach and removed request for thesahindia March 19, 2025 11:39

mountiny changed the title ~~fix: always render the skeleton when fetching report actions~~ [CP Staging] fix: always render the skeleton when fetching report actions Mar 19, 2025

ZhenjaHorbach approved these changes Mar 19, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 19, 2025 12:05

mountiny changed the title ~~[CP Staging] fix: always render the skeleton when fetching report actions~~ fix: always render the skeleton when fetching report actions Mar 19, 2025

mountiny approved these changes Mar 19, 2025

View reviewed changes

mountiny merged commit 72529cb into Expensify:main Mar 19, 2025
22 of 26 checks passed

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 19, 2025

github-actions bot mentioned this pull request Mar 19, 2025

[Due for payment 2025-04-10] Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #58715

Closed

bernhardoj mentioned this pull request Mar 20, 2025

[$250] Unread line not showing properly #58771

Closed

github-actions bot mentioned this pull request Mar 20, 2025

Deploy Checklist: New Expensify 2025-03-20 #58801

Closed

72 tasks

iwiznia mentioned this pull request Mar 20, 2025

Change MarkAsUnread to pass reportActionID instead of time #58758

Merged

48 tasks

nkdengineer mentioned this pull request Mar 20, 2025

[$250] Report - Report view shows skeleton during each visit #58805

Closed

8 tasks

iwiznia mentioned this pull request Mar 20, 2025

[CP Staging] Revert "fix: always render the skeleton when fetching report actions" #58821

Merged

jponikarchuk mentioned this pull request Mar 20, 2025

Web - Skeleton loader isn't visible when opening the expense from Expense Reports #58842

Closed

8 tasks

mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Mar 24, 2025

ZhenjaHorbach mentioned this pull request Mar 28, 2025

Revert immediately showing report actions #59291

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: always render the skeleton when fetching report actions #58654

fix: always render the skeleton when fetching report actions #58654

Uh oh!

adhorodyski commented Mar 18, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 18, 2025

Uh oh!

adhorodyski Mar 18, 2025

Uh oh!

mountiny commented Mar 18, 2025

Uh oh!

adhorodyski commented Mar 19, 2025

Uh oh!

ZhenjaHorbach commented Mar 19, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Mar 19, 2025 •

edited

Loading

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

izarutskaya commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Uh oh!

fix: always render the skeleton when fetching report actions #58654

fix: always render the skeleton when fetching report actions #58654

Uh oh!

Conversation

adhorodyski commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 18, 2025

Uh oh!

adhorodyski Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny commented Mar 18, 2025

Uh oh!

adhorodyski commented Mar 19, 2025

Uh oh!

ZhenjaHorbach commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

izarutskaya commented Mar 21, 2025

Uh oh!

ZhenjaHorbach commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

Uh oh!

adhorodyski commented Mar 18, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 19, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 19, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 21, 2025 •

edited

Loading