[$250] Report - Report view shows skeleton during each visit

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any report
3. Go to another report
4. Switch back and forth between reports

Expected Result:

If the report is opened previously, it should not show skeleton after the subsequent visits

Actual Result:

When the report is opened previously, it stll shows skeleton after the subsequent visits

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6777006_1742484711621.20250320_232332.mp4

This issue happens when submitting expense and closing receipt view
https://github.com/user-attachments/assets/b56056b0-e5ab-4919-9f58-30528c541ffb

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902762585241549475
• Upwork Job ID: 1902762585241549475
• Last Price Increase: 2025-03-20

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021902762585241549475

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the report is opened previously, it stll shows skeleton after the subsequent visits

What is the root cause of that problem?

This comes from #58654.

We always show the skeleton view when the OpenReport API is called.

App/src/pages/home/report/ReportActionsView.tsx

Lines 273 to 275 in 1814bf4

	if (isLoadingInitialReportActions && !isOffline) {
	return <ReportActionsSkeletonView />;
	}

What changes do you think we should make in order to solve the problem?

We need to undo this change.

App/src/pages/home/report/ReportActionsView.tsx

Lines 273 to 275 in 1814bf4

	if (isLoadingInitialReportActions && !isOffline) {
	return <ReportActionsSkeletonView />;
	}

For this bug #58388, it's currently a backend bug. After we request money, the backend returns reportID of transaction thread report as number then this function returns early until OpenReport API of the expense report is complete. If we want to a hot fix we can update this to

if (!transactionThreadReportID || isSentMoneyReport) { 
     return reportActions; 
 }

App/src/libs/ReportActionsUtils.ts

Lines 457 to 459 in 1814bf4

	if (isEmpty(transactionThreadReportID) || isSentMoneyReport) {
	return reportActions;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lanitochka17]

This issue happens when submitting expense and closing receipt view

20250321_004746.mp4

[marcochavezf]

#58805 (comment) cc @adhorodyski @mountiny @ZhenjaHorbach

[marcochavezf]

This was already reverted, tested on staging and the bug is gone.