Skip to content

[CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" #58518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

yuwenmemon
Copy link
Contributor

Reverts #57641

@yuwenmemon yuwenmemon self-assigned this Mar 14, 2025
@yuwenmemon yuwenmemon requested a review from a team as a code owner March 14, 2025 17:42
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team March 14, 2025 17:42
Copy link

melvin-bot bot commented Mar 14, 2025

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" [CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" Mar 14, 2025
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 3eca10a into main Mar 14, 2025
13 of 17 checks passed
@mountiny mountiny deleted the revert-57641-QBOAutoSync branch March 14, 2025 18:12
@melvin-bot melvin-bot bot added the Emergency label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Mar 14, 2025
[CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online"

(cherry picked from commit 3eca10a)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 14, 2025
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.13-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@chrispader
Copy link
Contributor

chrispader commented Mar 15, 2025

Hey is there a new PR for this already up? We worked on another PR to fix an issue with the offline indicator not sticking to the bottom.

Can we make sure that offlineIndicatorStyle={styles.mtAuto} is added to the ScreenWrapper component in the new PR?

<ScreenWrapper
includeSafeAreaPaddingBottom={false}
style={[styles.defaultModalContainer]}
testID={QuickbooksAutoSyncPage.displayName}
>

Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants