-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" #58518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight revert
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" (cherry picked from commit 3eca10a) (CP triggered by mountiny)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.13-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Hey is there a new PR for this already up? We worked on another PR to fix an issue with the offline indicator not sticking to the bottom. Can we make sure that App/src/pages/workspace/accounting/qbo/advanced/QuickbooksAutoSyncPage.tsx Lines 37 to 41 in 04b9304
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀
|
Reverts #57641