Skip to content

Commit 5761a04

Browse files
mountinyOSBotify
mountiny
authored and
OSBotify
committed
Merge pull request #58518 from Expensify/revert-57641-QBOAutoSync
[CP Staging] Revert "New Feature: "When to export" selector for auto-sync for Quickbooks Online" (cherry picked from commit 3eca10a) (CP triggered by mountiny)
1 parent ccc836a commit 5761a04

File tree

21 files changed

+82
-333
lines changed

21 files changed

+82
-333
lines changed

‎src/CONST.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1943,7 +1943,6 @@ const CONST = {
19431943
AUTO_CREATE_VENDOR: 'autoCreateVendor',
19441944
REIMBURSEMENT_ACCOUNT_ID: 'reimbursementAccountID',
19451945
COLLECTION_ACCOUNT_ID: 'collectionAccountID',
1946-
ACCOUNTING_METHOD: 'accountingMethod',
19471946
},
19481947

19491948
XERO_CONFIG: {

‎src/ROUTES.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,19 +1176,11 @@ const ROUTES = {
11761176
},
11771177
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNT_SELECTOR: {
11781178
route: 'settings/workspaces/:policyID/accounting/quickbooks-online/account-selector',
1179-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/accounting/quickbooks-online/account-selector` as const,
1179+
getRoute: (policyID: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/account-selector` as const,
11801180
},
11811181
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_INVOICE_ACCOUNT_SELECTOR: {
11821182
route: 'settings/workspaces/:policyID/accounting/quickbooks-online/invoice-account-selector',
1183-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/accounting/quickbooks-online/invoice-account-selector` as const,
1184-
},
1185-
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC: {
1186-
route: 'settings/workspaces/:policyID/connections/quickbooks-online/advanced/autosync',
1187-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/connections/quickbooks-online/advanced/autosync` as const,
1188-
},
1189-
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD: {
1190-
route: 'settings/workspaces/:policyID/connections/quickbooks-online/advanced/autosync/accounting-method',
1191-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/connections/quickbooks-online/advanced/autosync/accounting-method` as const,
1183+
getRoute: (policyID: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/invoice-account-selector` as const,
11921184
},
11931185
WORKSPACE_ACCOUNTING_CARD_RECONCILIATION: {
11941186
route: 'settings/workspaces/:policyID/accounting/:connection/card-reconciliation',
@@ -2091,11 +2083,11 @@ const ROUTES = {
20912083
},
20922084
POLICY_ACCOUNTING_NETSUITE_AUTO_SYNC: {
20932085
route: 'settings/workspaces/:policyID/connections/netsuite/advanced/autosync',
2094-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/connections/netsuite/advanced/autosync` as const,
2086+
getRoute: (policyID: string) => `settings/workspaces/${policyID}/connections/netsuite/advanced/autosync` as const,
20952087
},
20962088
POLICY_ACCOUNTING_NETSUITE_ACCOUNTING_METHOD: {
20972089
route: 'settings/workspaces/:policyID/connections/netsuite/advanced/autosync/accounting-method',
2098-
getRoute: (policyID: string | undefined) => `settings/workspaces/${policyID}/connections/netsuite/advanced/autosync/accounting-method` as const,
2090+
getRoute: (policyID: string) => `settings/workspaces/${policyID}/connections/netsuite/advanced/autosync/accounting-method` as const,
20992091
},
21002092
POLICY_ACCOUNTING_NSQS_SETUP: {
21012093
route: 'settings/workspaces/:policyID/accounting/nsqs/setup',

‎src/SCREENS.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,6 @@ const SCREENS = {
371371
QUICKBOOKS_ONLINE_CLASSES_DISPLAYED_AS: 'Policy_Accounting_Quickbooks_Online_Import_Classes_Displayed_As',
372372
QUICKBOOKS_ONLINE_CUSTOMERS_DISPLAYED_AS: 'Policy_Accounting_Quickbooks_Online_Import_Customers_Displayed_As',
373373
QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS: 'Policy_Accounting_Quickbooks_Online_Import_Locations_Displayed_As',
374-
QUICKBOOKS_ONLINE_AUTO_SYNC: 'Policy_Accounting_Quickbooks_Online_Auto_Sync',
375-
QUICKBOOKS_ONLINE_ACCOUNTING_METHOD: 'Policy_Accounting_Quickbooks_Online_Accounting_Method',
376374
QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Company_Card_Expense_Account_Select',
377375
QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_COMPANY_CARD_SELECT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Company_Card_Expense_Select',
378376
QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT: 'Workspace_Accounting_Quickbooks_Desktop_Export_Company_Card_Expense',

‎src/languages/en.ts

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2932,7 +2932,6 @@ const translations = {
29322932
locations: 'Locations',
29332933
customers: 'Customers/projects',
29342934
accountsDescription: 'Your QuickBooks Online chart of accounts will import into Expensify as categories.',
2935-
autoSyncDescription: 'Sync QuickBooks Online and Expensify automatically, every day. Export finalized report in realtime',
29362935
accountsSwitchTitle: 'Choose to import new accounts as enabled or disabled categories.',
29372936
accountsSwitchDescription: 'Enabled categories will be available for members to select when creating their expenses.',
29382937
classesDescription: 'Choose how to handle QuickBooks Online classes in Expensify.',
@@ -3267,6 +3266,18 @@ const translations = {
32673266
[CONST.NETSUITE_REPORTS_APPROVAL_LEVEL.REPORTS_APPROVED_BOTH]: 'Supervisor and accounting approved',
32683267
},
32693268
},
3269+
accountingMethods: {
3270+
label: 'When to Export',
3271+
description: 'Choose when to export the expenses:',
3272+
values: {
3273+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Accrual',
3274+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Cash',
3275+
},
3276+
alternateText: {
3277+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Out-of-pocket expenses will export when final approved',
3278+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Out-of-pocket expenses will export when paid',
3279+
},
3280+
},
32703281
exportVendorBillsTo: {
32713282
label: 'Vendor bill approval level',
32723283
description: 'Once a vendor bill is approved in Expensify and exported to NetSuite, you can set an additional level of approval in NetSuite prior to posting.',
@@ -3560,18 +3571,6 @@ const translations = {
35603571
}
35613572
},
35623573
},
3563-
accountingMethods: {
3564-
label: 'When to Export',
3565-
description: 'Choose when to export the expenses:',
3566-
values: {
3567-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Accrual',
3568-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Cash',
3569-
},
3570-
alternateText: {
3571-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Out-of-pocket expenses will export when final approved',
3572-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Out-of-pocket expenses will export when paid',
3573-
},
3574-
},
35753574
multiConnectionSelector: {
35763575
title: ({connectionName}: ConnectionNameParams) => `${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} setup`,
35773576
description: ({connectionName}: ConnectionNameParams) => `Select your ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} version to continue.`,

‎src/languages/es.ts

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2958,7 +2958,6 @@ const translations = {
29582958
locations: 'Lugares',
29592959
customers: 'Clientes/proyectos',
29602960
accountsDescription: 'Tu plan de cuentas de QuickBooks Online se importará a Expensify como categorías.',
2961-
autoSyncDescription: 'Sincroniza QuickBooks Online y Expensify automáticamente, todos los días. Exporta el informe finalizado en tiempo real',
29622961
accountsSwitchTitle: 'Elige importar cuentas nuevas como categorías activadas o desactivadas.',
29632962
accountsSwitchDescription: 'Las categorías activas estarán disponibles para ser escogidas cuando se crea un gasto.',
29642963
classesDescription: 'Elige cómo gestionar las clases de QuickBooks Online en Expensify.',
@@ -3305,6 +3304,18 @@ const translations = {
33053304
[CONST.NETSUITE_REPORTS_APPROVAL_LEVEL.REPORTS_APPROVED_BOTH]: 'Aprobado por supervisor y contabilidad',
33063305
},
33073306
},
3307+
accountingMethods: {
3308+
label: 'Cuándo Exportar',
3309+
description: 'Elige cuándo exportar los gastos:',
3310+
values: {
3311+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Devengo',
3312+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Efectivo',
3313+
},
3314+
alternateText: {
3315+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Los gastos por cuenta propia se exportarán cuando estén aprobados definitivamente',
3316+
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Los gastos por cuenta propia se exportarán cuando estén pagados',
3317+
},
3318+
},
33083319
exportVendorBillsTo: {
33093320
label: 'Nivel de aprobación de facturas de proveedores',
33103321
description:
@@ -3599,18 +3610,6 @@ const translations = {
35993610
}
36003611
},
36013612
},
3602-
accountingMethods: {
3603-
label: 'Cuándo Exportar',
3604-
description: 'Elige cuándo exportar los gastos:',
3605-
values: {
3606-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Devengo',
3607-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Efectivo',
3608-
},
3609-
alternateText: {
3610-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.ACCRUAL]: 'Los gastos por cuenta propia se exportarán cuando estén aprobados definitivamente',
3611-
[COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD.CASH]: 'Los gastos por cuenta propia se exportarán cuando estén pagados',
3612-
},
3613-
},
36143613
multiConnectionSelector: {
36153614
title: ({connectionName}: ConnectionNameParams) => `${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} configuración`,
36163615
description: ({connectionName}: ConnectionNameParams) => `Selecciona tu versión de ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} para continuar.`,

‎src/libs/API/parameters/UpdateQuickbooksOnlineAccountingMethodParams.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎src/libs/API/parameters/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export type {default as SyncPolicyToQuickbooksOnlineParams} from './SyncPolicyTo
2020
export type {default as SyncPolicyToXeroParams} from './SyncPolicyToXeroParams';
2121
export type {default as SyncPolicyToNetSuiteParams} from './SyncPolicyToNetSuiteParams';
2222
export type {default as UpdateNetSuiteAccountingMethodParams} from './UpdateNetSuiteAccountingMethodParams';
23-
export type {default as UpdateQuickbooksOnlineAccountingMethodParams} from './UpdateQuickbooksOnlineAccountingMethodParams';
2423
export type {default as SyncPolicyToQuickbooksDesktopParams} from './SyncPolicyToQuickbooksDesktopParams';
2524
export type {default as DeleteContactMethodParams} from './DeleteContactMethodParams';
2625
export type {default as DeletePaymentBankAccountParams} from './DeletePaymentBankAccountParams';

‎src/libs/API/types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ const WRITE_COMMANDS = {
268268
UPDATE_QUICKBOOKS_ONLINE_SYNC_PEOPLE: 'UpdateQuickbooksOnlineSyncPeople',
269269
UPDATE_QUICKBOOKS_ONLINE_REIMBURSEMENT_ACCOUNT_ID: 'UpdateQuickbooksOnlineReimbursementAccountID',
270270
UPDATE_QUICKBOOKS_ONLINE_EXPORT: 'UpdateQuickbooksOnlineExport',
271-
UPDATE_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD: 'UpdateQuickbooksOnlineAccountingMethod',
272271
UPDATE_QUICKBOOKS_DESKTOP_EXPORT_DATE: 'UpdateQuickbooksDesktopExportDate',
273272
UPDATE_MANY_POLICY_CONNECTION_CONFIGS: 'UpdateManyPolicyConnectionConfigurations',
274273
UPDATE_QUICKBOOKS_DESKTOP_NON_REIMBURSABLE_EXPENSES_EXPORT_DESTINATION: 'UpdateQuickbooksDesktopNonReimbursableExpensesExportDestination',
@@ -751,7 +750,6 @@ type WriteCommandParameters = {
751750
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_EXPORT_DATE]: Parameters.UpdateQuickbooksOnlineGenericTypeParams;
752751
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_NON_REIMBURSABLE_EXPENSES_ACCOUNT]: Parameters.UpdateQuickbooksOnlineGenericTypeParams;
753752
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_COLLECTION_ACCOUNT_ID]: Parameters.UpdateQuickbooksOnlineGenericTypeParams;
754-
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD]: Parameters.UpdateQuickbooksOnlineAccountingMethodParams;
755753
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_DESKTOP_EXPORT_DATE]: Parameters.UpdateQuickbooksDesktopGenericTypeParams;
756754
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_DESKTOP_MARK_CHECKS_TO_BE_PRINTED]: Parameters.UpdateQuickbooksDesktopGenericTypeParams;
757755
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_DESKTOP_AUTO_CREATE_VENDOR]: Parameters.UpdateQuickbooksDesktopGenericTypeParams;

‎src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,6 @@ const SettingsModalStackNavigator = createModalStackNavigator<SettingsNavigatorP
353353
require<ReactComponentModule>('@pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectPage').default,
354354
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_COMPANY_CARD_EXPENSE_ACCOUNT_COMPANY_CARD_SELECT]: () =>
355355
require<ReactComponentModule>('../../../../pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectCardPage').default,
356-
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_AUTO_SYNC]: () => require<ReactComponentModule>('../../../../pages/workspace/accounting/qbo/advanced/QuickbooksAutoSyncPage').default,
357-
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_ACCOUNTING_METHOD]: () =>
358-
require<ReactComponentModule>('../../../../pages/workspace/accounting/qbo/advanced/QuickbooksAccountingMethodPage').default,
359356
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_COMPANY_CARD_EXPENSE_ACCOUNT]: () =>
360357
require<ReactComponentModule>('../../../../pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage').default,
361358
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_EXPORT_PREFERRED_EXPORTER]: () =>

‎src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ const WORKSPACE_TO_RHP: Partial<Record<keyof WorkspaceSplitNavigatorParamList, s
5555
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_CLASSES_DISPLAYED_AS,
5656
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_CUSTOMERS_DISPLAYED_AS,
5757
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS,
58-
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_AUTO_SYNC,
59-
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_ACCOUNTING_METHOD,
6058
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT,
6159
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_COMPANY_CARD_SELECT,
6260
SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT,

‎src/libs/Navigation/linkingConfig/config.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -358,12 +358,6 @@ const config: LinkingOptions<RootNavigatorParamList>['config'] = {
358358
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS]: {
359359
path: ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS.route,
360360
},
361-
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_AUTO_SYNC]: {
362-
path: ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC.route,
363-
},
364-
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_ACCOUNTING_METHOD]: {
365-
path: ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ACCOUNTING_METHOD.route,
366-
},
367361
[SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT]: {
368362
path: ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_COMPANY_CARD_EXPENSE_ACCOUNT_SELECT.route,
369363
},

‎src/libs/actions/Policy/Policy.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -723,14 +723,10 @@ function clearSageIntacctErrorField(policyID: string | undefined, fieldName: str
723723
Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {intacct: {config: {errorFields: {[fieldName]: null}}}}});
724724
}
725725

726-
function clearNetSuiteAutoSyncErrorField(policyID: string | undefined) {
726+
function clearNetSuiteAutoSyncErrorField(policyID: string) {
727727
Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuite: {config: {errorFields: {autoSync: null}}}}});
728728
}
729729

730-
function clearQuickbooksOnlineAutoSyncErrorField(policyID: string | undefined) {
731-
Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {quickbooksOnline: {config: {errorFields: {autoSync: null}}}}});
732-
}
733-
734730
function clearNSQSErrorField(policyID: string, fieldName: string) {
735731
Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {connections: {netsuiteQuickStart: {config: {errorFields: {[fieldName]: null}}}}});
736732
}
@@ -5030,7 +5026,6 @@ export {
50305026
clearNetSuiteErrorField,
50315027
clearNetSuitePendingField,
50325028
clearNetSuiteAutoSyncErrorField,
5033-
clearQuickbooksOnlineAutoSyncErrorField,
50345029
removeNetSuiteCustomFieldByIndex,
50355030
clearWorkspaceReimbursementErrors,
50365031
setWorkspaceCurrencyDefault,

‎src/libs/actions/connections/NetSuiteCommands.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -766,10 +766,7 @@ function updateNetSuiteExportToNextOpenPeriod(policyID: string, value: boolean,
766766
API.write(WRITE_COMMANDS.UPDATE_NETSUITE_EXPORT_TO_NEXT_OPEN_PERIOD, parameters, onyxData);
767767
}
768768

769-
function updateNetSuiteAutoSync(policyID: string | undefined, value: boolean) {
770-
if (!policyID) {
771-
return;
772-
}
769+
function updateNetSuiteAutoSync(policyID: string, value: boolean) {
773770
const optimisticData: OnyxUpdate[] = [
774771
{
775772
onyxMethod: Onyx.METHOD.MERGE,
@@ -940,13 +937,10 @@ function updateNetSuiteExportReportsTo(
940937
}
941938

942939
function updateNetSuiteAccountingMethod(
943-
policyID: string | undefined,
940+
policyID: string,
944941
accountingMethod: ValueOf<typeof COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD>,
945942
oldAccountingMethod: ValueOf<typeof COMMON_CONST.INTEGRATIONS.ACCOUNTING_METHOD>,
946943
) {
947-
if (!policyID) {
948-
return;
949-
}
950944
const onyxData = updateNetSuiteOnyxData(policyID, CONST.NETSUITE_CONFIG.ACCOUNTING_METHOD, accountingMethod, oldAccountingMethod);
951945

952946
const parameters = {

0 commit comments

Comments
 (0)