Add new error message in selection pages #47091

cretadn22 · 2024-08-08T16:06:35Z

Details

Adding new error message in selection page

Fixed Issues

$ #46536
PROPOSAL: #46536 (comment)

Tests

QA Steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on FAB - New workspace
Enable "Accounting" in the "More features" page.
Navigate to "Accounting"
Connect to NetSuite and upgrade the workspace to Control when asked
Wait for the sync to finish
Navigate to Accounting - Import - Custom Segments/records
Click on the "Add custom segment/record" button
In the first step, Click on the "Next" button without making a selection
Verify that a new error message appear: "Please select an option above."
Start adding a custom segment until the "How should this custom segment be displayed in Expensify?" step
Click on the "Next" button without making a selection
Verify that a new error message appear: "Please select an option above."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-11.at.16.21.05.mov

Android: mWeb Chrome

Screen.Recording.2024-08-11.at.16.19.59.mov

iOS: Native

Screen.Recording.2024-08-11.at.16.19.15.mov

iOS: mWeb Safari

Screen.Recording.2024-08-11.at.16.16.26.mov

MacOS: Chrome / Safari

Screen50.mov

MacOS: Desktop

Screen.Recording.2024-08-11.at.16.25.07.mov

melvin-bot · 2024-08-08T16:06:41Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2024-08-08T16:15:10Z

I see another bug: The background highlight isn't updated when selecting an option (This bug also happen on the staging)

Screen46.mov

ikevin127 · 2024-08-08T17:52:11Z

ℹ️ Will review this on Saturday (PST) when I'll return to office.

@cretadn22 Regarding the highlight bug that you found, it should only be fixed here if it's an easy fix - otherwise we should report it and treat it separately, since it was already on staging 👍

cretadn22 · 2024-08-09T08:32:31Z

To resolve the above problem, we can pass shouldSingleExecuteRowSelect, shouldUpdateFocusedIndex params to SelectionList.

Screen47.mov

However, it fails during the initial selection, as the blue box appears around the selected item.

ikevin127 · 2024-08-10T21:00:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127 · 2024-08-10T22:52:09Z

@cretadn22 ✅ Completed the PR Reviewer Checklist, however I'm holding off on Approve until we figure out what we want to do with the other bug found here, for which I think we need design's help to select the best option moving forward.

What's the issue ?

Coming from #47091 (comment) (bug was mentioned first time by PR author), a partial fix mentioned in #47091 (comment) would be the way to go if we want to highlight the selected option.

Since we now unified both selection pages to use the Next button and have validation that requires selection:

See screenshots

Before	After

This means that both the above page selection and the How should this custom segment be displayed in Expensify? page should have the same validation error message and also the same UI behaviour:

See screenshot

2nd Page

This leaves us with two options:

Don't have selected option highlight for any of the selection pages (only have the green checkmark, no highlight).
Have selected option highlight for both selection pages (this means fixing the current staging issue).

From #47091 (comment):

However, it fails during the initial selection, as the blue box appears around the selected item.

Note: This option would require fixing the ^ initial selection highlight issue, have it working at all times.

cc @Expensify/design Please chime in here regarding which option we should go with.

cretadn22 · 2024-08-11T09:31:02Z

I will wait for the design team before continuing to the highlight bug.

dubielzyk-expensify · 2024-08-12T00:55:44Z

My take is that whenever the checkmark is present on these list, we should also have the highlight so I think option 2 is the right move. Keen to hear what @shawnborton and @dannymcclain thinks though

shawnborton · 2024-08-12T11:09:38Z

Yup, definitely agree with that - if it has a checkmark, it should have a BG. Is there a way to fix this globally? I feel like we keep seeing this one pop up across various places.

cretadn22 · 2024-08-12T11:20:58Z

Thanks for confirmation, I will give an update soon

dannymcclain · 2024-08-12T13:38:44Z

100% agree with Shawn and Jon. And I'd be absolutely thrilled if we could figure out a way to fix this globally.

cretadn22 · 2024-08-13T15:53:14Z

src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx

@@ -118,6 +118,7 @@ function WorkspaceEditCardLimitTypePage({route}: WorkspaceEditCardLimitTypePageP
                    onSelectRow={({value}) => setTypeSelected(value)}
                    sections={[{data}]}
                    shouldUpdateFocusedIndex
+                    shouldSingleExecuteRowSelect


I noticed this bug also occurs on this page, the root cause and solution are similar to our issue. Therefore, I will address it here as well.

cretadn22 · 2024-08-13T15:54:51Z

src/components/SelectionList/BaseSelectionList.tsx

+        if (
+            (prevTextInputValue === textInputValue && flattenedSections.selectedOptions.length === prevSelectedOptionsLength) ||
+            flattenedSections.allOptions.length === 0 ||
+            shouldUpdateFocusedIndex


If shouldUpdateFocusedIndex is true, we should avoid resetting the focus index to -1 when the length of the selected options changes.

cretadn22 · 2024-08-13T15:58:26Z

@ikevin127 I've resolved the highlight issue. Could you please review it again?

Screen56.mp4

ikevin127

Thanks for fixing the highlight issue!
LGTM, tests well 🟢

highlight.mov

blimpich

LGTM

OSBotify · 2024-08-14T01:02:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-15T18:19:03Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T16:00:07Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:24:31Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add new error message ihn selection page

61bb348

cretadn22 requested a review from a team as a code owner August 8, 2024 16:06

melvin-bot bot requested review from ikevin127 and removed request for a team August 8, 2024 16:06

adjust spanish text

315c9cb

cretadn22 added 2 commits August 13, 2024 20:58

update the latest main

a71ed0a

resolve the highlight bug

48a3dae

cretadn22 commented Aug 13, 2024

View reviewed changes

ikevin127 approved these changes Aug 13, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich August 13, 2024 20:02

blimpich approved these changes Aug 14, 2024

View reviewed changes

blimpich merged commit f2dad3a into Expensify:main Aug 14, 2024
18 checks passed

github-actions bot mentioned this pull request Aug 15, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

izarutskaya mentioned this pull request Aug 16, 2024

[$250] NetSuite - Inconclusive use of spaces before and after a backslash #47550

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new error message in selection pages #47091

Add new error message in selection pages #47091

cretadn22 commented Aug 8, 2024 •

edited

Loading

melvin-bot bot commented Aug 8, 2024

cretadn22 commented Aug 8, 2024

ikevin127 commented Aug 8, 2024

cretadn22 commented Aug 9, 2024

ikevin127 commented Aug 10, 2024 •

edited

Loading

ikevin127 commented Aug 10, 2024

cretadn22 commented Aug 11, 2024

dubielzyk-expensify commented Aug 12, 2024

shawnborton commented Aug 12, 2024

cretadn22 commented Aug 12, 2024

dannymcclain commented Aug 12, 2024

cretadn22 Aug 13, 2024

blimpich Aug 14, 2024

cretadn22 Aug 13, 2024

cretadn22 commented Aug 13, 2024

ikevin127 left a comment

blimpich left a comment

OSBotify commented Aug 14, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

Add new error message in selection pages #47091

Add new error message in selection pages #47091

Conversation

cretadn22 commented Aug 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 8, 2024

cretadn22 commented Aug 8, 2024

ikevin127 commented Aug 8, 2024

cretadn22 commented Aug 9, 2024

ikevin127 commented Aug 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ikevin127 commented Aug 10, 2024

What's the issue ?

cretadn22 commented Aug 11, 2024

dubielzyk-expensify commented Aug 12, 2024

shawnborton commented Aug 12, 2024

cretadn22 commented Aug 12, 2024

dannymcclain commented Aug 12, 2024

cretadn22 Aug 13, 2024

Choose a reason for hiding this comment

blimpich Aug 14, 2024

Choose a reason for hiding this comment

cretadn22 Aug 13, 2024

Choose a reason for hiding this comment

cretadn22 commented Aug 13, 2024

ikevin127 left a comment

Choose a reason for hiding this comment

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 14, 2024

OSBotify commented Aug 15, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

cretadn22 commented Aug 8, 2024 •

edited

Loading

ikevin127 commented Aug 10, 2024 •

edited

Loading