-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add new error message in selection pages #47091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,6 +118,7 @@ function WorkspaceEditCardLimitTypePage({route}: WorkspaceEditCardLimitTypePageP | |
onSelectRow={({value}) => setTypeSelected(value)} | ||
sections={[{data}]} | ||
shouldUpdateFocusedIndex | ||
shouldSingleExecuteRowSelect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed this bug also occurs on this page, the root cause and solution are similar to our issue. Therefore, I will address it here as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you! |
||
isAlternateTextMultilineSupported | ||
initiallyFocusedOptionKey={typeSelected} | ||
/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If shouldUpdateFocusedIndex is true, we should avoid resetting the focus index to -1 when the length of the selected options changes.