-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the To
column
#47166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @greg-schroeder ( |
This was deployed to auth - @luacmartins will there be app or web PRs inc or is this done? |
https://github.com/Expensify/Auth/pull/11910 just mentioned this issue, it doesn't actually solve this. We still need to work on this issue. |
Having said that, I just put up an App PR to fix this |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Note: The above regression is a false alarm for this PR / issue since it's BE related, see context in #47551 (comment) and confirmation in #47551 (comment). |
To
columnTo
column
Job added to Upwork: https://www.upwork.com/jobs/~015225cf8b5cee59ec |
To
columnTo
column
Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new. |
Offer sent for $250 for reviewer role |
I'll pay you ASAP as soon as you accept! |
@greg-schroeder Offer accepted, thanks! |
Paid |
Uh oh!
There was an error while loading. Please reload this page.
After an internal discussion, we decided to make the
To
column in the Search table consistent with OldDot and show the individual approver of the report, instead of the workspace.Let's update the code to reflect this decision
cc @JmillsExpensify
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: