Skip to content

[$250] [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the To column #47166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luacmartins opened this issue Aug 9, 2024 · 13 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Aug 9, 2024

After an internal discussion, we decided to make the To column in the Search table consistent with OldDot and show the individual approver of the report, instead of the workspace.

Screenshot 2024-08-09 at 5 10 45 PM

Let's update the code to reflect this decision

cc @JmillsExpensify

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015225cf8b5cee59ec
  • Upwork Job ID: 1828282067221197045
  • Last Price Increase: 2024-08-27
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Aug 9, 2024
@luacmartins luacmartins self-assigned this Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 9, 2024
@greg-schroeder
Copy link
Contributor

This was deployed to auth - @luacmartins will there be app or web PRs inc or is this done?

@luacmartins
Copy link
Contributor Author

https://github.com/Expensify/Auth/pull/11910 just mentioned this issue, it doesn't actually solve this. We still need to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 14, 2024
@luacmartins
Copy link
Contributor Author

Having said that, I just put up an App PR to fix this

Copy link

melvin-bot bot commented Aug 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@ikevin127
Copy link
Contributor

ikevin127 commented Aug 20, 2024

Note: The above regression is a false alarm for this PR / issue since it's BE related, see context in #47551 (comment) and confirmation in #47551 (comment).

⚠️ Automation failed here -> this should be paid on 2024-08-26 according to yesterday’s production deploy from #47091 (comment).

cc @greg-schroeder

@greg-schroeder greg-schroeder added the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 20, 2024
@greg-schroeder greg-schroeder changed the title [Search v2.1] Update Search table to show approver instead of workspace in the To column [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the To column Aug 20, 2024
@ikevin127
Copy link
Contributor

cc @greg-schroeder

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Aug 27, 2024
@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015225cf8b5cee59ec

@melvin-bot melvin-bot bot changed the title [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the To column [$250] [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the To column Aug 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

@greg-schroeder greg-schroeder removed Help Wanted Apply this label when an issue is open to proposals by contributors Awaiting Payment Auto-added when associated PR is deployed to production labels Aug 27, 2024
@greg-schroeder
Copy link
Contributor

Offer sent for $250 for reviewer role

@greg-schroeder
Copy link
Contributor

I'll pay you ASAP as soon as you accept!

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in #expensify-bugs Aug 27, 2024
@ikevin127
Copy link
Contributor

@greg-schroeder Offer accepted, thanks!

@greg-schroeder
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Archived in project
Development

No branches or pull requests

3 participants