[Due for payment 2025-05-27] [$250] Settings-Required field error is not displayed when clearing the field

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56068
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: User Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any Expensify account
3. Go to Settings > Profile
4. Click on Status > Clear after > Custom > Date
5. Choose any date
6. Clear the field
7. Verify that the required field error is displayed
8. Go back
9. Click on Date again
10. Clear the field by clicking the X button twice without closing the date picker

Expected Result:

The required field error is displayed after clearing the field, even when the date picker is open.

Actual Result:

The required field error is not displayed when clearing the field without closing the date picker.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6802380_1744694724631.No_required_field_error.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917203087848355414
• Upwork Job ID: 1917203087848355414
• Last Price Increase: 2025-05-06
• Automatic offers:
• daledah | Contributor | 107210364

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 13:09:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The required field error is not displayed when clearing the field without closing the date picker.

What is the root cause of that problem?

Offending PR

This is a hidden bug that only appeared after the offending PR.

When validating error, we only keep the fields that is touched:

App/src/components/Form/FormProvider.tsx

Line 168 in 4ee6daa

const touchedInputErrors = Object.fromEntries(Object.entries(validateErrors).filter(([inputID]) => touchedInputs.current[inputID]));

But when dismissing the date picker, there's no onTouched call:

App/src/components/DatePicker/index.tsx

Lines 72 to 75 in 4ee6daa

	const closeDatePicker = useCallback(() => {
	textInputRef.current?.blur();
	setIsModalVisible(false);
	}, []);

And when clicking clear button, onTouched is called with delay:

App/src/components/Form/FormProvider.tsx

Lines 343 to 345 in 6d6628c

	setTimeout(() => {
	setTouchedInput(inputID);
	}, VALIDATE_DELAY);

While onValidate is called immediately when input change:

App/src/components/Form/FormProvider.tsx

Line 408 in 6d6628c

onValidate(newState);

So when calling onValidate there's no data for the input in the touchedInputs ref, resulting in errors returned empty and no error is shown.

What changes do you think we should make in order to solve the problem?

We should call onTouched when closing modal

App/src/components/DatePicker/index.tsx

Lines 72 to 75 in 6d6628c

	const closeDatePicker = useCallback(() => {
	textInputRef.current?.blur();
	setIsModalVisible(false);
	}, []);

    const closeDatePicker = useCallback(() => {
        textInputRef.current?.blur();
        setIsModalVisible(false);
        onTouched();
    }, [onTouched]);

OR we can add setTouchedInput before onValidate in onInputChange here:

App/src/components/Form/FormProvider.tsx

Lines 407 to 409 in 6d6628c

	if (shouldValidateOnChange) {
	onValidate(newState);
	}

Same as onBlur:

App/src/components/Form/FormProvider.tsx

Lines 385 to 389 in 6d6628c

	setTouchedInput(inputID);
	// We don't validate the form on blur in case the current screen is not focused
	if (shouldValidateOnBlur && isFocusedRef.current) {
	onValidate(inputValues, !hasServerError);
	}

To address this comment, remove shouldShowClearButton in these components:

App/src/pages/GroupChatNameEditPage.tsx

Line 104 in 758691e

shouldShowClearButton

App/src/pages/TripChatNameEditPage.tsx

Line 95 in 758691e

shouldShowClearButton

App/src/pages/Search/SavedSearchRenamePage.tsx

Line 75 in 758691e

shouldShowClearButton

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

This logic

App/src/components/Form/FormProvider.tsx

Lines 343 to 345 in 6d6628c

	setTimeout(() => {
	setTouchedInput(inputID);
	}, VALIDATE_DELAY);

was added in this PR to fix this bug. However, I tried removing the timeout and the bug is not reproduced anymore, so we can remove it.

App/src/components/Form/FormProvider.tsx

Lines 343 to 345 in 6d6628c

	setTimeout(() => {
	setTouchedInput(inputID);
	}, VALIDATE_DELAY);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

I can help raise a quick PR if needed.

[mollfpr]

Thanks @daledah for the proposal, but I think we will let the author fix the issue.

It's a pretty minor issue and shouldn't be a blocker. @perunt @shubham1206agra Please take a look when you have a chance.

[shubham1206agra]

@perunt I think we should not allow them to clear dates here maybe.

[lydiabarclay]

@mollfpr can I tag this as external if @shubham1206agra is going to be reviewing I assume?

[mollfpr]

@lydiabarclay I think it's not necessary. We will have @perunt and @shubham1206agra fix the issue.

[lydiabarclay]

Just checking @mollfpr - I'm assuming @shubham1206agra will still require payment as they are an external contributor - how do we determine the payment timeline manually?

[mollfpr]

@lydiabarclay The payment will be process here, since this a regression from the PR.

how do we determine the payment timeline manually?

Sorry, I didn't get what you meant 😅

[lydiabarclay]

Oh @mollfpr I see! Thank you for clarifying.

[daledah]

The bug is still reproducible

@s77rt What bug are you mentioning here? I tried removing timeout and both bugs in this issue and the mentioned issue is not reproducible

Screen.Recording.2025-05-05.at.22.09.33.mov

[s77rt]

@daledah The bug is related to the checkbox as it shifts down after the error message is displayed

Screen.Recording.2025-05-05.at.8.10.30.PM.mov

[daledah]

@s77rt It works fine on my side. Can you check again please?

Screen.Recording.2025-05-06.at.22.45.54.mov

Small note that I only remove the timeout in onTouched and leave everything else as-is.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

@daledah Ah okay. Yeah I think we can go with that.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Current assignee @mollfpr is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[mollfpr]

Agree with @s77rt! Assigning, thanks!

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[s77rt]

Not overdue. Working on the PR still

[mollfpr]

The PR is merged! Melvin failed to update the status here 😅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: required field error is not displayed when clearing the field #61653

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @lydiabarclay @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]