Saved Search - "x" ("clear") icon is missing in Rename Saved Search

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6117601
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.4 Crome, iPhone 15 iOS 18.4.1 Safari
App Component: Search

Action Performed:

1. Navigate to staging.new.expensify.com and sign in with gmail account
2. Create a workspace, if needed, and submit some expenses
3. Navigate to the Reports tab, click the "Filter" icon
4. Apply any filter and create a Saved search
5. Click 3 dot menu next to the Saved search, select "Rename"

Expected Result:

There is a "x" icon in the saved search name row to clear the long saved search title

Actual Result:

The "x" ("clear") icon is missing in the saved search name row in "Rename" RHP

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[marcaaron]

I don't think this is deploy blocker worthy.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Saved Search - "x" ("clear") icon is missing in Rename Saved Search

What is the root cause of that problem?

Missing prop shouldShowClearButton here

App/src/pages/Search/SavedSearchRenamePage.tsx

Line 66 in eecf578

<InputWrapper

What changes do you think we should make in order to solve the problem?

Pass the shouldShowClearButton prop here.

App/src/pages/Search/SavedSearchRenamePage.tsx

Line 66 in eecf578

<InputWrapper

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jaydamani]

Intentional change from #60243 (comment)