fix: required field error is not displayed when clearing the field #61653

daledah · 2025-05-08T06:38:04Z

Explanation of Change

Fixed Issues

$ #60243
PROPOSAL: #60243 (comment)

Tests

Log in with any Expensify account
Go to Settings > Profile
Click on Status > Clear after > Custom > Date
Choose any date
Clear the field
Go back
Click on Date again
Clear the field by clicking the X button twice without closing the date picker
Verify that: The required field error is displayed after clearing the field, even when the date picker is open.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with any Expensify account
Go to Settings > Profile
Click on Status > Clear after > Custom > Date
Choose any date
Clear the field
Go back
Click on Date again
Clear the field by clicking the X button twice without closing the date picker
Verify that: The required field error is displayed after clearing the field, even when the date picker is open.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-08.at.22.36.30.mov

Android: mWeb Chrome

Screen.Recording.2025-05-08.at.22.36.54.mov

iOS: Native

Screen.Recording.2025-05-08.at.22.37.28.mov

iOS: mWeb Safari

Screen.Recording.2025-05-08.at.22.37.54.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-08.at.22.38.13.mov

MacOS: Desktop

Screen.Recording.2025-05-08.at.22.38.38.mov

melvin-bot · 2025-05-08T06:38:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-05-09T02:18:09Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2025-05-09T16:05:48Z

@ahmedGaber93 Sorry for the ping, I linked the wrong issue in this PR. @s77rt Will review this PR.

src/pages/GroupChatNameEditPage.tsx

s77rt · 2025-05-09T17:59:58Z

src/pages/GroupChatNameEditPage.tsx

@@ -101,7 +101,6 @@ function GroupChatNameEditPage({report}: GroupChatNameEditPageProps) {
                    inputID={INPUT_IDS.NEW_CHAT_NAME}
                    role={CONST.ROLE.PRESENTATION}
                    ref={inputCallbackRef}
-                    shouldShowClearButton


I think we can keep the clear button here because an empty string is a valid option here

cc @trjExpensify

I don't think we want to keep the clear X icon here. We said only:

Search input fields (added here: Fix: add search bar to lists with items above 15 #60488).

DatePicker input field

This is neither, right? CC: @Expensify/design for vis

Yeah, I think we can probably get rid of it here based on our little framework. Curious what the other designers think though!

I could see it being helpful here in the case where we think it's likely that you would rename a group to something custom. But I am also fine following our framework for consistency's sake.

Makes sense to me

If you want the group name to take its default name you'd have to clear the input and submit an empty string. I think the clear button serves as an indication here that is an empty string is allowed.

Generally I would say that if an empty string is meaningful we should have a clear button.

If you want the group name to take its default name you'd have to clear the input and submit an empty string.

Personally I think this is pretty weird behavior and doesn't feel expected to me. It would make more sense to me if you could not save an empty string here.

s77rt · 2025-05-09T18:00:29Z

src/pages/Search/SavedSearchRenamePage.tsx

@@ -72,7 +72,6 @@ function SavedSearchRenamePage({route}: {route: {params: {q: string; name: strin
                    onChangeText={(renamedName) => setNewName(renamedName)}
                    ref={inputCallbackRef}
                    defaultValue={name}
-                    shouldShowClearButton


I think we still need this as it's coming from #50163

cc @trjExpensify

@dannymcclain as the linked issue was yours. Are we deeming this one a "search input field" because it technically has the search query named stored before you rename it?

No I don't think so. IMO this input is more like a Group name than the search input, so we can probably ditch this one too. cc @Expensify/design

(I think in our little framework we decided that we're not super worried about the usability of clearing a long text field, so we decided to remove the clear button from inputs like this, group names, etc)

s77rt · 2025-05-14T16:26:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

JS bundle issue. NAB

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

mollfpr

Thank you!

OSBotify · 2025-05-15T04:14:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: required field error is not displayed when clearing the field

6a63fd8

daledah added 2 commits May 8, 2025 22:40

fix: hide clear buttons

9bf5d7c

fix: lint

213fdeb

daledah marked this pull request as ready for review May 9, 2025 02:18

daledah requested a review from a team as a code owner May 9, 2025 02:18

melvin-bot bot requested a review from ahmedGaber93 May 9, 2025 02:18

melvin-bot bot removed the request for review from a team May 9, 2025 02:18

s77rt suggested changes May 9, 2025

View reviewed changes

daledah added 2 commits May 14, 2025 11:21

Merge branch 'main' into fix/60243

8d7b746

fix: canBeMissing

3f5d7af

s77rt approved these changes May 14, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr May 14, 2025 16:27

mollfpr approved these changes May 15, 2025

View reviewed changes

mollfpr merged commit 11385b8 into Expensify:main May 15, 2025
17 of 18 checks passed

francoisl mentioned this pull request May 16, 2025

Deploy Checklist: New Expensify 2025-05-15 #62161

Open

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: required field error is not displayed when clearing the field #61653

fix: required field error is not displayed when clearing the field #61653

daledah commented May 8, 2025 •

edited

Loading

melvin-bot bot commented May 8, 2025

melvin-bot bot commented May 9, 2025

daledah commented May 9, 2025

s77rt May 9, 2025

s77rt May 9, 2025

trjExpensify May 12, 2025

shawnborton May 13, 2025

dannymcclain May 13, 2025

s77rt May 13, 2025

dannymcclain May 13, 2025

s77rt May 9, 2025

s77rt May 9, 2025

trjExpensify May 12, 2025

dannymcclain May 13, 2025

s77rt commented May 14, 2025

mollfpr left a comment

OSBotify commented May 15, 2025

fix: required field error is not displayed when clearing the field #61653

fix: required field error is not displayed when clearing the field #61653

Conversation

daledah commented May 8, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 8, 2025

melvin-bot bot commented May 9, 2025

daledah commented May 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented May 14, 2025

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

OSBotify commented May 15, 2025

daledah commented May 8, 2025 •

edited

Loading