[Due for payment 2025-03-21] [SIDEPANE][Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592

[mallenexpensify]

Note: This is for @blazejkustra.

The design doc for Add live-navigating help side pane is still going through detailed review. However, I'd like to get a head start on proving out the basics of the technology. There is already a WIP PR here: #56490 Can you please:

1. Implement everything up to Stage 1, then stop
2. Submit this PR for merging

Thanks!

cc @quinthar

Issue Owner

Current Issue Owner: @mallenexpensify

[mallenexpensify]

@blazejkustra can you please comment so I can assign to you? Thx

[blazejkustra]

🚀

[blazejkustra]

Update: I started cleaning the PR that I prepared during SF onshore. I'll provide more details tomorrow on where we stand 🚢

[quinthar]

Great, thanks!!

[blazejkustra]

Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow!

Screen.Recording.2025-02-20.at.19.08.29.mov

[quinthar]

Fantastic! How long before we have a PR that can be merged?

…

On Thu, Feb 20, 2025, 10:13 AM Błażej Kustra ***@***.***> wrote: Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow! https://github.com/user-attachments/assets/39d9804a-2b64-4153-a347-222fe544d986 — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUQT23ZGUTYWBHXNBNT2QYLONAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGMYDCMRWGA> . You are receiving this because you were assigned.Message ID: ***@***.***> [image: blazejkustra]*blazejkustra* left a comment (Expensify/App#56988) <#56988 (comment)> Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow! https://github.com/user-attachments/assets/39d9804a-2b64-4153-a347-222fe544d986 — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUQT23ZGUTYWBHXNBNT2QYLONAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGMYDCMRWGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[blazejkustra]

Fantastic! How long before we have a PR that can be merged?

To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday.

Is somebody working on the backend part already?

1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value.

[quinthar]

Hm, good question -- don't block on that. For now we can just test by setting it locally; your PR can be merged either way, right?

…

On Fri, Feb 21, 2025 at 11:52 AM Błażej Kustra ***@***.***> wrote: Fantastic! How long before we have a PR that can be merged? To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday. Is somebody working on the backend part already? 1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value. — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY> . You are receiving this because you were assigned.Message ID: ***@***.***> [image: blazejkustra]*blazejkustra* left a comment (Expensify/App#56988) <#56988 (comment)> Fantastic! How long before we have a PR that can be merged? To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday. Is somebody working on the backend part already? 1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value. — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY> . You are receiving this because you were assigned.Message ID: ***@***.***>

[blazejkustra]

For now we can just test by setting it locally; your PR can be merged either way, right?

That's correct 👍

[blazejkustra]

Update: Today I was working on entering animation for the modal, also created getHelpContent and hooked everything up. PR should be ready to review tomorrow!

update.mov

[blazejkustra]

Update: I’ve just opened the PR for the initial review!

The positioning of the side pane when the RHP is displayed simultaneously is a bit tricky, and there may be some edge cases to consider. @dubielzyk-expensify, please trigger an ad hoc build and let me know what specific areas I should focus on.

Keep in mind that this is Stage 1, so there’s no content yet, and the styling could be refined in future PRs.

[brunovjk]

@quinthar @mallenexpensify Can I have access to the design doc to review the PR? Thanks.

[dubielzyk-expensify]

Awesome start. Added some comments with the other designers in that PR 👍 Lovely progress

[mallenexpensify]

Added you @brunovjk , with comment access, dive in! https://docs.google.com/document/d/1prFcvgUlEGRuL3zE-JH-lhv_BWX2lL2YNw61w4YVnyY/edit?usp=sharing

[quinthar]

Looks like this is nearly done! https://expensify.slack.com/archives/C07NZ8B1VTQ/p1741050408133159?thread_ts=1739423034.121089&cid=C07NZ8B1VTQ

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[brunovjk]

I just reviewed the PR @francoisl, can you take a look please? Also, if possible, assign me here. Thanks.

[melvin-bot]

@brunovjk @mallenexpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mallenexpensify]

@brunovjk are you do $250 each for reviewing

#56490
and
#57831

[garrettmknight]

@mallenexpensify I think a PR on this issue caused a regression here.

[brunovjk]

@brunovjk are you do $250 each for reviewing

#56490 and #57831

We've had some regressions here, we're dealing with them. When everything is resolved I'll come back here and make a summary, then we'll proceed with the payment. What do you think @mallenexpensify? Thanks.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @brunovjk paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[brunovjk]

We are now moving towards stage 4 of the Help Panel implementation. All regressions from stage 1 have been addressed. I believe we can close this issue, the BZ checklist and payment will be handled here. Thank you.

[mallenexpensify]

Thanks, closing, handling payment via

• Payment for Help Panel implementation for C+ #59081

[garrettmknight]

Reopening for payment summary for @rushatgabhane

Please confirm the payment for this comment: #56988 (comment)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

@rushatgabhane confirming you reviewed this PR as an "outside" C+ assignment, not as a result of a regression to an original PR you reviewed?

[rushatgabhane]

yes that is correct!

[trjExpensify]

Payment summary as follows:

• $250 to @rushatgabhane for this PR review.

[garrettmknight]

$250 approved for @rushatgabhane