Skip to content

[Due for payment 2025-03-21] [$250] Help panel - Help panel animates strangely when workspace switcher is closed #57811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue Mar 5, 2025 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@mitarachim
Copy link

mitarachim commented Mar 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePaneExpanded', {}) in console.
  1. Go to staging.new.expensify.com
  2. Open workspace switcher.
  3. Click Help icon.
  4. Click on the empty area.

Expected Result:

Help panel will not animate strangely when workspace switcher is closed.

Actual Result:

Help panel animates strangely when workspace switcher is closed.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761370_1741138568923.20250305_093356.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897104360085156387
  • Upwork Job ID: 1897104360085156387
  • Last Price Increase: 2025-03-05
Issue OwnerCurrent Issue Owner: @garrettmknight
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 5, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@robertjchen robertjchen added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 Engineering Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 5, 2025
@melvin-bot melvin-bot bot changed the title Help panel - Help panel animates strangely when workspace switcher is closed [$250] Help panel - Help panel animates strangely when workspace switcher is closed Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021897104360085156387

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 5, 2025
@francoisl francoisl added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Mar 5, 2025
@blazejkustra
Copy link
Contributor

blazejkustra commented Mar 6, 2025

Do we even need to show the help icon / be able to trigger it from the workspace switcher?

The help pane might already be open when clicking on the workspace switcher, so that's only part of the puzzle 😅

@dannymcclain
Copy link
Contributor

We're also planning on removing the workspace switcher as part of an upcoming project... @Expensify/design what are you all thinkin' here?

@shawnborton
Copy link
Contributor

Yeah, I totally agree that we don't need to show this on the workspace switcher. And especially because we're planning to deprecate that soon anyways. So I think I would just remove it from here for the time being?

@dannymcclain
Copy link
Contributor

That's my thinking as well.

@dubielzyk-expensify
Copy link
Contributor

Yeah, I also don't think we need to show it in the workspace switcher 👍

@289Adam289
Copy link
Contributor

Hi I am Adam from SWM I am helping @blazejkustra with Help Panel issues and I'd like work on this issue.

@brunovjk
Copy link
Contributor

brunovjk commented Mar 7, 2025

I reviewed the PR that caused this regression. Please assign me here as a C+. Thanks!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Mar 7, 2025
@melvin-bot melvin-bot bot changed the title [$250] Help panel - Help panel animates strangely when workspace switcher is closed [Due for payment 2025-03-21] [$250] Help panel - Help panel animates strangely when workspace switcher is closed Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-21. 🎊

For reference, here are some details about the assignees on this issue:

@garrettmknight
Copy link
Contributor

This was caused by a regression so payment for @brunovjk will be handled on the original issue: #56988

@brunovjk
Copy link
Contributor

brunovjk commented Mar 27, 2025

I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close, payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests