[Due for payment 2025-03-21] Help panel - Get assistance and Help buttons have the same icon on invite member RHP

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.9-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Run Onyx.set('nvp_sidePaneExpanded', {}) in console.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workspace members.
3. Click Invite member.

Expected Result:

Get assistance and Help icons will be distinctive.

Actual Result:

Get assistance and Help icons look the same.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6761310_1741131111430.20250305_072741.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my #56490 so I'd like to work on it 👀

[robertjchen]

You've got it @blazejkustra 👍

[blazejkustra]

@shawnborton @dannymcclain @dubielzyk-expensify 👋

I need advice on what better icon we could use here for 'Get assistance from our team' button:

[dannymcclain]

@Expensify/design thoughts on any of these? Maybe the info one?

[shawnborton]

Honestly, I feel like we should just kill the get assistance button in lieu of this new help RHP.

That "get assistance" button only exists in this page on NewDot I think... I think we had intentions of using it in more places but we never really followed up with it. It's kind of a relic from the first iteration of the workspace editor that NewDot had, back when we only had a free plan.

cc @JmillsExpensify @trjExpensify for thoughts on that too. But yeah, my vote is just to kill it!

[shawnborton]

Not only that, it leads to a pretty dated page which has some redundancy with the help pane anyways:

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Workspace Switcher and Get Assistance Button issues  #58000

If no regressions arise, payment will be issued on 2025-03-21. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @brunovjk requires $250 payment (Needs manual offer from BZ) - Upwork offer https://www.upwork.com/nx/wm/offer/106604677

[melvin-bot]

@brunovjk @Christinadobrzyn @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Christinadobrzyn]

payment in a few days

[Christinadobrzyn]

Payment is scheduled for tomorrow -

@brunovjk do we need a regression test for this?

Payment summary - #57808 (comment)

[brunovjk]

@Christinadobrzyn This issue is part of the regressions of stage 1 of the implementation of Help Penal. We are still dealing with them, I will come back here with a summary when everything is fixed, perhaps the payment can be made in the original issue.

[Christinadobrzyn]

Thanks @blazejkustra! Yes, I think we should pay in the main job GH - #56988.

I'll keep this open to monitor the decision here #56988 (comment)

[Christinadobrzyn]

monitoring #56988 (comment)

[Christinadobrzyn]

monitoring #56988 (comment)

[Christinadobrzyn]

Just a heads up that I'm going to be ooo March 27th - April 6th. Back on the 7th.

I'm going to assign a BZ teammate to help with this if we need to pay here. cc @JmillsExpensify

@brunovjk can you provide a summary of where we are with testing the regressions? Are we still planning on paying out here and not paying in this issue?

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[brunovjk]

@Christinadobrzyn the payment will be handled here
But I also wonder about the regression test. If I make one for each issue related or not

[Christinadobrzyn]

Thanks @brunovjk! Hum that is a good question. It looks like you've summarized the regressions here #59081 - right?

I think that is a good plan to use #59081 as a summary of all the regression testing and also where you'll be paid. Let me know if I'm missing something!

[brunovjk]

Great!!! I will do that! Thank you!!!

[JmillsExpensify]

Nice, so then what's the plan with this issue. Do we close it?

[brunovjk]

I think we can close. If is necessary I ask to reopen :D

[brunovjk]

I can't reproduce this anymore. Payment and BZ checklist will be handled here. Thanks!