Skip to content

refactor(input-date-picker)!: Removed deprecated start, startAsDate, end, endAsDate properties #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eriklharper
Copy link
Contributor

@eriklharper eriklharper commented Dec 16, 2022

BREAKING CHANGE: Removed the start, end, startAsDate, and endAsDate properties.

  • Removed the property start, use value instead.
  • Removed the property end, use value instead.
  • Removed the property startAsDate, use valueAsDate instead.
  • Removed the property endAsDate, use valueAsDate instead.

@eriklharper eriklharper requested a review from a team as a code owner December 16, 2022 17:45
@eriklharper eriklharper requested a review from driskull December 16, 2022 17:45
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 16, 2022
@eriklharper eriklharper requested a review from benelan December 16, 2022 17:45
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 16, 2022
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 16, 2022
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code looks good!

@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 16, 2022
@eriklharper eriklharper merged commit 88720fc into master Dec 16, 2022
@eriklharper eriklharper deleted the eriklharper/5798-input-date-picker-remove-start-end-props branch December 16, 2022 18:11
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 16, 2022
benelan added a commit that referenced this pull request Dec 16, 2022
* master: (36 commits)
  1.0.0-next.696
  feat(tip,tip-manager): add built-in translations (#6074)
  1.0.0-next.695
  fix(icon, graphic, loader): Set aria-hidden on internal svg elements (#6069)
  1.0.0-next.694
  refactor(modal)!: Renamed CSS variable (#6078)
  1.0.0-next.693
  refactor(color-picker-hex-input)!: removed `intl*` properties (#6063)
  1.0.0-next.692
  feat(shell): Add slots for Modal and Alert (#5983)
  1.0.0-next.691
  refactor(input-date-picker)!: Removed deprecated start, startAsDate, end, endAsDate properties (#6076)
  1.0.0-next.690
  fix(combobox): Fix error when typing a custom value (#6071)
  1.0.0-next.689
  fix(rating): 5312 improve user interface (#5948)
  chore: Clean outdated properties (#6073)
  docs: update component READMEs (#6072)
  chore: Update interface references (#6068)
  chore(action): Clean up action appearance references (#6067)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants