Skip to content

feat(tip,tip-manager): add built-in translations #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 16, 2022
Merged

feat(tip,tip-manager): add built-in translations #6074

merged 7 commits into from
Dec 16, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 16, 2022 •
edited
Loading

Related Issue: #6066

Summary

This PR will add built-in translations to tip & tip-manager

BREAKING CHANGES: Removed intl* properties.

  • tip :

    • Removed the property intlClose, use messageOverrides.close instead.

  • tip-manager:

    • Removed the property intlClose, use messageOverrides.close instead.
    • Removed the property intlNext, use messageOverrides.next instead.
    • Removed the property intlPaginationLabel, use messageOverrides.paginationLabel instead.
    • Removed the property intlPrevious, use messageOverrides.previous instead.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 16, 2022
@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 16, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 16, 2022 20:01
@anveshmekala anveshmekala requested a review from a team as a code owner December 16, 2022 20:01
@anveshmekala
Copy link
Contributor Author

Should the breaking changes be separated out @geospatialem , @driskull ?

@driskull
Copy link
Member

Should the breaking changes be separated out @geospatialem , @driskull ?

Ideally, yes. But I think this is fine this time.

driskull
driskull approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 16, 2022
@anveshmekala anveshmekala merged commit 683cf07 into master Dec 16, 2022
@anveshmekala anveshmekala deleted the anveshmekala/6066-tip-add-built-in-translations branch December 16, 2022 21:43
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 16, 2022
benelan added a commit that referenced this pull request Dec 16, 2022
@benelan
Merge branch 'master' into benelan/date-picker-remove-deprecations
84109bb 
* master: (36 commits)
  1.0.0-next.696
  feat(tip,tip-manager): add built-in translations (#6074)
  1.0.0-next.695
  fix(icon, graphic, loader): Set aria-hidden on internal svg elements (#6069)
  1.0.0-next.694
  refactor(modal)!: Renamed CSS variable (#6078)
  1.0.0-next.693
  refactor(color-picker-hex-input)!: removed `intl*` properties (#6063)
  1.0.0-next.692
  feat(shell): Add slots for Modal and Alert (#5983)
  1.0.0-next.691
  refactor(input-date-picker)!: Removed deprecated start, startAsDate, end, endAsDate properties (#6076)
  1.0.0-next.690
  fix(combobox): Fix error when typing a custom value (#6071)
  1.0.0-next.689
  fix(rating): 5312 improve user interface (#5948)
  chore: Clean outdated properties (#6073)
  docs: update component READMEs (#6072)
  chore: Update interface references (#6068)
  chore(action): Clean up action appearance references (#6067)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull