feat(shell): Add slots for Modal and Alert #5983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
macandcheese
added
the
pr ready for visual snapshots
driskull
reviewed
Dec 13, 2022
macandcheese
force-pushed
the
macandcheese/add-shell-slot-alerts
branch
from
9de0272 to
a6fc4cc
Compare
benelan
added a commit
that referenced
this pull request
Dec 16, 2022
* master: (36 commits) 1.0.0-next.696 feat(tip,tip-manager): add built-in translations (#6074) 1.0.0-next.695 fix(icon, graphic, loader): Set aria-hidden on internal svg elements (#6069) 1.0.0-next.694 refactor(modal)!: Renamed CSS variable (#6078) 1.0.0-next.693 refactor(color-picker-hex-input)!: removed `intl*` properties (#6063) 1.0.0-next.692 feat(shell): Add slots for Modal and Alert (#5983) 1.0.0-next.691 refactor(input-date-picker)!: Removed deprecated start, startAsDate, end, endAsDate properties (#6076) 1.0.0-next.690 fix(combobox): Fix error when typing a custom value (#6071) 1.0.0-next.689 fix(rating): 5312 improve user interface (#5948) chore: Clean outdated properties (#6073) docs: update component READMEs (#6072) chore: Update interface references (#6068) chore(action): Clean up action appearance references (#6067) ...
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Proposed as part of Shell / Layout enhancements: https://confluencewikidev.esri.com/pages/viewpage.action?pageId=222267264 (VPN needed)
Summary
This is a draft PR to add two new slots to
calcite-shell:modalandalerts.This pattern was proposed as part of our upcoming Shell / layout improvements, and would be leveraged by the upcoming proposed
calcite-sheetcomponent.When expected components are slotted into named slots, conditional styles are applied to constrain their extent to that of the
calcite-shell(including covering the existingheaderandfooterslots). This is useful in many cases, specifically when thecalcite-shellis embedded amongst other content, like tutorials, documentation pages, or any place the user experience is not a completely full-screencalcite-shell.When these components are not slotted into the new
calcite-shellslots - their behavior remains unchanged.A demo is available locally at
/demos/shell/basic-slotted-elements.htmlcc @asangma @mitc7862
Screen recording of proposed behavior:
Screen.Recording.2022-12-12.at.6.14.15.PM.mov