feat: add default focus color token #10512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
requested review from
jcfranco,
macandcheese,
geospatialem,
SkyeSeitz and
ashetland
geospatialem
reviewed
Oct 9, 2024
There was a problem hiding this comment.
@alisonailea Awesome! 💨 Can you also add in the more related #10510 to the issue context?
jcfranco
changed the title
jcfranco
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Do we need to generate separate semantic output for the default focus color to be added? This change is breaking as it removes exports from the global files (causing this build failure).
jcfranco
reviewed
Oct 18, 2024
jcfranco
reviewed
Oct 18, 2024
packages/calcite-design-tokens/support/tests/__snapshots__/index.spec.ts.snap
Show resolved
Hide resolved
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
added
the
pr ready for visual snapshots
jcfranco
approved these changes
Oct 29, 2024
github-actions
bot
added this to the 2024-11-19 - 3.0.0 Nov Breaking Change Milestone milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
jcfranco
added a commit
that referenced
this pull request
Mar 7, 2025
**Related Issue:** #10510 ## Summary Removes the global focus color introduced in [#10512](#10512) to match the behavior of the deprecated `--calcite-ui-focus-color`. Previously, `--calcite-color-focus` was defined at `:root`, preventing it from inheriting updates to `--calcite-color-brand` (its fallback). This is **not** considered a breaking change because: * it only affects outputs that are not publicly documented * the default color will still be applied as expected * `--calcite-color-focus` remains available for overriding the focus color **Note**: #11713 will restore `--calcite-color-focus` after #11391 lands.
jcfranco
added a commit
that referenced
this pull request
Mar 11, 2025
**Related Issue:** #10510 ## Summary Removes the global focus color introduced in [#10512](#10512) to match the behavior of the deprecated `--calcite-ui-focus-color`. Previously, `--calcite-color-focus` was defined at `:root`, preventing it from inheriting updates to `--calcite-color-brand` (its fallback). This is **not** considered a breaking change because: * it only affects outputs that are not publicly documented * the default color will still be applied as expected * `--calcite-color-focus` remains available for overriding the focus color **Note**: #11713 will restore `--calcite-color-focus` after #11391 lands.
benelan
pushed a commit
that referenced
this pull request
Mar 26, 2025
**Related Issue:** #10510 ## Summary Removes the global focus color introduced in [#10512](#10512) to match the behavior of the deprecated `--calcite-ui-focus-color`. Previously, `--calcite-color-focus` was defined at `:root`, preventing it from inheriting updates to `--calcite-color-brand` (its fallback). This is **not** considered a breaking change because: * it only affects outputs that are not publicly documented * the default color will still be applied as expected * `--calcite-color-focus` remains available for overriding the focus color **Note**: #11713 will restore `--calcite-color-focus` after #11391 lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180 #10510
Summary
This adds
calcite-color-focusto replace the deprecatedcalcite-ui-focus-color