-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.enhancementIssues tied to a new feature or request.Issues tied to a new feature or request.estimate - 8Requires input from team, consider smaller steps.Requires input from team, consider smaller steps.p - highIssue should be addressed in the current milestone, impacts component or core functionalityIssue should be addressed in the current milestone, impacts component or core functionality
Milestone
Description
Check existing issues
- I have checked for existing issues to avoid duplicates
Description
Requires a major refactor of calcite-design-tokens
This will remove several (now unnecessary) custom token transformer functions. Align with the latest Token Studio and Style Dictionary versions.
Blocked issues: #10051
Requirements checkoff
- Reorganize files to align with the new StyleDictionary config format
- Create new config files
- Refactor or (re)write StyleDictionary functions
- Transformers to match SD format
- Calcite Transformation Group
- Transform name to replace "-" with "minus" and "+" with "plus"
- Transform name to remove the Tier
- Transform name to remove the word "default"
- Transform value of boxshadow for CSS platforms
- Transform any number value to calculate sum
- Transform px value to rem for space, size, font-size, etc.
- Transform breakpoint value to px
- Headers to match SD format
- Default Calcite header for generated files
- Calcite header for deprecated generated files
- Formats to match SD format & normalize file names (aka "global --> semantic")
- /css
- breakpoints.css
- classes.css (typography classes)
- core.css
- dark.css
- light.css
- semantic.css
- global.css (deprecate)
- index.css
- /scss
- /es6
- breakpoints.js
- core.js
- dark.js
- light.js
- semantic.js
- global.js
- merge semantic, light, & dark
- deprecate
- /js (internal)
- core.js
- global.js
- merge semantic, light, & dark
- deprecate
- dark.js
- light.js
- semantic.js
- /docs (internal)
- core.json
- global.json
- merge semantic, light, & dark
- deprecate
- light.json
- dark.json
- semantic.json
- /css
- Filters to match SD format
- Source
- Core
- Breakpoints
- Global
- Light
- Dark
- Typography
- Transformers to match SD format
- Setup calcite color themes in Token Studio in Figma
Acceptance Criteria
@tokens-studio/sd-transforms is at or above v1.2.9
style-dictionary is at or above v4.3.2
Run npm run build
packages/calcite-design-tokens/dist includes the following assets
/css
breakpoints.css
core.css
dark.css
index.css
light.css
semantic.css
/scss
breakpoints.scss
core.scss
dark.scss
index.scss
light.scss
semantic.scss
/es6
breakpoints.js
core.js
dark.js
global.js
light.js
semantic.js
/js
core.js
dark.js
global.js
light.js
semantic.js
/docs
core.json
dark.json
global.json
light.json
semantic.json
Relevant Info
Required to resolve:
Which Component
tokens
Example Use Case
No response
Priority impact
impact - p2 - want for an upcoming milestone
Calcite package
- @esri/calcite-components
- @esri/calcite-components-react
- @esri/calcite-design-tokens
- @esri/calcite-ui-icons
- @esri/eslint-plugin-calcite-components
Esri team
N/A
Metadata
Metadata
Assignees
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.enhancementIssues tied to a new feature or request.Issues tied to a new feature or request.estimate - 8Requires input from team, consider smaller steps.Requires input from team, consider smaller steps.p - highIssue should be addressed in the current milestone, impacts component or core functionalityIssue should be addressed in the current milestone, impacts component or core functionality