Skip to content

Restore --calcite-color-focus in the design-tokens output #11713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 6 tasks
jcfranco opened this issue Mar 7, 2025 · 0 comments
Open
3 of 6 tasks

Restore --calcite-color-focus in the design-tokens output #11713

jcfranco opened this issue Mar 7, 2025 · 0 comments
Assignees
@jcfranco @matgalla
Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone monday.com sync Monday.com sync p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-06-24 - Jun ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Mar 7, 2025 •
edited by matgalla
Loading

Check existing issues

Actual Behavior

--calcite-color-focus is no longer represented in a token after #11711.

Expected Behavior

--calcite-color-focus present in both token source JSON and build output. It should output --calcite-color-focus: var(--calcite-color-brand) (custom prop unresolved), to associate it with the brand color while still allowing overrides.

Reproduction Sample

https://unpkg.com/browse/@esri/[email protected]/dist/css/light.css

Reproduction Steps

Notice how --calcite-color-focus is not defined.

Notes:

Reproduction Version

3.1.0-next.22 (or version that ships #11711)

Relevant Info

Follow up from #11711.

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
monday.com sync: #8961117110
@jcfranco jcfranco added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Mar 7, 2025
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Mar 7, 2025
@jcfranco jcfranco mentioned this issue Mar 7, 2025
Merged
jcfranco added a commit that referenced this issue Mar 7, 2025
@jcfranco
fix: allow global focus color token to inherit fallback value (#11711)
f8c63e3 
**Related Issue:** #10510  

## Summary  

Removes the global focus color introduced in
[#10512](#10512) to
match the behavior of the deprecated `--calcite-ui-focus-color`.
Previously, `--calcite-color-focus` was defined at `:root`, preventing
it from inheriting updates to `--calcite-color-brand` (its fallback).

This is **not** considered a breaking change because:  

* it only affects outputs that are not publicly documented
* the default color will still be applied as expected
* `--calcite-color-focus` remains available for overriding the focus
color

**Note**: #11713
will restore `--calcite-color-focus` after #11391 lands.
jcfranco added a commit that referenced this issue Mar 11, 2025
@jcfranco
fix: allow global focus color token to inherit fallback value (#11711)
8581d50 
**Related Issue:** #10510  

## Summary  

Removes the global focus color introduced in
[#10512](#10512) to
match the behavior of the deprecated `--calcite-ui-focus-color`.
Previously, `--calcite-color-focus` was defined at `:root`, preventing
it from inheriting updates to `--calcite-color-brand` (its fallback).

This is **not** considered a breaking change because:  

* it only affects outputs that are not publicly documented
* the default color will still be applied as expected
* `--calcite-color-focus` remains available for overriding the focus
color

**Note**: #11713
will restore `--calcite-color-focus` after #11391 lands.
benelan pushed a commit that referenced this issue Mar 26, 2025
@jcfranco @benelan
fix: allow global focus color token to inherit fallback value (#11711)
a732c8d 
**Related Issue:** #10510  

## Summary  

Removes the global focus color introduced in
[#10512](#10512) to
match the behavior of the deprecated `--calcite-ui-focus-color`.
Previously, `--calcite-color-focus` was defined at `:root`, preventing
it from inheriting updates to `--calcite-color-brand` (its fallback).

This is **not** considered a breaking change because:  

* it only affects outputs that are not publicly documented
* the default color will still be applied as expected
* `--calcite-color-focus` remains available for overriding the focus
color

**Note**: #11713
will restore `--calcite-color-focus` after #11391 lands.
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 1, 2025
@jcfranco jcfranco self-assigned this Apr 11, 2025
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 11, 2025
@matgalla matgalla mentioned this issue Apr 15, 2025
Open
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 15, 2025
@matgalla matgalla added the monday.com sync Monday.com sync label Apr 18, 2025
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

@matgalla matgalla

Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone monday.com sync Monday.com sync p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-06-24 - Jun Milestone
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @matgalla