-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Dds quadplane takeoff #30098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dds quadplane takeoff #30098
Conversation
It seems like this actually adds a more generic "plane_takeoff" method for DDS, but initially only implements VTOL, but could implement fixed wing takeoff at some point in the future. I guess my gripe is that the PR says it's only implementing quadplane takeoff, but it's actually more than that, which is actually a good thing. Any reason not to do it now @Ryanf55 ? Would it not need to simply switch to TAKEOFF mode? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a nicely generic function that could be fleshed out to work for fixed wing too.
8e59d61
to
6cd7a8c
Compare
6cd7a8c
to
4541631
Compare
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
4541631
to
0226215
Compare
Purpose
Allow VTOL takeoff on quadplane using DDS. I chose to uses the GUIDED user takeoff but am open to using the mission interface. There seems to be differences in implementation.
Details
I only override the
start_takeoff
function if quadplane is enabled. This saves flash.Instructions
In ros workspace
In ardupilot
In a CLI, switch to guided, arm, takeoff, and send a goal location showing switch to forward flight
Issue
Closes #29932