AP_Logger: take a blocking semaphore when writing messages using the block logger #27278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Jun 10, 2024
andyp1per
force-pushed
the
pr-log-block-miss
branch
from
b38e636 to
4d8e88b
Compare
|
Merged, thanks @andyp1per |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current block logger can generate logs that have significant holes. It turns out this is due to the very short time it waits to acquire the write buffer lock before giving up. The file logger blocks and the block logger should do the same. Tested on my Marmotte 5