Skip thrift json roundtrip check while reading GroupByServingInfo

[piyush-zlai]

Summary

When we add fields in our API, we can run into backwards / forwards compat issues depending on when the json updates make their way out to the GroupByServingInfo (on orch side / serving side). Turning off the round trip check to help cut the noise on these issues. If we can deserialize the thrift json we proceed else this code will throw a JsonException.
Some details - slack thread

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility when loading certain configuration data by relaxing validation during data processing.

[coderabbitai]

Walkthrough

The deserialization process for GroupByServingInfo in the metadata fetcher now disables strict validation by setting the check parameter to false in the fromJsonStr method. All other logic, such as error handling and metrics, remains unchanged.

Changes

File(s)	Change Summary
.../online/fetcher/MetadataStore.scala	Changed fromJsonStr(check = true) to fromJsonStr(check = false) for GroupByServingInfo deserialization.

Poem

A toggle flipped, strict checks set free,
JSON flows with leniency.
GroupBy info, now less stern,
Welcomes data at each turn.
In code we trust, in checks we bend—
Here’s to logic we extend!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 30f5356 and 6836b47.

📒 Files selected for processing (1)

• online/src/main/scala/ai/chronon/online/fetcher/MetadataStore.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: api_tests
• GitHub Check: service_tests
• GitHub Check: service_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_commons_tests
• GitHub Check: online_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: api_tests
• GitHub Check: aggregator_tests
• GitHub Check: aggregator_tests
• GitHub Check: online_tests
• GitHub Check: flink_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: flink_tests

🔇 Additional comments (1)

online/src/main/scala/ai/chronon/online/fetcher/MetadataStore.scala (1)

414-416: Appropriate compatibility fix.

Disabling the JSON roundtrip check improves backward/forward compatibility when fields are added to GroupByServingInfo.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.