Skip to content

Commit cff616e

Browse files
authored
Skip thrift json roundtrip check while reading GroupByServingInfo (#774)
## Summary When we add fields in our API, we can run into backwards / forwards compat issues depending on when the json updates make their way out to the GroupByServingInfo (on orch side / serving side). Turning off the round trip check to help cut the noise on these issues. If we can deserialize the thrift json we proceed else this code will throw a JsonException. Some details - [slack thread](https://zipline-2kh4520.slack.com/archives/C08345NBWH4/p1747092844340579) ## Checklist - [ ] Added Unit Tests - [X] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved compatibility when loading certain configuration data by relaxing validation during data processing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 7f14285 commit cff616e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

online/src/main/scala/ai/chronon/online/fetcher/MetadataStore.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ class MetadataStore(fetchContext: FetchContext) {
412412
} else {
413413
import ai.chronon.online.metrics
414414
val groupByServingInfo = ThriftJsonCodec
415-
.fromJsonStr[GroupByServingInfo](metaData.get, check = true, classOf[GroupByServingInfo])
415+
.fromJsonStr[GroupByServingInfo](metaData.get, check = false, classOf[GroupByServingInfo])
416416
metrics.Metrics
417417
.Context(metrics.Metrics.Environment.MetaDataFetching, groupByServingInfo.groupBy)
418418
.withSuffix("group_by")

0 commit comments

Comments
 (0)