Skip to content

[Spark] disable checks in join monolith #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

[Spark] disable checks in join monolith #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c77b81f
WIP
ezvz Apr 24, 2025
5c9e237
WIP
ezvz Apr 25, 2025
5607207
WIP
ezvz Apr 28, 2025
adbe5c6
WIP
ezvz Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spark/src/main/scala/ai/chronon/spark/JoinBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ abstract class JoinBase(val joinConfCloned: api.Join,
}

// Run validations before starting the job
val analyzer = new Analyzer(tableUtils, joinConfCloned, endPartition, endPartition, silenceMode = true)
// val analyzer = new Analyzer(tableUtils, joinConfCloned, endPartition, endPartition, silenceMode = true)
try {
analyzer.analyzeJoin(joinConfCloned, validationAssert = true)
// analyzer.analyzeJoin(joinConfCloned, validationAssert = true)
metrics.gauge(Metrics.Name.validationSuccess, 1)
logger.info("Join conf validation succeeded. No error found.")
} catch {
Expand Down
5 changes: 3 additions & 2 deletions spark/src/main/scala/ai/chronon/spark/JoinUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,8 +580,9 @@ object JoinUtils {
// events | entities | temporal => right part tables are aligned - so scan by leftRange
// entities | entities | snapshot => right part tables are aligned - so scan by leftRange
val rightRange = if (leftDataModel == EVENTS && joinPart.groupBy.inferredAccuracy == Accuracy.SNAPSHOT) {
val leftTimeRange = leftTimeRangeOpt.getOrElse(leftDf.get.timeRange.toPartitionRange)
leftTimeRange.shift(shiftDays)
// Diabling for now
// val leftTimeRange = leftTimeRangeOpt.getOrElse(leftDf.get.timeRange.toPartitionRange)
leftRange.shift(shiftDays)
} else {
leftRange
}
Expand Down