[Spark] disable checks in join monolith

[varant-zlai]

Summary

Disabling analyzer checks

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Disabled the join configuration validation step before starting join jobs.
  • Updated time range calculation logic for certain join scenarios to improve consistency.

[coderabbitai]

Walkthrough

The change disables the join configuration validation step in the computeJoinOpt method of JoinBase.scala by commenting out the instantiation of the Analyzer object and its analyzeJoin method call. Error handling and metrics recording related to this validation remain in place but will not be triggered, as the analyzer is no longer invoked. Additionally, the shiftDays method in JoinUtils.scala is modified to bypass using leftTimeRangeOpt and leftDf for computing the shifted partition range when the left model is EVENTS and accuracy is SNAPSHOT, instead directly shifting the passed leftRange. No other logic or control flow is modified.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/JoinBase.scala	Commented out creation of Analyzer and call to analyzeJoin, disabling join validation.
spark/src/main/scala/ai/chronon/spark/JoinUtils.scala	Modified shiftDays method to skip use of leftTimeRangeOpt and leftDf for EVENTS + SNAPSHOT, directly shifting leftRange.

Possibly related PRs

• Cherry-pick Adding Timestamp Check to Join Analyzer (#802) #169: Adds timestamp validation in Analyzer.analyzeJoin; this PR bypasses that validation by disabling the call.
• optimize: reduce a partitions call when checking permissions #376: Alters the default parameter of analyzeJoin in Analyzer.scala; both PRs involve the same method.

Suggested reviewers

• nikhil-zlai

Poem

A join once checked by Analyzer’s eye,
Now skips its scan and passes by.
The code stands ready, error guards in place,
But validation’s gone without a trace.
Quietly the logic flows,
Awaiting what the next change sows.
⏳✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

spark/src/main/scala/ai/chronon/spark/JoinUtils.scala (1)

583-585: Time range calculation simplified in EVENTS-SNAPSHOT joins

The code now directly shifts the leftRange parameter instead of deriving a new time range from leftTimeRangeOpt or leftDf.get.timeRange. This bypasses additional data lookups.

Consider adding a comment explaining why this approach was chosen over the original implementation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 5607207 and adbe5c6.

📒 Files selected for processing (1)

• spark/src/main/scala/ai/chronon/spark/JoinUtils.scala (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

spark/src/main/scala/ai/chronon/spark/JoinUtils.scala (1)

api/src/main/scala/ai/chronon/api/DataRange.scala (1)

• shift (99-105)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: streaming_tests
• GitHub Check: join_tests
• GitHub Check: spark_tests
• GitHub Check: groupby_tests
• GitHub Check: analyzer_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: fetcher_tests
• GitHub Check: groupby_tests
• GitHub Check: batch_tests
• GitHub Check: fetcher_tests
• GitHub Check: spark_tests
• GitHub Check: batch_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows