fix: Couple more spots of addressing the proper name #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update modifies how left source table names are determined in Spark join and merge jobs, switching from Changes
Sequence Diagram(s)sequenceDiagram
participant Test as BigQueryCatalogTest
participant TableUtils
participant BigQuery
Test->>TableUtils: loadTable("data.checkouts_native", [partitionFilter])
TableUtils->>BigQuery: Query with filter
BigQuery-->>TableUtils: Filtered DataFrame
Test->>TableUtils: loadTable("data.checkouts_native", [partitionFilter, partitionFilter])
TableUtils->>BigQuery: Query with repeated filter
BigQuery-->>TableUtils: Filtered DataFrame
Test->>Test: Compare collected results from both loads
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (33)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
spark/src/main/scala/ai/chronon/spark/Driver.scala (1)
925-928: Good log addition. Consider including thedateRangeorjoinPartNameto provide richer context in the log for easier tracing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
spark/src/main/scala/ai/chronon/spark/Driver.scala(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
spark/src/main/scala/ai/chronon/spark/Driver.scala (2)
api/src/main/scala/ai/chronon/api/planner/ConfToNode.scala (4)
metaData(134-134)metaData(223-223)metaData(233-233)metaData(243-243)api/src/main/scala/ai/chronon/api/Extensions.scala (1)
outputTable(131-131)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: streaming_tests
- GitHub Check: streaming_tests
- GitHub Check: analyzer_tests
- GitHub Check: join_tests
- GitHub Check: spark_tests
- GitHub Check: groupby_tests
- GitHub Check: join_tests
- GitHub Check: analyzer_tests
- GitHub Check: fetcher_tests
- GitHub Check: spark_tests
- GitHub Check: batch_tests
- GitHub Check: fetcher_tests
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: groupby_tests
- GitHub Check: batch_tests
- GitHub Check: enforce_triggered_workflows
tchow-zlai
requested review from
nikhil-zlai,
varant-zlai,
piyush-zlai and
david-zlai
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (1)
117-126: Good test for partition filter handling.Tests that duplicate partition filters produce identical results.
Consider adding a brief comment explaining why this test is important and its relation to partition filter handling changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (32)
- GitHub Check: service_tests
- GitHub Check: streaming_tests
- GitHub Check: hub_tests
- GitHub Check: spark_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: streaming_tests
- GitHub Check: join_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: groupby_tests
- GitHub Check: join_tests
- GitHub Check: api_tests
- GitHub Check: fetcher_tests
- GitHub Check: online_tests
- GitHub Check: groupby_tests
- GitHub Check: batch_tests
- GitHub Check: flink_tests
- GitHub Check: analyzer_tests
- GitHub Check: analyzer_tests
- GitHub Check: service_commons_tests
- GitHub Check: aggregator_tests
- GitHub Check: spark_tests
- GitHub Check: service_tests
- GitHub Check: fetcher_tests
- GitHub Check: online_tests
- GitHub Check: batch_tests
- GitHub Check: hub_tests
- GitHub Check: flink_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: api_tests
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: aggregator_tests
tchow-zlai
changed the title
tchow-zlai
commented
Apr 19, 2025
| @@ -23,7 +23,7 @@ case object BigQueryNative extends Format { | |||
| dfw.load(bqFriendlyName) | |||
| } else { | |||
| dfw | |||
| .option("filter", partitionFilters.trim.stripPrefix("(").stripSuffix(")")) | |||
| .option("filter", partitionFilters) | |||
There was a problem hiding this comment.
this worked with Etsy prior to the change, but I added a test below (ignored because requires bq connection) to show this is actually correct.
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
force-pushed
the
tchow/more-debugging
branch
from
ee71aad to
f865faa
Compare
Co-authored-by: Thomas Chow <[email protected]>
varant-zlai
approved these changes
Apr 19, 2025
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
## Summary
- Need the full table name here.
- Also test the filter predicate
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved handling of source table names used in join operations,
ensuring more accurate or fully qualified table references.
- Adjusted partition filter handling for BigQuery integration to prevent
unwanted string modifications.
- **Tests**
- Added a new (currently ignored) test for verifying BigQuery partition
pushdown functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary
- Need the full table name here.
- Also test the filter predicate
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved handling of source table names used in join operations,
ensuring more accurate or fully qualified table references.
- Adjusted partition filter handling for BigQuery integration to prevent
unwanted string modifications.
- **Tests**
- Added a new (currently ignored) test for verifying BigQuery partition
pushdown functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
This was referenced Apr 30, 2025
Open
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
- Need the full table name here.
- Also test the filter predicate
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved handling of source table names used in join operations,
ensuring more accurate or fully qualified table references.
- Adjusted partition filter handling for BigQuery integration to prevent
unwanted string modifications.
- **Tests**
- Added a new (currently ignored) test for verifying BigQuery partition
pushdown functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
- Need the full table name here.
- Also test the filter predicate
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved handling of source table names used in join operations,
ensuring more accurate or fully qualified table references.
- Adjusted partition filter handling for BigQuery integration to prevent
unwanted string modifications.
- **Tests**
- Added a new (currently ignored) test for verifying BigQuery partition
pushdown functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary
- Need the full table name here.
- Also test the filter predicate
## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved handling of source table names used in join operations,
ensuring more accurate or fully qualified table references.
- Adjusted partition filter handling for BigQuery integration to prevent
unwanted string modifications.
- **Tests**
- Added a new (currently ignored) test for verifying BigQuery partition
pushdown functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit
Bug Fixes
Tests