fix: get the full table name properly from Driver

[tchow-zlai]

Summary

• refactor: prior to introducing planner #586 did a refactor on the naming of internal tables - we need to update the Driver code to account for this.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of table name parsing by changing the delimiter from a dot to a double underscore when extracting namespace and table name.
  • Updated the method for computing source output table names to enhance accuracy in table identification.

[coderabbitai]

Walkthrough

This update reorganizes import statements within the Driver.scala file for improved conciseness by grouping related imports. It modifies the SourceJobRun.run method by changing the assignment of sourceOutputTable to use JoinUtils.computeFullLeftSourceTableName(join) instead of JoinUtils.computeLeftSourceTableName(join). The subsequent logic splitting the table name string to extract namespace and table name remains unchanged. No public interfaces or method signatures were altered.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/Driver.scala	Consolidated import statements; changed sourceOutputTable assignment in SourceJobRun.run to use JoinUtils.computeFullLeftSourceTableName(join) instead of computeLeftSourceTableName(join).

Possibly related PRs

• Adding verbs for modular join flow to driver #575: Introduced SourceJobRun and modular join flow verbs, modifying the same run method now updated.

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• david-zlai

Poem

Imports grouped with care and grace,
Table names now find their place.
From left to full, the join’s refined,
Cleaner code, a joy to find!
🐇✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between aa90dcb and 57aee18.

📒 Files selected for processing (1)

• spark/src/main/scala/ai/chronon/spark/Driver.scala (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• spark/src/main/scala/ai/chronon/spark/Driver.scala

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: batch_tests
• GitHub Check: spark_tests
• GitHub Check: join_tests
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: fetcher_tests
• GitHub Check: groupby_tests
• GitHub Check: spark_tests
• GitHub Check: batch_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.