chore: pull metrics into its own target #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request restructures the project’s metrics-related code by updating numerous import paths from Changes
Possibly related PRs
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
force-pushed
the
tchow/more-refactor-2
branch
from
9aeb4d2 to
2215dc9
Compare
nikhil-zlai
approved these changes
Apr 7, 2025
piyush-zlai
approved these changes
Apr 7, 2025
| @@ -141,6 +146,7 @@ class Fetcher(val kvStore: KVStore, | |||
| val combinedResponsesF = | |||
| internalResponsesF.zip(externalResponsesF).map { case (internalResponses, externalResponses) => | |||
| internalResponses.zip(externalResponses).map { case (internalResponse, externalResponse) => | |||
| import ai.chronon.online.metrics | |||
There was a problem hiding this comment.
nit - should we just import this at the class level imports?
There was a problem hiding this comment.
whoops missed this
| @@ -44,8 +44,10 @@ class GroupByFetcher(fetchContext: FetchContext, metadataStore: MetadataStore) | |||
| private def toLambdaKvRequest(request: Fetcher.Request): Try[LambdaKvRequest] = metadataStore | |||
| .getGroupByServingInfo(request.name) | |||
| .map { groupByServingInfo => | |||
| import ai.chronon.online.metrics | |||
There was a problem hiding this comment.
we don't need this right?
| @@ -14,13 +14,10 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package ai.chronon.online | |||
| package ai.chronon.online.metrics | |||
There was a problem hiding this comment.
This is used by TTLCache which in turn is used by the Metrics API, so unfortunately this is the simplest way to do the refactor right now. Agree this might live elsewhere, maybe a utils online module that is also slimmer. I will keep here for now and move in a future refactor.
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
force-pushed
the
tchow/more-refactor-2
branch
from
0495e10 to
a500c32
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
online/src/main/scala/ai/chronon/online/fetcher/Fetcher.scala (1)
148-148: Duplicate: consolidate import at class level
🧹 Nitpick comments (3)
online/src/main/scala/ai/chronon/online/fetcher/Fetcher.scala (3)
25-27: Minimize wildcard import usage
45-45: Check local import necessity
65-66: Local import redundancy
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
online/src/main/scala/ai/chronon/online/fetcher/Fetcher.scala(11 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
online/src/main/scala/ai/chronon/online/fetcher/Fetcher.scala (2)
online/src/main/scala/ai/chronon/online/metrics/Metrics.scala (7)
Metrics(24-251)distribution(208-211)distribution(211-214)Name(56-85)Context(87-149)Context(151-250)Environment(25-41)online/src/main/scala/ai/chronon/online/metrics/TTLCache.scala (2)
TTLCache(25-27)TTLCache(32-99)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: streaming_tests
- GitHub Check: streaming_tests
- GitHub Check: analyzer_tests
- GitHub Check: join_tests
- GitHub Check: spark_tests
- GitHub Check: groupby_tests
- GitHub Check: join_tests
- GitHub Check: fetcher_tests
- GitHub Check: groupby_tests
- GitHub Check: analyzer_tests
- GitHub Check: non_spark_tests
- GitHub Check: fetcher_tests
- GitHub Check: batch_tests
- GitHub Check: spark_tests
- GitHub Check: non_spark_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (8)
online/src/main/scala/ai/chronon/online/fetcher/Fetcher.scala (8)
50-50: Looks correct
74-76: Approved
114-114: Good usage
169-169: Good usage
383-383: Fine
426-426: Ok
435-435: All good
479-481: Context initialization looks good
Closed
4 tasks
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
## Summary
- Metrics is actually used in many places, so let's pull it into its own
slim target first.
- Follow up in the spark offline side to further reduce the dep on
online.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Launched a dedicated metrics library to enhance performance monitoring
and reporting.
- **Refactor**
- Consolidated and updated metrics imports and context handling across
services for improved consistency.
- **Tests**
- Aligned test configurations with the new metrics framework to ensure
robust validation.
These improvements streamline performance tracking and dependency
management internally while bolstering the overall reliability of the
application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary
- Metrics is actually used in many places, so let's pull it into its own
slim target first.
- Follow up in the spark offline side to further reduce the dep on
online.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Launched a dedicated metrics library to enhance performance monitoring
and reporting.
- **Refactor**
- Consolidated and updated metrics imports and context handling across
services for improved consistency.
- **Tests**
- Aligned test configurations with the new metrics framework to ensure
robust validation.
These improvements streamline performance tracking and dependency
management internally while bolstering the overall reliability of the
application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
Merged
4 tasks
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
- Metrics is actually used in many places, so let's pull it into its own
slim target first.
- Follow up in the spark offline side to further reduce the dep on
online.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Launched a dedicated metrics library to enhance performance monitoring
and reporting.
- **Refactor**
- Consolidated and updated metrics imports and context handling across
services for improved consistency.
- **Tests**
- Aligned test configurations with the new metrics framework to ensure
robust validation.
These improvements streamline performance tracking and dependency
management internally while bolstering the overall reliability of the
application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary
- Metrics is actually used in many places, so let's pull it into its own
slim target first.
- Follow up in the spark offline side to further reduce the dep on
online.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Launched a dedicated metrics library to enhance performance monitoring
and reporting.
- **Refactor**
- Consolidated and updated metrics imports and context handling across
services for improved consistency.
- **Tests**
- Aligned test configurations with the new metrics framework to ensure
robust validation.
These improvements streamline performance tracking and dependency
management internally while bolstering the overall reliability of the
application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary
- Metrics is actually used in many places, so let's pull it into its own
slim target first.
- Follow up in the spark offline side to further reduce the dep on
online.
## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Launched a dedicated metrics library to enhance performance monitoring
and reporting.
- **Refactor**
- Consolidated and updated metrics imports and context handling across
services for improved consistency.
- **Tests**
- Aligned test configurations with the new metrics framework to ensure
robust validation.
These improvements streamline performance traour clientsing and dependency
management internally while bolstering the overall reliability of the
application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: Thomas Chow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit
These improvements streamline performance tracking and dependency management internally while bolstering the overall reliability of the application.