feat: Make delegating BigQueryMetastore just a SparkCatalog

[tchow-zlai]

Summary

• Do not use the DelegatingBigQueryMetastore as a session catalog, just have it be a custom catalog.

This will change the following configuration set

From:

spark.sql.catalog.spark_catalog.warehouse: "gs://zipline-warehouse-etsy/data/tables/"
spark.sql.catalog.spark_catalog.gcp_location: "us"
spark.sql.catalog.spark_catalog.gcp_project: "etsy-zipline-dev"
spark.sql.catalog.spark_catalog.catalog-impl: org.apache.iceberg.gcp.bigquery.BigQueryMetastoreCatalog
spark.sql.catalog.spark_catalog: ai.chronon.integrations.cloud_gcp.DelegatingBigQueryMetastoreCatalog
spark.sql.catalog.spark_catalog.io-impl: org.apache.iceberg.io.ResolvingFileIO
spark.sql.catalog.default_iceberg:  ai.chronon.integrations.cloud_gcp.DelegatingBigQueryMetastoreCatalog
spark.sql.catalog.default_iceberg.catalog-impl: org.apache.iceberg.gcp.bigquery.BigQueryMetastoreCatalog
spark.sql.catalog.default_iceberg.io-impl: org.apache.iceberg.io.ResolvingFileIO
spark.sql.catalog.default_iceberg.warehouse:  "gs://zipline-warehouse-etsy/data/tables/"
spark.sql.catalog.default_iceberg.gcp_location:  "us"
spark.sql.catalog.default_iceberg.gcp_project: "etsy-zipline-dev"
spark.sql.defaultUrlStreamHandlerFactory.enabled: "false"
spark.kryo.registrator: "ai.chronon.integrations.cloud_gcp.ChrononIcebergKryoRegistrator"

to:

spark.sql.defaultCatalog: "default_iceberg"
spark.sql.catalog.default_iceberg:  "ai.chronon.integrations.cloud_gcp.DelegatingBigQueryMetastoreCatalog"
spark.sql.catalog.default_iceberg.catalog-impl: "org.apache.iceberg.gcp.bigquery.BigQueryMetastoreCatalog"
spark.sql.catalog.default_iceberg.io-impl: "org.apache.iceberg.io.ResolvingFileIO"
spark.sql.catalog.default_iceberg.warehouse:  "gs://zipline-warehouse-etsy/data/tables/"
spark.sql.catalog.default_iceberg.gcp_location:  "us"
spark.sql.catalog.default_iceberg.gcp_project: "etsy-zipline-dev"
spark.sql.defaultUrlStreamHandlerFactory.enabled: "false"
spark.kryo.registrator: "ai.chronon.integrations.cloud_gcp.ChrononIcebergKryoRegistrator"
spark.sql.catalog.default_bigquery: "ai.chronon.integrations.cloud_gcp.DelegatingBigQueryMetastoreCatalog"

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Improved internal table processing by restructuring class integrations and enhancing error messaging when a table isn’t found.
• Tests
  • Updated integration settings and adjusted reference parameters to ensure validations remain aligned with the new catalog implementation.

[coderabbitai]

Walkthrough

The pull request refactors the DelegatingBigQueryMetastoreCatalog by changing its inheritance from CatalogExtension to implement TableCatalog, SupportsNamespaces, and FunctionCatalog. It removes the defaultSessionCatalog variable and its setter, and now directly throws a NoSuchTableException if a table is absent, removing redundant fallback logic and obsolete comments. Additionally, test configuration is updated in BigQueryCatalogTest.scala to reference the new catalog implementation and adjust the designated native table.

Changes

File	Change Summary
cloud_gcp/src/.../DelegatingBigQueryMetastoreCatalog.scala	Updated class to extend multiple interfaces instead of CatalogExtension; removed defaultSessionCatalog and setter; modified table loading to throw NoSuchTableException; cleaned up outdated comments.
cloud_gcp/src/test/scala/.../BigQueryCatalogTest.scala	Replaced catalog reference from SparkCatalog to DelegatingBigQueryMetastoreCatalog; updated nativeTable variable from "data.sample_native" to "data.checkouts".

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• david-zlai

Poem

In code we trust, improvements shine bright,
Catalogs updated with a new guiding light.
Errors now clear, exceptions precise,
Tests align, making updates nice.
Cheers to clean code—rock on day and night!
🚀✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (1)

44-44: Consider removing commented-out code
This line is commented out. If not needed, remove it for clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 965c46a and 946efe6.

📒 Files selected for processing (2)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala (3 hunks)
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: scala_compile_fmt_fix
• GitHub Check: non_spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (3)

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (1)

98-98: Confirm new table reference
Ensure "data.checkouts" is correct and accessible in this environment.

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala (2)

81-81: Catalog interface extension looks correct
Replacing CatalogExtension with TableCatalog + SupportsNamespaces + FunctionCatalog aligns with Spark best practices.

---

162-162: Throwing NoSuchTableException
Ensure callers handle this exception to avoid unexpected runtime errors.

[tchow-zlai]

tested on Etsy

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala (2)

67-80: Update class documentation.

Documentation still references fallback behavior that's been removed.

---

162-162: Fix typo in error message.

"Tgable" should be "Table".

-      .getOrElse(throw new NoSuchTableException(f"Tgable: ${ident} not found in bigquery catalog."))
+      .getOrElse(throw new NoSuchTableException(f"Table: ${ident} not found in bigquery catalog."))

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 1973531 and c53ab75.

📒 Files selected for processing (1)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: non_spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (2)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala (2)

81-81: Interface change aligned with PR objective.

Implementing specific catalog interfaces directly rather than extending CatalogExtension properly refactors this into a standalone catalog.

---

23-23: Necessary import for new error handling.