-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Set iceberg table options through table properties #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Caller
participant T as TableUtils
participant S as SQL Engine
C->>T: Call insertPartitions(data, tableProperties)
T->>T: Check if tableProperties are provided
alt tableProperties valid
T->>S: Execute ALTER SQL via alterTablePropertiesSql
else
Note right of T: Skip altering properties
end
T->>C: Continue partition insertion
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (14)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Thomas Chow <[email protected]>
1803e4c
to
dedfde0
Compare
Co-authored-by: Thomas Chow <[email protected]>
## Summary - We want users to be able to specify write options. In the case of iceberg tables, these can be set at the table level through table properties. The chronon API already supports table properties, so let's just ride on those rails. - Users can set write distribution options through this mechanism: https://iceberg.apache.org/docs/latest/spark-writes/#writing-distribution-modes ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic updates of table properties during partition insertions, offering more flexible table management. - **Refactor** - Streamlined table write operations by removing legacy configuration options to simplify data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - We want users to be able to specify write options. In the case of iceberg tables, these can be set at the table level through table properties. The chronon API already supports table properties, so let's just ride on those rails. - Users can set write distribution options through this mechanism: https://iceberg.apache.org/docs/latest/spark-writes/#writing-distribution-modes ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic updates of table properties during partition insertions, offering more flexible table management. - **Refactor** - Streamlined table write operations by removing legacy configuration options to simplify data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - We want users to be able to specify write options. In the case of iceberg tables, these can be set at the table level through table properties. The chronon API already supports table properties, so let's just ride on those rails. - Users can set write distribution options through this mechanism: https://iceberg.apache.org/docs/latest/spark-writes/#writing-distribution-modes ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic updates of table properties during partition insertions, offering more flexible table management. - **Refactor** - Streamlined table write operations by removing legacy configuration options to simplify data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - We want users to be able to specify write options. In the case of iceberg tables, these can be set at the table level through table properties. The chronon API already supports table properties, so let's just ride on those rails. - Users can set write distribution options through this mechanism: https://iceberg.apache.org/docs/latest/spark-writes/#writing-distribution-modes ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic updates of table properties during partition insertions, offering more flexible table management. - **Refactor** - Streamlined table write operations by removing legacy configuration options to simplify data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - We want users to be able to specify write options. In the case of iceberg tables, these can be set at the table level through table properties. The chronon API already supports table properties, so let's just ride on those rails. - Users can set write distribution options through this mechanism: https://iceberg.apache.org/docs/latest/spark-writes/#writing-distribution-modes ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enabled dynamic updates of table properties during partition insertions, offering more flexible table management. - **Refactor** - Streamlined table write operations by removing legacy configuration options to simplify data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
Summary
Checklist
Summary by CodeRabbit