Skip to content

Point GCP to build and upload to release/latest as well. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

david-zlai
Copy link
Contributor

@david-zlai david-zlai commented Mar 14, 2025

Summary

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Revised the upload process so that release artifacts are now organized into distinct directories based on their type. This update separates application packages into dedicated folders, ensuring a more orderly and reliable distribution of the latest releases.

@david-zlai david-zlai requested a review from chewy-zlai March 14, 2025 21:16
Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

This update modifies the upload_to_gcp function within the build and upload script. The JAR file upload path has been updated to use /release/latest/jars/, and a new path for wheel files /release/latest/wheels/ has been introduced. Commands were updated to reflect these changes. The overall control flow remains unchanged.

Changes

File(s) Change Summary
scripts/distribution/build_and_upload_artifacts.sh Updated upload paths in upload_to_gcp: JAR uploads now use /release/latest/jars/, and wheel uploads use a new /release/latest/wheels/. Commands updated accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Script as Build Script
    participant GCS as Google Cloud Storage
    Script->>GCS: Upload JAR artifact to gs://zipline-artifacts-$element/release/latest/jars/
    Script->>GCS: Upload Wheel artifact to gs://zipline-artifacts-$element/release/latest/wheels/
Loading

Possibly related PRs

Suggested reviewers

  • chewy-zlai
  • tchow-zlai

Poem

In coded paths, a change takes flight,
JARs and wheels now set just right.
New directories gleam with latest art,
A smoother flow – a fresh new start!
Celebrate the shift, let changes ignite!
🚀✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 3fcdea2 and a7b2cc2.

📒 Files selected for processing (1)
  • scripts/distribution/build_and_upload_artifacts.sh (1 hunks)
🔇 Additional comments (2)
scripts/distribution/build_and_upload_artifacts.sh (2)

187-188: GCP paths updated.
New paths correctly use release/latest for JARs and wheels.


191-192: Wheel upload cmds fixed.
Wheel uploads now target the release/latest/wheels directory.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@david-zlai david-zlai merged commit 965c46a into main Mar 14, 2025
4 checks passed
@david-zlai david-zlai deleted the davidhan/update_build_script.sh branch March 14, 2025 21:18
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Revised the upload process so that release artifacts are now organized
into distinct directories based on their type. This update separates
application packages into dedicated folders, ensuring a more orderly and
reliable distribution of the latest releases.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants