Skip to content

Also push the old wheel name to GCP #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

david-zlai
Copy link
Contributor

@david-zlai david-zlai commented Mar 5, 2025

Summary

Previously in this change 9901878 I had us push the old wheel name for etsy to AWS but forgot to also do the same for GCP

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features
    • Expanded the distribution process to include an additional legacy package artifact upload. This update integrates enhanced metadata tracking (e.g., timestamps and commit references) to ensure improved traceability and auditability while maintaining consistency with existing deployments. These improvements contribute to a smoother and more reliable update experience for end-users.

@david-zlai david-zlai requested a review from piyush-zlai March 5, 2025 14:29
Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

This update adds a command within the upload_to_gcp function of the scripts/distribution/build_and_upload_artifacts.sh script. The new command uploads an old Zipline wheel file (OLD_ZIPLINE_WHEEL_NAME) to GCP storage using the gcloud storage cp command with custom metadata. No changes were made to exported or public entities.

Changes

Files Change Summary
scripts/distribution/build_and_upload_artifacts.sh Added a command in upload_to_gcp to upload an old version of the Zipline wheel file with custom metadata via gcloud storage cp

Sequence Diagram(s)

sequenceDiagram
    participant S as Script
    participant U as upload_to_gcp
    participant G as Google Cloud Storage

    S->>U: Invoke upload_to_gcp()
    U->>G: gcloud storage cp (current wheel + metadata)
    U->>G: gcloud storage cp (old wheel + metadata)
    G-->>U: Confirmation responses
    U-->>S: Return success
Loading

Possibly related PRs

Suggested reviewers

  • chewy-zlai
  • tchow-zlai

Poem

In the realm of code, a new command shines,
Old wheels now take flight with metadata lines.
A swift script update, precise and true,
GCP receives both the old and the new.
Code flows like a river—fresh and cool!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f6640de and c00ab63.

📒 Files selected for processing (1)
  • scripts/distribution/build_and_upload_artifacts.sh (1 hunks)
🔇 Additional comments (1)
scripts/distribution/build_and_upload_artifacts.sh (1)

203-203: GCP old wheel upload added.
The new command mirrors the AWS upload and correctly pushes the legacy wheel. Ensure that $OLD_ZIPLINE_WHEEL_NAME exists as expected.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@david-zlai david-zlai requested a review from tchow-zlai March 5, 2025 14:29
@david-zlai david-zlai merged commit 44d1d47 into main Mar 5, 2025
4 checks passed
@david-zlai david-zlai deleted the davidhan/push_old_wheel_gcs branch March 5, 2025 14:53
david-zlai added a commit that referenced this pull request Mar 5, 2025
## Summary
Previously in this change
9901878
I had us push the old wheel name for etsy to AWS but forgot to also do
the same for GCP

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded the distribution process to include an additional legacy
package artifact upload. This update integrates enhanced metadata
tracking (e.g., timestamps and commit references) to ensure improved
traceability and auditability while maintaining consistency with
existing deployments. These improvements contribute to a smoother and
more reliable update experience for end-users.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2025
4 tasks
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary
Previously in this change
2a13f94
I had us push the old wheel name for etsy to AWS but forgot to also do
the same for GCP

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded the distribution process to include an additional legacy
package artifact upload. This update integrates enhanced metadata
tracking (e.g., timestamps and commit references) to ensure improved
traceability and auditability while maintaining consistency with
existing deployments. These improvements contribute to a smoother and
more reliable update experience for end-users.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants