-
Notifications
You must be signed in to change notification settings - Fork 0
Also push the old wheel name to GCP #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update adds a command within the Changes
Sequence Diagram(s)sequenceDiagram
participant S as Script
participant U as upload_to_gcp
participant G as Google Cloud Storage
S->>U: Invoke upload_to_gcp()
U->>G: gcloud storage cp (current wheel + metadata)
U->>G: gcloud storage cp (old wheel + metadata)
G-->>U: Confirmation responses
U-->>S: Return success
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
## Summary Previously in this change 9901878 I had us push the old wheel name for etsy to AWS but forgot to also do the same for GCP ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Expanded the distribution process to include an additional legacy package artifact upload. This update integrates enhanced metadata tracking (e.g., timestamps and commit references) to ensure improved traceability and auditability while maintaining consistency with existing deployments. These improvements contribute to a smoother and more reliable update experience for end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Previously in this change 2a13f94 I had us push the old wheel name for etsy to AWS but forgot to also do the same for GCP ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Expanded the distribution process to include an additional legacy package artifact upload. This update integrates enhanced metadata tracking (e.g., timestamps and commit references) to ensure improved traceability and auditability while maintaining consistency with existing deployments. These improvements contribute to a smoother and more reliable update experience for end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Previously in this change 9901878 I had us push the old wheel name for etsy to AWS but forgot to also do the same for GCP
Checklist
Summary by CodeRabbit