Skip to content

chore: break out bazel targets #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: break out bazel targets #510

wants to merge 2 commits into from

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented Mar 14, 2025

Summary

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features

    • Introduced a new Scala library to enhance functionality and organization within the project.
  • Refactor

    • Updated package structures for improved organization and consolidated import statements for better readability across multiple files.

Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

This pull request introduces a new Scala library target named lib in the Bazel build configuration for the spark stats module. The target aggregates all Scala source files using a glob and applies conditional formatting based on Scala versions. Additionally, several import statements in various Scala files have been consolidated for clarity and organization, with no modifications to public API declarations.

Changes

File Change Summary
spark/.../stats/BUILD.bazel Added new scala_library target lib that includes all Scala sources, uses conditional formatting (disabled for Scala 2.13), and adds dependencies on //api:lib, //online:lib, and //tools/build_rules/spark:spark-exec.
spark/.../stats/CompareBaseJob.scala Consolidated import statements: replaced specific package imports with a wildcard import for ai.chronon.online and merged separate imports for TableUtils, TimedKvRdd, Logger, and LoggerFactory.
spark/.../stats/DataServer.scala Changed package from ai.chronon.spark.scripts to ai.chronon.spark.stats and consolidated import statements for better organization.
spark/.../stats/ObservabilityDemo.scala Changed package from ai.chronon.spark.scripts to ai.chronon.spark.stats and reorganized import statements for clarity.
spark/.../stats/ObservabilityDemoDataLoader.scala Changed package from ai.chronon.spark.scripts to ai.chronon.spark.stats and consolidated import statements for improved readability.

Possibly related PRs

Suggested reviewers

  • nikhil-zlai
  • piyush-zlai
  • varant-zlai

Poem

A new library lights up the code,
Imports merge on a streamlined road,
Bazel scripts sing in structured style,
Code paths align, mile after mile,
CodeRabbit’s crew crafts magic with a smile! 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 3f8b633 and dc8fdf3.

📒 Files selected for processing (3)
  • spark/src/main/scala/ai/chronon/spark/stats/DataServer.scala (1 hunks)
  • spark/src/main/scala/ai/chronon/spark/stats/ObservabilityDemo.scala (1 hunks)
  • spark/src/main/scala/ai/chronon/spark/stats/ObservabilityDemoDataLoader.scala (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • spark/src/main/scala/ai/chronon/spark/stats/DataServer.scala
  • spark/src/main/scala/ai/chronon/spark/stats/ObservabilityDemoDataLoader.scala
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: streaming_tests
  • GitHub Check: streaming_tests
  • GitHub Check: join_tests
  • GitHub Check: analyzer_tests
  • GitHub Check: spark_tests
  • GitHub Check: spark_tests
  • GitHub Check: fetcher_tests
  • GitHub Check: analyzer_tests
  • GitHub Check: scala_compile_fmt_fix
🔇 Additional comments (1)
spark/src/main/scala/ai/chronon/spark/stats/ObservabilityDemo.scala (1)

1-19: Clean import reorganization.

Imports properly consolidated by package origin, improving readability.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Co-authored-by: Thomas Chow <[email protected]>
@tchow-zlai tchow-zlai marked this pull request as draft March 14, 2025 17:31
@tchow-zlai tchow-zlai closed this Apr 12, 2025
@tchow-zlai tchow-zlai deleted the tchow/slim-bazel branch April 12, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant