-
Notifications
You must be signed in to change notification settings - Fork 0
feat: upgrade artifact upload to use bazel #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request introduces updates to JAR file configurations across several files. Key changes include modifications to default JAR file names in Changes
Possibly related PRs
Suggested Reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
distribution/build_and_upload_gcp_artifacts.sh (1)
45-49
: Consider full migration to Bazel.Script uses mixed build tools (sbt and Bazel). Consider migrating all builds to Bazel for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (3)
api/py/ai/chronon/repo/run.py
(1 hunks)cloud_gcp/BUILD.bazel
(2 hunks)distribution/build_and_upload_gcp_artifacts.sh
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- api/py/ai/chronon/repo/run.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: no_spark_scala_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (4)
cloud_gcp/BUILD.bazel (2)
39-43
: LGTM! Clean Bazel target configuration.The submitter binary target is properly configured with correct main class and dependencies.
44-44
: LGTM! Improved readability.Blank lines enhance code organization.
Also applies to: 90-90
distribution/build_and_upload_gcp_artifacts.sh (2)
45-46
: LGTM! Proper Bazel build commands.Correctly builds both lib and submitter JARs.
48-49
: LGTM! Updated JAR paths.Paths correctly point to Bazel output directory.
api/py/ai/chronon/repo/run.py
Outdated
@@ -130,10 +130,10 @@ | |||
|
|||
# GCP DATAPROC SPECIFIC CONSTANTS | |||
DATAPROC_ENTRY = "ai.chronon.integrations.cloud_gcp.DataprocSubmitter" | |||
ZIPLINE_ONLINE_JAR_DEFAULT = "cloud_gcp-assembly-0.1.0-SNAPSHOT.jar" | |||
ZIPLINE_ONLINE_JAR_DEFAULT = "lib_deploy.jar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: more descriptive jar name. (i realize that we need to change bazel file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
83a9cdc
to
53dde61
Compare
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jackson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jackson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jackson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jackson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jackson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow. ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated default JAR file names for online and Dataproc submissions. - Migrated build process from `sbt` to `bazel` for GCP artifact generation. - Added new `submitter` binary target for Dataproc submission. - Added dependency for Scala-specific features of the Jaour clientsson library in the online library. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
Summary
Checklist
Summary by CodeRabbit
sbt
tobazel
for GCP artifact generation.submitter
binary target for Dataproc submission.