Skip to content

feat: upgrade artifact upload to use bazel #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented Feb 1, 2025

Summary

  • This migrates over our artifact upload + run.py to leverage bazel-built jars. Only for the batch side for now, streaming will follow.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Updated default JAR file names for online and Dataproc submissions.
    • Migrated build process from sbt to bazel for GCP artifact generation.
    • Added new submitter binary target for Dataproc submission.
    • Added dependency for Scala-specific features of the Jackson library in the online library.

Copy link

coderabbitai bot commented Feb 1, 2025

Walkthrough

The pull request introduces updates to JAR file configurations across several files. Key changes include modifications to default JAR file names in run.py, the addition of a new Bazel build target for a submitter binary, and a transition of the build process for GCP artifacts from SBT to Bazel. These changes aim to refine the deployment and build processes for the application's GCP-related components.

Changes

File Change Summary
api/py/ai/chronon/repo/run.py Updated default JAR file constants:
- ZIPLINE_ONLINE_JAR_DEFAULT: "cloud_gcp-assembly-0.1.0-SNAPSHOT.jar""cloud_gcp_lib_deploy.jar"
- ZIPLINE_DATAPROC_SUBMITTER_JAR: "cloud_gcp_submitter-assembly-0.1.0-SNAPSHOT.jar""cloud_gcp_submitter_deploy.jar"
cloud_gcp/BUILD.bazel Renamed targets and added new jvm_binary target cloud_gcp_submitter with main class ai.chronon.integrations.cloud_gcp.DataprocSubmitter.
distribution/build_and_upload_gcp_artifacts.sh Replaced SBT build commands with Bazel build commands for JAR files, updating paths accordingly.
online/BUILD.bazel Added dependency: scala_artifact("com.fasterxml.jackson.module:jackson-module-scala") to scala_library named lib.

Possibly related PRs

Suggested Reviewers

  • nikhil-zlai
  • piyush-zlai
  • kumar-zlai

Poem

🚀 Jars of code, now renamed with grace,

Bazel builds, a swifter pace

From SBT's old familiar tune

To deployment's newest boon

Refactoring's gentle embrace! 🌟

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 83a9cdc and 53dde61.

📒 Files selected for processing (4)
  • api/py/ai/chronon/repo/run.py (1 hunks)
  • cloud_gcp/BUILD.bazel (3 hunks)
  • distribution/build_and_upload_gcp_artifacts.sh (1 hunks)
  • online/BUILD.bazel (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • cloud_gcp/BUILD.bazel
  • api/py/ai/chronon/repo/run.py
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: enforce_triggered_workflows
  • GitHub Check: no_spark_scala_tests
  • GitHub Check: build-and-push
🔇 Additional comments (3)
distribution/build_and_upload_gcp_artifacts.sh (2)

45-47: Bazel build commands.
Replaces sbt with bazel to build JARs. Verify Bazel is available.


48-49: Updated JAR paths.
Paths now point to bazel-bin; ensure these output locations are correct.

online/BUILD.bazel (1)

21-21: LGTM! Verify Jackson module compatibility.

✅ Verification successful

Jackson module dependency verified!

  • Found imports in multiple Scala files indicating proper usage.
  • No conflicting Jackson version declarations detected.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Jackson module compatibility with other Jackson dependencies

# Search for Jackson version declarations in workspace files
rg -A 1 'com\.fasterxml\.jackson' --glob 'WORKSPACE*' --glob 'dependencies.bzl'

# Search for Jackson imports to ensure the module is needed
rg 'import.*jackson.*module.*scala' --type scala

Length of output: 626


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
distribution/build_and_upload_gcp_artifacts.sh (1)

45-49: Consider full migration to Bazel.

Script uses mixed build tools (sbt and Bazel). Consider migrating all builds to Bazel for consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4fef52c and 83a9cdc.

📒 Files selected for processing (3)
  • api/py/ai/chronon/repo/run.py (1 hunks)
  • cloud_gcp/BUILD.bazel (2 hunks)
  • distribution/build_and_upload_gcp_artifacts.sh (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • api/py/ai/chronon/repo/run.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: no_spark_scala_tests
  • GitHub Check: enforce_triggered_workflows
🔇 Additional comments (4)
cloud_gcp/BUILD.bazel (2)

39-43: LGTM! Clean Bazel target configuration.

The submitter binary target is properly configured with correct main class and dependencies.


44-44: LGTM! Improved readability.

Blank lines enhance code organization.

Also applies to: 90-90

distribution/build_and_upload_gcp_artifacts.sh (2)

45-46: LGTM! Proper Bazel build commands.

Correctly builds both lib and submitter JARs.


48-49: LGTM! Updated JAR paths.

Paths correctly point to Bazel output directory.

@@ -130,10 +130,10 @@

# GCP DATAPROC SPECIFIC CONSTANTS
DATAPROC_ENTRY = "ai.chronon.integrations.cloud_gcp.DataprocSubmitter"
ZIPLINE_ONLINE_JAR_DEFAULT = "cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"
ZIPLINE_ONLINE_JAR_DEFAULT = "lib_deploy.jar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: more descriptive jar name. (i realize that we need to change bazel file)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tchow-zlai and others added 2 commits February 1, 2025 00:00
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
@tchow-zlai tchow-zlai merged commit dc789a2 into main Feb 3, 2025
6 checks passed
@tchow-zlai tchow-zlai deleted the tchow/bazel-cleanup branch February 3, 2025 19:28
nikhil-zlai pushed a commit that referenced this pull request Feb 4, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jackson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Mar 14, 2025
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Apr 17, 2025
4 tasks
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jackson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jackson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jackson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jackson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary
- This migrates over our artifact upload + run.py to leverage
bazel-built jars. Only for the batch side for now, streaming will
follow.

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated default JAR file names for online and Dataproc submissions.
- Migrated build process from `sbt` to `bazel` for GCP artifact
generation.
	- Added new `submitter` binary target for Dataproc submission.
- Added dependency for Scala-specific features of the Jaour clientsson library in
the online library.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants