-
Notifications
You must be signed in to change notification settings - Fork 0
fix: adjust classpath so flink side can work #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request removes the Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ef2c09d
to
f9910e2
Compare
2fc0c17
to
63347cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like we potentially still need to iterate here. I'm consistently seeing the Flink UI being partially broken. I see the job running (via logs, checkpoints and kv store write metrics) but we're not able to look at the DAG view and explore. The UI seems to think that - "Job is not running yet". We do need the UI functional for a lot of debugging / diagnostic stuff so we should resolve..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flink wise the current version now looks good. We had to add commons-text to exclusions as the execution graph wasn't being loaded (and hence that api was returning no rows) - 2025-03-06 18:25:46,729 WARN org.apache.flink.runtime.jobmaster.JobMaster [] - Cannot create JSON plan for job java.lang.NoSuchMethodError: 'org.apache.commons.lang3.Range org.apache.commons.lang3.Range.of(java.lang.Comparable, java.lang.Comparable)'
@@ -17,6 +17,8 @@ maven_repository = repository( | |||
"org.mockito:mockito-core:5.12.0", | |||
"org.objenesis:objenesis:3.4", | |||
|
|||
"org.eclipse.jetty:jetty-util:12.0.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @piyush-zlai
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
This reverts commit 6bd4367. Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
cec50fb
to
4ed76c6
Compare
Co-authored-by: Thomas Chow <[email protected]>
maven_artifact("org.apache.hadoop:hadoop-client-api"), | ||
maven_artifact("org.apache.hadoop:hadoop-yarn-api"), | ||
maven_artifact("org.eclipse.jetty:jetty-util"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @piyush-zlai brought in jetty-util from maven repo, to get around the java compat issue.
## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed legacy resource management components. - Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty. - Upgraded several third-party libraries to enhance compatibility and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Piyush Narang <[email protected]>
## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed legacy resource management components. - Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty. - Upgraded several third-party libraries to enhance compatibility and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Piyush Narang <[email protected]>
## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed legacy resource management components. - Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty. - Upgraded several third-party libraries to enhance compatibility and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Piyush Narang <[email protected]>
## Summary ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed legacy resource management components. - Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty. - Upgraded several third-party libraries to enhance compatibility and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Piyush Narang <[email protected]>
## Summary ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed legacy resource management components. - Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty. - Upgraded several third-party libraries to enhance compatibility and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Piyush Narang <[email protected]>
Summary
Checklist
Summary by CodeRabbit