Skip to content

fix: adjust classpath so flink side can work #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented Mar 6, 2025

Summary

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Removed legacy resource management components.
    • Updated dependency configurations by excluding outdated libraries and incorporating essential new ones, including new dependencies for Hadoop and Jetty.
    • Upgraded several third-party libraries to enhance compatibility and maintainability.

Copy link

coderabbitai bot commented Mar 6, 2025

Walkthrough

The pull request removes the org.apache.hadoop.yarn.api package along with its associated classes and methods. It updates dependency management across the repository, adding exclusion rules in the Spark repository setup, incorporating new Maven artifacts in the Flink build, and revising artifact hashes, versions, and exclusions in Maven-related files.

Changes

File(s) Change Summary
spark_install.json Removed Hadoop YARN API classes, records, exceptions, timeline entities, and builders.
tools/build_rules/dependencies/spark_repository.bzl,
tools/build_rules/dependencies/maven_repository.bzl
Updated dependency configuration: added an exclusion for org.apache.hadoop:hadoop-yarn-api in the Spark repository; added jetty-util, hadoop-yarn-api, and hadoop-yarn-common in the Maven repository while adjusting exclusions (e.g., excluding commons-text).
flink/BUILD.bazel Introduced new Maven artifacts for hadoop-common, hadoop-yarn-api, and jetty-util in both main and test dependency sections.
maven_install.json Updated artifact SHA sums and versions; added new Jackson (jaxrs-base, jaxrs-json-provider, module-jaxb-annotations) and Hadoop artifacts; removed org.apache.commons:commons-text.

Possibly related PRs

Suggested reviewers

  • nikhil-zlai
  • piyush-zlai
  • varant-zlai

Poem

In code we shed an aging thread,
YARN APIs laid quietly to bed.
Dependencies updated, crisp and bright,
New artifacts join the build’s light.
CodeRabbit cheers with every byte!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4ed76c6 and c6849f6.

📒 Files selected for processing (1)
  • spark_install.json (8 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: non_spark_tests
  • GitHub Check: bazel_config_tests
  • GitHub Check: non_spark_tests
🔇 Additional comments (8)
spark_install.json (8)

3-4: Auto-generated hash updates.


2010-2011: New reporter deps added.


2113-2113: Netty native unix dependency added.


2415-2416: Added hive-shims-common and slf4j-api to scheduler.


2428-2438: Multiple new dependencies added. Verify necessity.


2482-2482: Added opencsv to hive-serde.


2495-2496: Hive shims updated with scheduler and slf4j-api.


2915-2916: Libthrift deps updated with httpcore and slf4j-api.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tchow-zlai tchow-zlai marked this pull request as draft March 6, 2025 01:00
@tchow-zlai tchow-zlai marked this pull request as ready for review March 6, 2025 06:24
Copy link
Contributor

@piyush-zlai piyush-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like we potentially still need to iterate here. I'm consistently seeing the Flink UI being partially broken. I see the job running (via logs, checkpoints and kv store write metrics) but we're not able to look at the DAG view and explore. The UI seems to think that - "Job is not running yet". We do need the UI functional for a lot of debugging / diagnostic stuff so we should resolve..

Copy link
Contributor

@piyush-zlai piyush-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flink wise the current version now looks good. We had to add commons-text to exclusions as the execution graph wasn't being loaded (and hence that api was returning no rows) - 2025-03-06 18:25:46,729 WARN org.apache.flink.runtime.jobmaster.JobMaster [] - Cannot create JSON plan for job java.lang.NoSuchMethodError: 'org.apache.commons.lang3.Range org.apache.commons.lang3.Range.of(java.lang.Comparable, java.lang.Comparable)'

@@ -17,6 +17,8 @@ maven_repository = repository(
"org.mockito:mockito-core:5.12.0",
"org.objenesis:objenesis:3.4",

"org.eclipse.jetty:jetty-util:12.0.16",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tchow-zlai and others added 7 commits March 6, 2025 12:36
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
This reverts commit 6bd4367.

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
maven_artifact("org.apache.hadoop:hadoop-client-api"),
maven_artifact("org.apache.hadoop:hadoop-yarn-api"),
maven_artifact("org.eclipse.jetty:jetty-util"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @piyush-zlai brought in jetty-util from maven repo, to get around the java compat issue.

@tchow-zlai tchow-zlai merged commit a28fe2d into main Mar 6, 2025
6 of 9 checks passed
@tchow-zlai tchow-zlai deleted the tchow/yarn-api-cp branch March 6, 2025 21:05
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Removed legacy resource management components.
- Updated dependency configurations by excluding outdated libraries and
incorporating essential new ones, including new dependencies for Hadoop
and Jetty.
- Upgraded several third-party libraries to enhance compatibility and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Piyush Narang <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Removed legacy resource management components.
- Updated dependency configurations by excluding outdated libraries and
incorporating essential new ones, including new dependencies for Hadoop
and Jetty.
- Upgraded several third-party libraries to enhance compatibility and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Piyush Narang <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Removed legacy resource management components.
- Updated dependency configurations by excluding outdated libraries and
incorporating essential new ones, including new dependencies for Hadoop
and Jetty.
- Upgraded several third-party libraries to enhance compatibility and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Piyush Narang <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Removed legacy resource management components.
- Updated dependency configurations by excluding outdated libraries and
incorporating essential new ones, including new dependencies for Hadoop
and Jetty.
- Upgraded several third-party libraries to enhance compatibility and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Piyush Narang <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Removed legacy resource management components.
- Updated dependency configurations by excluding outdated libraries and
incorporating essential new ones, including new dependencies for Hadoop
and Jetty.
- Upgraded several third-party libraries to enhance compatibility and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Piyush Narang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants