fix: downgrade jetty version so that we don't run into jdk compat issues when running streaming #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Chow <[email protected]>
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (3)
flink/BUILD.bazel(0 hunks)maven_install.json(5 hunks)tools/build_rules/dependencies/maven_repository.bzl(1 hunks)
💤 Files with no reviewable changes (1)
- flink/BUILD.bazel
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: non_spark_tests
- GitHub Check: non_spark_tests
- GitHub Check: bazel_config_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (5)
maven_install.json (5)
1-7: Hashes updated; verify auto-generated values.
6129-6135: Added hadoop-common dependency.
Ensure no duplication or conflicts across modules.
6180-6186: Hadoop-common added in hbase-http deps.
Confirm this redundant declaration is intentional.
6472-6478: Jackson-module-afterburner added.
Verify its version meets requirements.
6599-6606: Logback dependencies added to twill-zookeeper.
Confirm proper integration with existing deps.
| @@ -141,6 +140,7 @@ maven_repository = repository( | |||
| "org.apache.zookeeper:zookeeper", | |||
| "org.scala-lang:scala-library", | |||
| "org.scala-lang:scala-reflect", | |||
| "org.eclipse.jetty:jetty-util" | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Added jetty-util to exclusion list.
Exclusion aligns with removed dependency in other files. Consider adding comment explaining exclusion reason for future clarity.
🏁 Script executed:
#!/bin/bash
# Search for any remaining jetty-util usage
rg "jetty-util" --type bazel --type javaLength of output: 131
Action: Add clarifying inline comment for jetty-util exclusion.
- File:
tools/build_rules/dependencies/maven_repository.bzl - Issue:
"org.eclipse.jetty:jetty-util"is the sole instance; exclusion aligns with other removals. - Recommendation: Add an inline comment briefly explaining the rationale for excluding jetty-util.
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
changed the title
nikhil-zlai
approved these changes
Mar 7, 2025
| @@ -17,7 +17,7 @@ maven_repository = repository( | |||
| "org.mockito:mockito-core:5.12.0", | |||
| "org.objenesis:objenesis:3.4", | |||
|
|
|||
| "org.eclipse.jetty:jetty-util:12.0.16", | |||
| "org.eclipse.jetty:jetty-util:9.4.57.v20241219", # latest version that is still built on jdk 11 and not 17. | |||
piyush-zlai
approved these changes
Mar 7, 2025
Merged
4 tasks
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
…ues when running streaming (#484) ## Summary - Running into: ``` SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "grpc-default-executor-0" java.lang.UnsupportedClassVersionError: org/eclipse/jetty/util/DateCache has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451) at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:71) at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:51) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ``` When submitting Flink jobs. So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded several core dependencies, including AWS components and Jetty libraries for improved performance and compatibility. - Updated internal artifact configurations and versioning for smoother dependency management. - Introduced new dependencies to enhance functionality, including the AWS SDK's URL connection client. - Removed an outdated Maven artifact dependency to streamline library management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
…ues when running streaming (#484) ## Summary - Running into: ``` SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "grpc-default-executor-0" java.lang.UnsupportedClassVersionError: org/eclipse/jetty/util/DateCache has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451) at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:71) at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:51) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ``` When submitting Flink jobs. So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded several core dependencies, including AWS components and Jetty libraries for improved performance and compatibility. - Updated internal artifact configurations and versioning for smoother dependency management. - Introduced new dependencies to enhance functionality, including the AWS SDK's URL connection client. - Removed an outdated Maven artifact dependency to streamline library management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
…ues when running streaming (#484) ## Summary - Running into: ``` SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "grpc-default-executor-0" java.lang.UnsupportedClassVersionError: org/eclipse/jetty/util/DateCache has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451) at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:71) at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:51) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ``` When submitting Flink jobs. So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded several core dependencies, including AWS components and Jetty libraries for improved performance and compatibility. - Updated internal artifact configurations and versioning for smoother dependency management. - Introduced new dependencies to enhance functionality, including the AWS SDK's URL connection client. - Removed an outdated Maven artifact dependency to streamline library management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
…ues when running streaming (#484) ## Summary - Running into: ``` SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "grpc-default-executor-0" java.lang.UnsupportedClassVersionError: org/eclipse/jetty/util/DateCache has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451) at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:71) at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:51) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ``` When submitting Flink jobs. So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded several core dependencies, including AWS components and Jetty libraries for improved performance and compatibility. - Updated internal artifact configurations and versioning for smoother dependency management. - Introduced new dependencies to enhance functionality, including the AWS SDK's URL connection client. - Removed an outdated Maven artifact dependency to streamline library management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
…ues when running streaming (#484) ## Summary - Running into: ``` SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Exception in thread "grpc-default-executor-0" java.lang.UnsupportedClassVersionError: org/eclipse/jetty/util/DateCache has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458) at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451) at org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:71) at org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:51) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ``` When submitting Flink jobs. So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version. ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded several core dependencies, including AWS components and Jetty libraries for improved performance and compatibility. - Updated internal artifact configurations and versioning for smoother dependency management. - Introduced new dependencies to enhance functionality, including the AWS SDK's URL connection client. - Removed an outdated Maven artifact dependency to streamline library management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When submitting Flink jobs.
So downgrading jetty helps. However, there's a conflict with dynamodblocal so I had to downgrade that too to be compatible with an older jetty version.
Checklist
Summary by CodeRabbit