fix: support non-string types for iceberg partition listing

[tchow-zlai]

Summary

• Everywhere else we want to handle partitions that could be non-string types. This is similar to the change in:

  chronon/cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala

  Lines 122 to 128 in 3d2e77d

  	date_format(
  	to_date(
  	col("partition_id"),
  	"yyyyMMdd" // Note: this "yyyyMMdd" format is hardcoded but we need to change it to be something else.
  	),
  	partitionFormat)
  	.as("partition_id"))

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features
  • Enhanced partition date display by introducing configurable date formatting.
  • Partition dates are now consistently formatted based on user configuration, ensuring reliable and predictable output across the system.
  • Improved retrieval of partition format for BigQuery operations, allowing for broader usage across different packages.

[coderabbitai]

Walkthrough

The changes introduce a new variable, partitionFmt, in Iceberg.scala to retrieve a configurable partition format using TableUtils. The selection of the partition.ds column is modified to format it with the date_format function based on partitionFmt, while the selection of partition.hr remains unchanged. In BigQueryFormat.scala, the method of obtaining the partition format is updated to utilize TableUtils. Additionally, the visibility of partitionFormat in TableUtils is changed to public.

Changes

File	Change Summary
spark/.../Iceberg.scala	Added partitionFmt variable to fetch the partition format; updated column selection to format partition.ds with date_format.
cloud_gcp/.../BigQueryFormat.scala	Updated partitionFormat retrieval to use TableUtils(sparkSession).partitionFormat.
spark/.../TableUtils.scala	Changed visibility of partitionFormat from private[spark] to public.

Possibly related PRs

• feat: additional date parsing and write confs #181: Modifies how partitionFormat is retrieved and utilized, affecting partition columns.
• feat: read and write date types #192: Changes the retrieval and utilization of partitionFormat in a related context.
• fix: properly set partition column #407: Connects to modifications in partition handling across different components.

Suggested reviewers

• piyush-zlai
• nikhil-zlai
• varant-zlai

Poem

A new variable now takes its place,
Formatting dates with style and grace.
From Spark to BigQuery, the flow is clear,
Partition magic, let’s give a cheer!
Code and config, a perfect pair! 🎉

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 74b6cc4 and 779cd0d.

📒 Files selected for processing (3)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/TableUtils.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/format/Iceberg.scala (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• spark/src/main/scala/ai/chronon/spark/format/Iceberg.scala

🧰 Additional context used

🧠 Learnings (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (1)

Learnt from: tchow-zlai
PR: zipline-ai/chronon#263
File: cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala:29-60
Timestamp: 2025-01-24T23:55:30.256Z
Learning: In BigQuery integration, table existence check is performed outside the BigQueryFormat.createTable method, at a higher level in TableUtils.createTable.

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: streaming_tests
• GitHub Check: groupby_tests
• GitHub Check: join_tests
• GitHub Check: analyzer_tests
• GitHub Check: groupby_tests
• GitHub Check: spark_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: fetcher_tests
• GitHub Check: fetcher_tests
• GitHub Check: non_spark_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (2)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (1)

109-109: Using TableUtils for partition format looks good.

Changed to use centralized configuration from TableUtils which creates consistency across implementations.

spark/src/main/scala/ai/chronon/spark/TableUtils.scala (1)

62-62: Exposed partitionFormat to other packages.

Removed private[spark] modifier to allow access from other packages like cloud_gcp.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.