chore: cleanup unused vars

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Code Refactoring

  • Simplified GCS class constructor by removing the project parameter.
  • Updated method calls and test cases to align with the new constructor signature.

• Impact

  • Reduces complexity in object instantiation.
  • Maintains existing functionality while streamlining code structure.

[coderabbitai]

Walkthrough

The pull request modifies the GCS case class across multiple files in the Google Cloud Storage (GCS) integration module. The primary change involves removing the project parameter from the GCS class constructor, simplifying its instantiation in GCSFormat.scala, GcpFormatProvider.scala, and GCSFormatTest.scala. This change streamlines the class initialization while maintaining its core functionality for handling GCS file formats.

Changes

File	Change Summary
cloud_gcp/src/main/scala/.../GCSFormat.scala	Removed project parameter from GCS case class constructor
cloud_gcp/src/main/scala/.../GcpFormatProvider.scala	Updated getFormat and resolveTableName methods to omit project parameter when creating GCS instance
cloud_gcp/src/test/scala/.../GCSFormatTest.scala	Modified test cases to remove project parameter from GCS instantiation
cloud_gcp/src/test/scala/.../GcpFormatProviderTest.scala	Removed assertion for project property in gcsFormat tests

Possibly related PRs

• feat: GCS format support #147: This PR introduces support for the Google Cloud Storage (GCS) format, which is directly related to the changes made in the main PR that modifies the GCS case class by removing the project parameter.
• feat: Add unit tests for GCP support #162: This PR adds unit tests for GCP support, specifically validating the functionality of the GCS class, which aligns with the changes made in the main PR regarding the GCS class.
• adding again: Retrieve source uri prefix from hive partitioning options when building the GCS format #230: This PR focuses on retrieving the source URI prefix from Hive partitioning options when building the GCS format, which is directly relevant to the modifications made in the main PR regarding the GCS class.

Suggested Reviewers

• nikhil-zlai
• david-zlai
• piyush-zlai

Poem

🌥️ Farewell, project parameter bright,
Streamlined code takes graceful flight
GCS format, now lean and clean
Simplicity reigns supreme!
Cloud storage dances with delight 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9ddaaf8 and 1e3e537.

📒 Files selected for processing (3)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (3 hunks)
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GCSFormatTest.scala (3 hunks)
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala (0 hunks)

💤 Files with no reviewable changes (1)

• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala

🚧 Files skipped from review as they are similar to previous changes (1)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (3)

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GCSFormatTest.scala (3)

56-56: LGTM! Consistent with previous change.

---

86-86: LGTM! Maintains date handling functionality.

---

36-36: LGTM! Verify project parameter removal impact.

✅ Verification successful

Project parameter removal verified and safe
The project parameter has been completely removed from the GCS class definition and all its usages across the codebase follow the new two-parameter pattern (sourceUri, fileFormat).

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any remaining usages of project parameter in GCS instantiations
rg -l 'GCS\([^)]*project' 

Length of output: 27

---

Script:

#!/bin/bash
# Find GCS class definition
ast-grep --pattern 'class GCS'

# Find all GCS instantiations
rg 'GCS\(' -A 1

Length of output: 10277

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 5c8322a and 9ddaaf8.

📒 Files selected for processing (3)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GCSFormat.scala (1 hunks)
• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (1 hunks)
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GCSFormatTest.scala (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GCSFormatTest.scala

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: scala_compile_fmt_fix