adding again: Retrieve source uri prefix from hive partitioning options when building the GCS format

[david-zlai]

Summary

basically this PR: https://github.com/zipline-ai/chronon/pull/204/files

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features

  • Enhanced BigQuery API integration with more granular import statements
  • Added comprehensive test coverage for external table format handling

• Refactor

  • Updated method visibility to improve package-level access
  • Refined external table processing logic

• Tests

  • Introduced new test class for GcpFormatProvider
  • Added test case for URI handling with wildcard scenarios

[coderabbitai]

Walkthrough

The pull request modifies the GcpFormatProvider.scala file in the GCP cloud integration module, focusing on enhancing BigQuery table format handling. The changes include expanding import statements for BigQuery-related classes, adjusting the visibility of the getFormat method to package-level access, and refining the logic for processing external table definitions, particularly around URI handling and partitioning options. Additionally, a new test class is introduced to verify the behavior of the getFormat method.

Changes

File	Change Summary
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala	- Updated import statements for BigQuery classes - Changed getFormat method visibility to private[cloud_gcp] - Modified external table URI processing logic
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala	- Added new test class GcpFormatProviderTest - Implemented test case for getFormat method with mocked BigQuery table

Possibly related PRs

• feat: introduce BigQueryFormat #146: Introduction of BigQueryFormat related to format handling
• feat: GCS format support #147: Google Cloud Storage format support
• Retrieve source uri prefix from hive partitioning options when building the GCS format #204: Source URI processing improvements

Suggested Reviewers

• nikhil-zlai
• piyush-zlai

Poem

🌐 In clouds of data, BigQuery gleams,
Scala's magic weaves its streams,
URIs dance, formats align,
Code refactored, simply divine!
🚀 Integration's elegant design

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between e1a9aad and bbff96e.

📒 Files selected for processing (1)

• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: scala_compile_fmt_fix

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala (1)

19-33: Consider extracting test constants.

+  private val TestSourceUri = "gs://bucket-name/path/to/data/*.parquet"
+  private val TestTableName = "gs://bucket-name/path/to/data"

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (1)

63-71: Enhance error message for URI validation.

-            require(uris.size == 1, s"External table ${table} can be backed by only one URI.")
+            require(uris.size == 1, s"External table ${table.getTableId} must have exactly one source URI, found ${uris.size}.")

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 0bde573 and e1a9aad.

📒 Files selected for processing (2)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (2 hunks)
• cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (3)

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProviderTest.scala (2)

1-18: LGTM! Clean test setup with proper imports and local SparkSession.

---

35-39: LGTM! Comprehensive assertions covering all format properties.

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (1)

7-13: LGTM! Proper imports and appropriate visibility for testing.

Also applies to: 57-57

[tchow-zlai]

LGTM thank you for adding UT's!!!!