Skip to content

Revert "Replace npm with pnpm (#136)" #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Revert "Replace npm with pnpm (#136)" #144

merged 1 commit into from
Dec 19, 2024

Conversation

sean-zlai
Copy link
Contributor

@sean-zlai sean-zlai commented Dec 19, 2024

Summary

Reverting PR #136 to switch back to npm due to Snyk UI not supporting pnpm.overrides in package.json (best source appears to be this comment). Sounds like the CLI might support it at this time, which means the Snyk github action might work, but not worth exploring further at this time. Also not sure if Vanta requires Snyk UI for compliance.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features

    • Updated frontend build process to use npm instead of pnpm.
    • Adjusted commands for starting the development server and building the project.
  • Bug Fixes

    • Improved error handling for installation and build commands.
  • Documentation

    • Revised README files to reflect the use of npm for commands and installation instructions.
  • Chores

    • Updated dependency versions for improved compatibility and stability.

…due to support with overrides at this time)

This reverts commit 775917a.
Copy link

coderabbitai bot commented Dec 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a comprehensive shift from pnpm to npm as the package manager across the project's frontend ecosystem. This change spans multiple files including build.sbt, frontend/README.md, frontend/package.json, and frontend/playwright.config.ts. Additionally, the build configuration has been updated with version bumps for dependencies like Spark (to 3.5.1), Scala (to 2.12.18), and various libraries. The modifications ensure consistent package management and align dependencies with the latest stable releases.

Changes

File Change Summary
build.sbt - Updated Spark version to 3.5.1
- Set Scala version to 2.12.18
- Updated Jackson and Avro library versions
docker-init/README.md, frontend/README.md - Replaced pnpm commands with npm commands
frontend/package.json - Replaced all pnpm script commands with npm
- Moved package overrides to root level
frontend/playwright.config.ts - Updated web server start command from pnpm to npm

Possibly related PRs

Suggested Reviewers

  • ken-zlai
  • tchow-zlai
  • piyush-zlai

Poem

🐰 From pnpm to npm we leap,
Dependencies now neatly keep,
Build configs shine so bright and clear,
A package manager switch without fear!
Hop, hop, hurray for smoother code! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord. This feature will be included in our new Pro Plan when released, so please consider upgrading your current plan.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 775917a and 1291a57.

⛔ Files ignored due to path filters (2)
  • frontend/package-lock.json is excluded by !**/package-lock.json
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • build.sbt (1 hunks)
  • docker-init/README.md (1 hunks)
  • frontend/README.md (6 hunks)
  • frontend/package.json (2 hunks)
  • frontend/playwright.config.ts (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sean-zlai sean-zlai requested a review from ken-zlai December 19, 2024 22:21
@sean-zlai sean-zlai changed the title Revert "Replace npm with pnpm (#136)" (unable to make Snyk happy due to support with overrides at this time) Revert "Replace npm with pnpm (#136)" Dec 19, 2024
@sean-zlai sean-zlai mentioned this pull request Dec 19, 2024
4 tasks
Copy link
Contributor

@ken-zlai ken-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 sad to see snyk ui not supporting pnpm yet, but hopefully one day 🤞

@sean-zlai sean-zlai merged commit 1730474 into main Dec 19, 2024
7 checks passed
@sean-zlai sean-zlai deleted the sean/revert-pnpm branch December 19, 2024 22:25
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary

Reverting back to `npm` due to Snyk UI not supporting `pnpm.overrides`
in `package.json` (best source appears to be this
[comment](snyk/nodejs-lockfile-parser#111 (comment))).
Sounds like the CLI might support it at this time, which means the Snyk
[github action](https://github.com/snyk/actions/tree/master/node) might
work, but not worth exploring further at this time. Also not sure if
Vanta requires Snyk UI for compliance.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update


<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

Co-authored-by: Sean Lynch <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary

Reverting back to `npm` due to Snyk UI not supporting `pnpm.overrides`
in `package.json` (best source appears to be this
[comment](snyk/nodejs-lockfile-parser#111 (comment))).
Sounds like the CLI might support it at this time, which means the Snyk
[github action](https://github.com/snyk/actions/tree/master/node) might
work, but not worth exploring further at this time. Also not sure if
Vanta requires Snyk UI for compliance.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update


<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

Co-authored-by: Sean Lynch <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

Reverting back to `npm` due to Snyk UI not supporting `pnpm.overrides`
in `package.json` (best source appears to be this
[comment](snyk/nodejs-lockfile-parser#111 (comment))).
Sounds like the CLI might support it at this time, which means the Snyk
[github action](https://github.com/snyk/actions/tree/master/node) might
work, but not worth exploring further at this time. Also not sure if
Vanta requires Snyk UI for compliance.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update


<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

Co-authored-by: Sean Lynch <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary

Reverting baour clients to `npm` due to Snyk UI not supporting `pnpm.overrides`
in `paour clientsage.json` (best source appears to be this
[comment](https://github.com/snyk/nodejs-loour clientsfile-parser/issues/111#issuecomment-2384915606)).
Sounds like the CLI might support it at this time, which means the Snyk
[github action](https://github.com/snyk/actions/tree/master/node) might
work, but not worth exploring further at this time. Also not sure if
Vanta requires Snyk UI for compliance.

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update


<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

Co-authored-by: Sean Lynch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants