Skip to content

Commit 1291a57

Browse files
committed
Revert "Replace npm with pnpm (#136)" (unable to make Snyk happy due to support with overrides at this time)
This reverts commit 775917a.
1 parent 775917a commit 1291a57

File tree

7 files changed

+6078
-4012
lines changed

7 files changed

+6078
-4012
lines changed

build.sbt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,14 +240,14 @@ lazy val frontend = (project in file("frontend"))
240240
buildFrontend := {
241241
println("Installing frontend dependencies...")
242242
import scala.sys.process._
243-
val pnpmCiResult = Process("pnpm install --frozen-lockfile", file("frontend")).!
243+
val npmCiResult = Process("npm ci", file("frontend")).!
244244

245-
if (pnpmCiResult != 0) {
246-
sys.error("pnpm install failed!")
245+
if (npmCiResult != 0) {
246+
sys.error("npm ci failed!")
247247
}
248248

249249
println("Building frontend...")
250-
val buildResult = Process("pnpm run build", file("frontend")).!
250+
val buildResult = Process("npm run build", file("frontend")).!
251251

252252
if (buildResult == 0) {
253253
println("Copying frontend assets to /hub/public...")

docker-init/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ $ docker compose -f docker-init/compose.yaml up
3333

3434
The **backend** is served at: http://localhost:9000
3535

36-
The **frontend** is served at: http://localhost:3000. This serves statically built code - no live dev server. `cd frontend; pnpm run dev` for a live dev server.
36+
The **frontend** is served at: http://localhost:3000. This serves statically built code - no live dev server. `cd frontend; npm run dev` for a live dev server.
3737

3838
You can also access the parquet anomaly data table. To do so, from another terminal run:
3939

frontend/README.md

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ The frontend for Chronon.
77
### Prerequisites
88

99
- [Node.js](https://nodejs.org/en/) (LTS version recommended)
10-
- [pnpm](https://pnpm.io/installation) - fast and disk space efficient package manager
10+
- npm (comes with Node.js)
1111

1212
### Installation
1313

@@ -26,7 +26,7 @@ The frontend for Chronon.
2626

2727
3. Install dependencies:
2828
```bash
29-
pnpm install
29+
npm install
3030
```
3131

3232
### Development
@@ -53,7 +53,7 @@ Done uploading summaries! 🥳
5353
3. Then, start the development server:
5454

5555
```bash
56-
pnpm dev
56+
npm run dev
5757
```
5858

5959
This will start a local server. The app will automatically reload if you make changes to the code.
@@ -63,7 +63,7 @@ This will start a local server. The app will automatically reload if you make ch
6363
To create an optimized production build:
6464

6565
```bash
66-
pnpm build
66+
npm run build
6767
```
6868

6969
This will create an optimized version of your project in the `build` directory.
@@ -73,7 +73,7 @@ This will create an optimized version of your project in the `build` directory.
7373
To preview the production build locally:
7474

7575
```bash
76-
pnpm preview
76+
npm run preview
7777
```
7878

7979
### Running Tests
@@ -85,72 +85,72 @@ pnpm preview
8585
To run both unit and integration tests together:
8686

8787
```bash
88-
pnpm test
88+
npm run test
8989
```
9090

9191
#### Unit Tests
9292

9393
To run unit tests using Vitest:
9494

9595
```bash
96-
pnpm test:unit
96+
npm run test:unit
9797
```
9898

9999
To run unit tests once:
100100

101101
```bash
102-
pnpm test:unit:once
102+
npm run test:unit:once
103103
```
104104

105105
#### Integration Tests
106106

107107
To run integration tests using Playwright:
108108

109109
```bash
110-
pnpm test:integration
110+
npm run test:integration
111111
```
112112

113113
To run integration tests once:
114114

115115
```bash
116-
pnpm test:integration:once
116+
npm run test:integration:once
117117
```
118118

119119
For the Playwright UI to explore test results:
120120

121121
```bash
122-
pnpm test:integration:ui
122+
npm run test:integration:ui
123123
```
124124

125125
### Linting and Formatting
126126

127127
To check code formatting and linting issues:
128128

129129
```bash
130-
pnpm lint
130+
npm run lint
131131
```
132132

133133
To format the codebase:
134134

135135
```bash
136-
pnpm format
136+
npm run format
137137
```
138138

139139
### Type Checking
140140

141141
To check the TypeScript types:
142142

143143
```bash
144-
pnpm check
144+
npm run check
145145
```
146146

147147
To continuously check types while developing:
148148

149149
```bash
150-
pnpm check:watch
150+
npm run check:watch
151151
```
152152

153153
## Best Practices
154154

155-
1. **Code Style**: This project uses Prettier and ESLint for code formatting and linting. Please run `pnpm lint` and `pnpm format` before committing changes.
155+
1. **Code Style**: This project uses Prettier and ESLint for code formatting and linting. Please run `npm run lint` and `npm run format` before committing changes.
156156
2. **Testing**: Ensure all changes are covered with unit and integration tests. Use Vitest for unit tests and Playwright for integration tests.

0 commit comments

Comments
 (0)