fix(sdks): update for VSCode 1.66 #4330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Apr 6, 2022
3 tasks
merceyz
force-pushed
the
merceyz/fix/sdk-vscode-1-66
branch
from
b78f3d8 to
949e62a
Compare
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 27, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jun 28, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
kalrish
added a commit
to kalrish/AWS-organization-bootstrap
that referenced
this pull request
Jul 1, 2023
https://yarnpkg.com/sdks/cli/default ```Shell corepack yarn add --dev -- @yarnpkg/sdks ``` ``` ``` 3.0.0-rc.42 : release candidate : it's fine yarnpkg/berry@0b92a7a#diff-0bfd4a9b9f3907b0e1dcaa0667ff9311bb13942aa11c82081bb36d9abcc238e4 [GitHub repository yarnpkg/berry PR 4330]: yarnpkg/berry#4330
merceyz
added a commit
that referenced
this pull request
Oct 21, 2023
* fix(sdks): update for VSCode 1.66 * fix: re-add version detection and fix it for Windows and Linux (cherry picked from commit 39f6b0f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
VSCode 1.66 changed the format for in-memory file paths (again) in microsoft/vscode@e04c70a.
Fixes #4304
Closes #4322
How did you fix it?
Updated the pattern and fixed the VSCode version detection on Windows and Linux.
Checklist