[Bug?]: ZipFS extension broken on VSCode 1.66 #4322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojkelly
commented
Apr 3, 2022
3 tasks
|
Thanks for the PR however the issue is in the SDK, VSCode 1.66 changed the format for in-memory file paths. |
|
Great job @merceyz ! Is there any way how to immediately use it? Or we must wait for next yarn release? |
|
I'll make a release later today |
|
Released as 4.0.0-rc.1 ( |
|
After update sometimes I am facing to the same issue. Any tips? How can I debug (check some log) this issue? VS code: 1.66.1 (windows 11 64b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
A recent Vscode update broke ZipFS links.
Fixes #4304
...
How did you fix it?
It appears that the
vscode.URI.fsPathhelper (described as just sugar) no longer prepends theauthority.On macOS
/Users/owen/codebecame/owen/code, which could not be found.I can't find the specific commit where this change occurred, but this fix does resolve the issue.
I didn't apply this change to the
TerminalLinkProvider, as I wasn't able to get a good repro setup going for that. I suspect it will need some kind of fix....
Checklist